<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16354] trunk/wp-admin/includes:
Make manage_users_custom_column hook consistent between WP_(MS)?
_Users_List_Table.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16354">16354</a></dd>
<dt>Author</dt> <dd>scribu</dd>
<dt>Date</dt> <dd>2010-11-13 20:47:34 +0000 (Sat, 13 Nov 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make manage_users_custom_column hook consistent between WP_(MS)?_Users_List_Table. Fixes <a href="http://trac.wordpress.org/ticket/14562">#14562</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesclasswpmsuserslisttablephp">trunk/wp-admin/includes/class-wp-ms-users-list-table.php</a></li>
<li><a href="#trunkwpadminincludesclasswpuserslisttablephp">trunk/wp-admin/includes/class-wp-users-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesclasswpmsuserslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-ms-users-list-table.php (16353 => 16354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-ms-users-list-table.php 2010-11-13 18:32:43 UTC (rev 16353)
+++ trunk/wp-admin/includes/class-wp-ms-users-list-table.php 2010-11-13 20:47:34 UTC (rev 16354)
</span><span class="lines">@@ -159,6 +159,12 @@
</span><span class="cx"> list( $columns, $hidden ) = $this->get_column_info();
</span><span class="cx">
</span><span class="cx"> foreach ( $columns as $column_name => $column_display_name ) :
</span><ins>+ $style = '';
+ if ( in_array( $column_name, $hidden ) )
+ $style = ' style="display:none;"';
+
+ $attributes = "$class$style";
+
</ins><span class="cx"> switch ( $column_name ) {
</span><span class="cx"> case 'cb': ?>
</span><span class="cx"> <th scope="row" class="check-column">
</span><span class="lines">@@ -248,7 +254,7 @@
</span><span class="cx"> break;
</span><span class="cx">
</span><span class="cx"> default: ?>
</span><del>- <td><?php do_action( 'manage_users_custom_column', $column_name, $user->ID ); ?></td>
</del><ins>+ <td><?php echo apply_filters( 'manage_users_custom_column', '', $column_name, $user->ID ); ?></td>
</ins><span class="cx"> <?php
</span><span class="cx"> break;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkwpadminincludesclasswpuserslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-users-list-table.php (16353 => 16354)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-users-list-table.php 2010-11-13 18:32:43 UTC (rev 16353)
+++ trunk/wp-admin/includes/class-wp-users-list-table.php 2010-11-13 20:47:34 UTC (rev 16354)
</span><span class="lines">@@ -214,9 +214,10 @@
</span><span class="cx"> $edit = '<strong>' . $user_object->user_login . '</strong>';
</span><span class="cx"> }
</span><span class="cx"> $role_name = isset( $wp_roles->role_names[$role] ) ? translate_user_role( $wp_roles->role_names[$role] ) : __( 'None' );
</span><del>- $r = "<tr id='user-$user_object->ID'$style>";
</del><span class="cx"> $avatar = get_avatar( $user_object->ID, 32 );
</span><span class="cx">
</span><ins>+ $r = "<tr id='user-$user_object->ID'$style>";
+
</ins><span class="cx"> list( $columns, $hidden ) = $this->get_column_info();
</span><span class="cx">
</span><span class="cx"> foreach ( $columns as $column_name => $column_display_name ) {
</span></span></pre>
</div>
</div>
</body>
</html>