<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16270] trunk/wp-content/plugins/hello.php: Hello Dolly 1.6.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16270">16270</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-11-10 12:43:04 +0000 (Wed, 10 Nov 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Hello Dolly 1.6. fixes typo, props sbressler, fixes <a href="http://trac.wordpress.org/ticket/15229">#15229</a>. Removes absolute from positioning, props kapeels, fixes <a href="http://trac.wordpress.org/ticket/15228">#15228</a>. Add some whitespace.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpcontentpluginshellophp">trunk/wp-content/plugins/hello.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpcontentpluginshellophp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/plugins/hello.php (16269 => 16270)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/plugins/hello.php        2010-11-10 12:28:03 UTC (rev 16269)
+++ trunk/wp-content/plugins/hello.php        2010-11-10 12:43:04 UTC (rev 16270)
</span><span class="lines">@@ -1,14 +1,14 @@
</span><span class="cx"> <?php
</span><span class="cx"> /**
</span><span class="cx"> * @package Hello_Dolly
</span><del>- * @version 1.5.1
</del><ins>+ * @version 1.6
</ins><span class="cx"> */
</span><span class="cx"> /*
</span><span class="cx"> Plugin Name: Hello Dolly
</span><del>-Plugin URI: http://wordpress.org/#
</del><ins>+Plugin URI: http://wordpress.org/extend/plugins/hello-dolly/
</ins><span class="cx"> Description: This is not just a plugin, it symbolizes the hope and enthusiasm of an entire generation summed up in two words sung most famously by Louis Armstrong: Hello, Dolly. When activated you will randomly see a lyric from <cite>Hello, Dolly</cite> in the upper right of your admin screen on every page.
</span><span class="cx"> Author: Matt Mullenweg
</span><del>-Version: 1.5.1
</del><ins>+Version: 1.6
</ins><span class="cx"> Author URI: http://ma.tt/
</span><span class="cx"> */
</span><span class="cx">
</span><span class="lines">@@ -44,10 +44,10 @@
</span><span class="cx"> Dolly'll never go away again";
</span><span class="cx">
</span><span class="cx">         // Here we split it into lines
</span><del>-        $lyrics = explode("\n", $lyrics);
</del><ins>+        $lyrics = explode( "\n", $lyrics );
</ins><span class="cx">
</span><span class="cx">         // And then randomly choose a line
</span><del>-        return wptexturize( $lyrics[ mt_rand(0, count($lyrics) - 1) ] );
</del><ins>+        return wptexturize( $lyrics[ mt_rand( 0, count( $lyrics ) - 1 ) ] );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // This just echoes the chosen line, we'll position it later
</span><span class="lines">@@ -56,28 +56,27 @@
</span><span class="cx">         echo "<p id='dolly'>$chosen</p>";
</span><span class="cx"> }
</span><span class="cx">
</span><del>-// Now we set that function up to execute when the admin_footer action is called
-add_action('admin_footer', 'hello_dolly');
</del><ins>+// Now we set that function up to execute when the admin_notices action is called
+add_action( 'admin_notices', 'hello_dolly' );
</ins><span class="cx">
</span><span class="cx"> // We need some CSS to position the paragraph
</span><span class="cx"> function dolly_css() {
</span><del>-        // This makes sure that the posinioning is also good for right-to-left languages
-        $x = ( is_rtl() ) ? 'left' : 'right';
</del><ins>+        // This makes sure that the positioning is also good for right-to-left languages
+        $x = is_rtl() ? 'left' : 'right';
</ins><span class="cx">
</span><span class="cx">         echo "
</span><span class="cx">         <style type='text/css'>
</span><span class="cx">         #dolly {
</span><del>-                position: absolute;
-                top: 4.5em;
</del><ins>+                float: $x;
+                padding-$x: 15px;
+                padding-top: 5px;                
</ins><span class="cx">                 margin: 0;
</span><del>-                padding: 0;
-                $x: 215px;
</del><span class="cx">                 font-size: 11px;
</span><span class="cx">         }
</span><span class="cx">         </style>
</span><span class="cx">         ";
</span><span class="cx"> }
</span><span class="cx">
</span><del>-add_action('admin_head', 'dolly_css');
</del><ins>+add_action( 'admin_head', 'dolly_css' );
</ins><span class="cx">
</span><span class="cx"> ?>
</span></span></pre>
</div>
</div>
</body>
</html>