<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16160] trunk: Show latest x users with no paging if on a large network.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16160">16160</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2010-11-03 13:34:04 +0000 (Wed, 03 Nov 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Show latest x users with no paging if on a large network. see <a href="http://trac.wordpress.org/ticket/15170">#15170</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesclasswpmsuserslisttablephp">trunk/wp-admin/includes/class-wp-ms-users-list-table.php</a></li>
<li><a href="#trunkwpincludesuserphp">trunk/wp-includes/user.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesclasswpmsuserslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-ms-users-list-table.php (16159 => 16160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-ms-users-list-table.php 2010-11-02 23:25:24 UTC (rev 16159)
+++ trunk/wp-admin/includes/class-wp-ms-users-list-table.php 2010-11-03 13:34:04 UTC (rev 16160)
</span><span class="lines">@@ -38,6 +38,16 @@
</span><span class="cx"> 'blog_id' => 0
</span><span class="cx"> );
</span><span class="cx">
</span><ins>+ // If the network is large and a search is not being performed, show only the latest users with no paging in order
+ // to avoid expensive count queries.
+ if ( !$usersearch && ( get_blog_count() >= 10000 ) ) {
+ if ( !isset($_REQUEST['orderby']) )
+ $_GET['orderby'] = $_REQUEST['orderby'] = 'id';
+ if ( !isset($_REQUEST['order']) )
+ $_GET['order'] = $_REQUEST['order'] = 'DESC';
+ $args['count_total'] = false;
+ }
+
</ins><span class="cx"> if ( isset( $_REQUEST['orderby'] ) )
</span><span class="cx"> $args['orderby'] = $_REQUEST['orderby'];
</span><span class="cx">
</span></span></pre></div>
<a id="trunkwpincludesuserphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/user.php (16159 => 16160)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/user.php 2010-11-02 23:25:24 UTC (rev 16159)
+++ trunk/wp-includes/user.php 2010-11-03 13:34:04 UTC (rev 16160)
</span><span class="lines">@@ -411,11 +411,9 @@
</span><span class="cx"> // sorting
</span><span class="cx"> if ( in_array( $qv['orderby'], array('email', 'url', 'registered') ) ) {
</span><span class="cx"> $orderby = 'user_' . $qv['orderby'];
</span><del>- }
- elseif ( 'name' == $qv['orderby'] ) {
</del><ins>+ } elseif ( 'name' == $qv['orderby'] ) {
</ins><span class="cx"> $orderby = 'display_name';
</span><del>- }
- elseif ( 'post_count' == $qv['orderby'] ) {
</del><ins>+ } elseif ( 'post_count' == $qv['orderby'] ) {
</ins><span class="cx"> $where = get_posts_by_author_sql('post');
</span><span class="cx"> $this->query_from .= " LEFT OUTER JOIN (
</span><span class="cx"> SELECT post_author, COUNT(*) as post_count
</span><span class="lines">@@ -425,8 +423,9 @@
</span><span class="cx"> ) p ON ({$wpdb->users}.ID = p.post_author)
</span><span class="cx"> ";
</span><span class="cx"> $orderby = 'post_count';
</span><del>- }
- else {
</del><ins>+ } elseif ( 'id' == $qv['orderby'] ) {
+ $orderby = 'ID';
+ } else {
</ins><span class="cx"> $orderby = 'user_login';
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>