<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[15891] trunk/wp-includes/capabilities.php:
Only check the post author if the post type supports authors.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/15891">15891</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-10-21 14:55:15 +0000 (Thu, 21 Oct 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Only check the post author if the post type supports authors. see <a href="http://trac.wordpress.org/ticket/14122">#14122</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludescapabilitiesphp">trunk/wp-includes/capabilities.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludescapabilitiesphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/capabilities.php (15890 => 15891)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/capabilities.php 2010-10-21 14:40:04 UTC (rev 15890)
+++ trunk/wp-includes/capabilities.php 2010-10-21 14:55:15 UTC (rev 15891)
</span><span class="lines">@@ -819,18 +819,19 @@
</span><span class="cx"> case 'delete_post':
</span><span class="cx"> case 'delete_page':
</span><span class="cx"> $author_data = get_userdata( $user_id );
</span><del>- //echo "post ID: {$args[0]}<br />";
</del><span class="cx"> $post = get_post( $args[0] );
</span><span class="cx"> $post_type = get_post_type_object( $post->post_type );
</span><ins>+
</ins><span class="cx"> if ( 'delete_post' == $cap && $post_type && 'post' != $post_type->capability_type && ! $post_type->map_meta_cap ) {
</span><span class="cx"> $args = array_merge( array( $post_type->cap->delete_post, $user_id ), $args );
</span><span class="cx"> return call_user_func_array( 'map_meta_cap', $args );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( '' != $post->post_author ) {
</del><ins>+ if ( '' != $post->post_author && post_type_supports( $post_type->name, 'author' ) ) {
</ins><span class="cx"> $post_author_data = get_userdata( $post->post_author );
</span><span class="cx"> } else {
</span><del>- //No author set yet so default to current user for cap checks
</del><ins>+ // No author set yet or post type doesn't support authors,
+ // so default to current user for cap checks.
</ins><span class="cx"> $post_author_data = $author_data;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -861,15 +862,22 @@
</span><span class="cx"> case 'edit_post':
</span><span class="cx"> case 'edit_page':
</span><span class="cx"> $author_data = get_userdata( $user_id );
</span><del>- //echo "post ID: {$args[0]}<br />";
</del><span class="cx"> $post = get_post( $args[0] );
</span><ins>+ $post_type = get_post_type_object( $post->post_type );
</ins><span class="cx">
</span><del>- $post_type = get_post_type_object( $post->post_type );
</del><span class="cx"> if ( 'edit_post' == $cap && $post_type && 'post' != $post_type->capability_type && ! $post_type->map_meta_cap ) {
</span><span class="cx"> $args = array_merge( array( $post_type->cap->edit_post, $user_id ), $args );
</span><span class="cx"> return call_user_func_array( 'map_meta_cap', $args );
</span><span class="cx"> }
</span><del>- $post_author_data = get_userdata( $post->post_author );
</del><ins>+
+ if ( '' != $post->post_author && post_type_supports( $post_type->name, 'author' ) ) {
+ $post_author_data = get_userdata( $post->post_author );
+ } else {
+ // No author set yet or post type doesn't support authors,
+ // so default to current user for cap checks.
+ $post_author_data = $author_data;
+ }
+
</ins><span class="cx"> //echo "current user id : $user_id, post author id: " . $post_author_data->ID . "<br />";
</span><span class="cx"> // If the user is the author...
</span><span class="cx"> if ( is_object( $post_author_data ) && $user_id == $post_author_data->ID ) {
</span><span class="lines">@@ -895,8 +903,10 @@
</span><span class="cx"> break;
</span><span class="cx"> case 'read_post':
</span><span class="cx"> case 'read_page':
</span><ins>+ $author_data = get_userdata( $user_id );
</ins><span class="cx"> $post = get_post( $args[0] );
</span><span class="cx"> $post_type = get_post_type_object( $post->post_type );
</span><ins>+
</ins><span class="cx"> if ( 'read_post' == $cap && $post_type && 'post' != $post_type->capability_type && ! $post_type->map_meta_cap ) {
</span><span class="cx"> $args = array_merge( array( $post_type->cap->read_post, $user_id ), $args );
</span><span class="cx"> return call_user_func_array( 'map_meta_cap', $args );
</span><span class="lines">@@ -907,8 +917,14 @@
</span><span class="cx"> break;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- $author_data = get_userdata( $user_id );
- $post_author_data = get_userdata( $post->post_author );
</del><ins>+ if ( '' != $post->post_author && post_type_supports( $post_type->name, 'author' ) ) {
+ $post_author_data = get_userdata( $post->post_author );
+ } else {
+ // No author set yet or post type doesn't support authors,
+ // so default to current user for cap checks.
+ $post_author_data = $author_data;
+ }
+
</ins><span class="cx"> if ( is_object( $post_author_data ) && $user_id == $post_author_data->ID )
</span><span class="cx"> $caps[] = $post_type->cap->read;
</span><span class="cx"> else
</span></span></pre>
</div>
</div>
</body>
</html>