<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[15761] trunk/wp-admin/themes.php: Fix some notices.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/15761">15761</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-10-09 08:59:57 +0000 (Sat, 09 Oct 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix some notices. props mrmist, fixes <a href="http://trac.wordpress.org/ticket/15079">#15079</a>. Also some standards fixes.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminthemesphp">trunk/wp-admin/themes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminthemesphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/themes.php (15760 => 15761)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/themes.php        2010-10-09 05:25:09 UTC (rev 15760)
+++ trunk/wp-admin/themes.php        2010-10-09 08:59:57 UTC (rev 15761)
</span><span class="lines">@@ -136,41 +136,40 @@
</span><span class="cx"> <p class="search-box">
</span><span class="cx">         <label class="screen-reader-text" for="theme-search-input"><?php _e('Search Themes'); ?>:</label>
</span><span class="cx">         <input type="text" id="tag-search-input" name="s" value="<?php _admin_search_query(); ?>" />
</span><del>-        <input type="submit" value="<?php esc_attr_e('Search Themes'); ?>" class="button" />
</del><ins>+        <input type="submit" value="<?php esc_attr_e('Search Themes'); ?>" class="button" />
</ins><span class="cx">         <a id="filter-click" href="?filter=1"><?php _e( 'Feature Filter' ); ?></a>
</span><span class="cx"> </p>
</span><span class="cx">
</span><span class="cx"> <br class="clear"/>
</span><span class="cx">
</span><del>-<div id="filters" <?php if ( $tpage != 'filter' ) echo ' style="display: none"' ?>>
</del><ins>+<div id="filters" <?php if ( ! isset( $tpage ) || $tpage != 'filter' ) echo ' style="display: none"' ?>>
</ins><span class="cx"> <?php $feature_list = get_theme_feature_list(); ?>
</span><span class="cx">         <div class="feature-filter">
</span><span class="cx">                 <p class="install-help"><?php _e('Theme filters') ?></p>
</span><span class="cx">
</span><del>-        <?php foreach ( $feature_list as $feature_name => $features ) : ?>
-                <?php        $feature_name = esc_html( $feature_name ); ?>
</del><ins>+        <?php foreach ( $feature_list as $feature_name => $features ) :
+                        $feature_name = esc_html( $feature_name ); ?>
</ins><span class="cx">                 
</span><span class="cx">                 <div class="feature-container">
</span><span class="cx">                         <div class="feature-name"><?php echo $feature_name ?></div>
</span><del>-                
</del><ins>+
</ins><span class="cx">                         <ol style="float: left; width: 725px;" class="feature-group">
</span><del>-                                <?php foreach ( $features as $key => $feature ) : ?>
-                                        <?php
</del><ins>+                                <?php foreach ( $features as $key => $feature ) :
</ins><span class="cx">                                                 $feature_name = $feature;
</span><span class="cx">                                                 $feature_name = esc_html( $feature_name );
</span><span class="cx">                                                 $feature = esc_attr($feature);
</span><span class="cx">                                                 ?>
</span><span class="cx">                                 <li>
</span><del>-                                        <input type="checkbox" name="features[<?php echo $key; ?>]" id="feature-id-<?php echo $key; ?>" value="<?php echo $key; ?>" <?php if ( in_array( $key, $checked_features ) ) echo ' checked="checked"' ?>/>
</del><ins>+                                        <input type="checkbox" name="features[<?php echo $key; ?>]" id="feature-id-<?php echo $key; ?>" value="<?php echo $key; ?>" <?php checked( isset( $checked_features ) && in_array( $key, $checked_features ) ); ?>/>
</ins><span class="cx">                                         <label for="feature-id-<?php echo $key; ?>"><?php echo $feature_name; ?></label>
</span><span class="cx">                                 </li>
</span><del>-                                <?php        endforeach; ?>
</del><ins>+                                <?php endforeach; ?>
</ins><span class="cx">                         </ol>
</span><span class="cx">                 </div>
</span><del>-        <?php        endforeach; ?>
</del><ins>+        <?php endforeach; ?>
</ins><span class="cx">
</span><span class="cx">         <div class="feature-container">
</span><del>-                <input style="margin-left: 120px" type="submit" class="button-secondary submitter" value="<?php _e( 'Apply Filters' ); ?>" />
</del><ins>+                <input style="margin-left: 120px" type="submit" class="button-secondary submitter" value="<?php esc_attr_e( 'Apply Filters' ); ?>" />
</ins><span class="cx">                 &nbsp;
</span><span class="cx">                 <small><a id="mini-filter-click" href="<?php echo admin_url( 'themes.php' ); ?>"><?php _e( 'Close filters' )?></a></small>
</span><span class="cx">         </div>
</span></span></pre>
</div>
</div>
</body>
</html>