<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[15761] trunk/wp-admin/themes.php: Fix some notices.</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/15761">15761</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-10-09 08:59:57 +0000 (Sat, 09 Oct 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>Fix some notices. props mrmist, fixes <a href="http://trac.wordpress.org/ticket/15079">#15079</a>. Also some standards fixes.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminthemesphp">trunk/wp-admin/themes.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminthemesphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/themes.php (15760 => 15761)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/themes.php        2010-10-09 05:25:09 UTC (rev 15760)
+++ trunk/wp-admin/themes.php        2010-10-09 08:59:57 UTC (rev 15761)
</span><span class="lines">@@ -136,41 +136,40 @@
</span><span class="cx"> &lt;p class=&quot;search-box&quot;&gt;
</span><span class="cx">         &lt;label class=&quot;screen-reader-text&quot; for=&quot;theme-search-input&quot;&gt;&lt;?php _e('Search Themes'); ?&gt;:&lt;/label&gt;
</span><span class="cx">         &lt;input type=&quot;text&quot; id=&quot;tag-search-input&quot; name=&quot;s&quot; value=&quot;&lt;?php _admin_search_query(); ?&gt;&quot; /&gt;
</span><del>-        &lt;input type=&quot;submit&quot; value=&quot;&lt;?php esc_attr_e('Search Themes');  ?&gt;&quot; class=&quot;button&quot; /&gt;
</del><ins>+        &lt;input type=&quot;submit&quot; value=&quot;&lt;?php esc_attr_e('Search Themes'); ?&gt;&quot; class=&quot;button&quot; /&gt;
</ins><span class="cx">         &lt;a id=&quot;filter-click&quot; href=&quot;?filter=1&quot;&gt;&lt;?php _e( 'Feature Filter' ); ?&gt;&lt;/a&gt;
</span><span class="cx"> &lt;/p&gt;
</span><span class="cx"> 
</span><span class="cx"> &lt;br class=&quot;clear&quot;/&gt;
</span><span class="cx"> 
</span><del>-&lt;div id=&quot;filters&quot; &lt;?php if ( $tpage != 'filter' ) echo ' style=&quot;display: none&quot;' ?&gt;&gt;
</del><ins>+&lt;div id=&quot;filters&quot; &lt;?php if ( ! isset( $tpage ) || $tpage != 'filter' ) echo ' style=&quot;display: none&quot;' ?&gt;&gt;
</ins><span class="cx"> &lt;?php $feature_list = get_theme_feature_list(); ?&gt;
</span><span class="cx">         &lt;div class=&quot;feature-filter&quot;&gt;
</span><span class="cx">                 &lt;p class=&quot;install-help&quot;&gt;&lt;?php _e('Theme filters') ?&gt;&lt;/p&gt;
</span><span class="cx"> 
</span><del>-        &lt;?php foreach ( $feature_list as $feature_name =&gt; $features ) : ?&gt;
-                &lt;?php        $feature_name = esc_html( $feature_name ); ?&gt;
</del><ins>+        &lt;?php foreach ( $feature_list as $feature_name =&gt; $features ) :
+                        $feature_name = esc_html( $feature_name ); ?&gt;
</ins><span class="cx">                 
</span><span class="cx">                 &lt;div class=&quot;feature-container&quot;&gt;
</span><span class="cx">                         &lt;div class=&quot;feature-name&quot;&gt;&lt;?php echo $feature_name ?&gt;&lt;/div&gt;
</span><del>-                
</del><ins>+
</ins><span class="cx">                         &lt;ol style=&quot;float: left; width: 725px;&quot; class=&quot;feature-group&quot;&gt;
</span><del>-                                &lt;?php foreach ( $features as $key =&gt; $feature ) : ?&gt;
-                                        &lt;?php
</del><ins>+                                &lt;?php foreach ( $features as $key =&gt; $feature ) :
</ins><span class="cx">                                                 $feature_name = $feature;
</span><span class="cx">                                                 $feature_name = esc_html( $feature_name );
</span><span class="cx">                                                 $feature = esc_attr($feature);
</span><span class="cx">                                                 ?&gt;
</span><span class="cx">                                 &lt;li&gt;
</span><del>-                                        &lt;input type=&quot;checkbox&quot; name=&quot;features[&lt;?php echo $key; ?&gt;]&quot; id=&quot;feature-id-&lt;?php echo $key; ?&gt;&quot; value=&quot;&lt;?php echo $key; ?&gt;&quot; &lt;?php if ( in_array( $key, $checked_features ) ) echo ' checked=&quot;checked&quot;' ?&gt;/&gt;
</del><ins>+                                        &lt;input type=&quot;checkbox&quot; name=&quot;features[&lt;?php echo $key; ?&gt;]&quot; id=&quot;feature-id-&lt;?php echo $key; ?&gt;&quot; value=&quot;&lt;?php echo $key; ?&gt;&quot; &lt;?php checked( isset( $checked_features ) &amp;&amp; in_array( $key, $checked_features ) ); ?&gt;/&gt;
</ins><span class="cx">                                         &lt;label for=&quot;feature-id-&lt;?php echo $key; ?&gt;&quot;&gt;&lt;?php echo $feature_name; ?&gt;&lt;/label&gt;
</span><span class="cx">                                 &lt;/li&gt;
</span><del>-                                &lt;?php        endforeach; ?&gt;
</del><ins>+                                &lt;?php endforeach; ?&gt;
</ins><span class="cx">                         &lt;/ol&gt;
</span><span class="cx">                 &lt;/div&gt;
</span><del>-        &lt;?php        endforeach; ?&gt;
</del><ins>+        &lt;?php endforeach; ?&gt;
</ins><span class="cx"> 
</span><span class="cx">         &lt;div class=&quot;feature-container&quot;&gt;
</span><del>-                &lt;input style=&quot;margin-left: 120px&quot; type=&quot;submit&quot; class=&quot;button-secondary submitter&quot; value=&quot;&lt;?php _e( 'Apply Filters' ); ?&gt;&quot; /&gt;
</del><ins>+                &lt;input style=&quot;margin-left: 120px&quot; type=&quot;submit&quot; class=&quot;button-secondary submitter&quot; value=&quot;&lt;?php esc_attr_e( 'Apply Filters' ); ?&gt;&quot; /&gt;
</ins><span class="cx">                 &amp;nbsp;
</span><span class="cx">                 &lt;small&gt;&lt;a id=&quot;mini-filter-click&quot; href=&quot;&lt;?php echo admin_url( 'themes.php' ); ?&gt;&quot;&gt;&lt;?php _e( 'Close filters' )?&gt;&lt;/a&gt;&lt;/small&gt;
</span><span class="cx">         &lt;/div&gt;
</span></span></pre>
</div>
</div>

</body>
</html>