<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[15662] trunk/wp-admin: Prevent the $title global from being stomped.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/15662">15662</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-09-26 09:16:38 +0000 (Sun, 26 Sep 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Prevent the $title global from being stomped. Caused by merger of manage_columns_prefs() into screen_meta() in <a href="http://trac.wordpress.org/changeset/15653">[15653]</a>. see <a href="http://trac.wordpress.org/ticket/14952">#14952</a>, see <a href="http://trac.wordpress.org/ticket/14776">#14776</a>. The global is apparent cruft as the function doesn't use it.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminadminheaderphp">trunk/wp-admin/admin-header.php</a></li>
<li><a href="#trunkwpadminincludestemplatephp">trunk/wp-admin/includes/template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminadminheaderphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/admin-header.php (15661 => 15662)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/admin-header.php 2010-09-26 08:51:34 UTC (rev 15661)
+++ trunk/wp-admin/admin-header.php 2010-09-26 09:16:38 UTC (rev 15662)
</span><span class="lines">@@ -161,8 +161,12 @@
</span><span class="cx"> <?php
</span><span class="cx"> unset($title_class, $blog_name);
</span><span class="cx">
</span><ins>+var_dump( $title );
+
</ins><span class="cx"> require(ABSPATH . 'wp-admin/menu-header.php');
</span><span class="cx">
</span><ins>+var_dump( $title );
+
</ins><span class="cx"> $current_screen->parent_file = $parent_file;
</span><span class="cx"> $current_screen->parent_base = preg_replace('/\?.*$/', '', $parent_file);
</span><span class="cx"> $current_screen->parent_base = str_replace('.php', '', $current_screen->parent_base);
</span><span class="lines">@@ -170,8 +174,11 @@
</span><span class="cx">
</span><span class="cx"> <div id="wpbody-content">
</span><span class="cx"> <?php
</span><ins>+var_dump( $title );
</ins><span class="cx"> screen_meta($current_screen);
</span><span class="cx">
</span><ins>+var_dump( $title );
+
</ins><span class="cx"> if ( is_multisite() ) {
</span><span class="cx"> if ( is_network_admin() )
</span><span class="cx"> do_action('network_admin_notices');
</span></span></pre></div>
<a id="trunkwpadminincludestemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/template.php (15661 => 15662)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/template.php 2010-09-26 08:51:34 UTC (rev 15661)
+++ trunk/wp-admin/includes/template.php 2010-09-26 09:16:38 UTC (rev 15662)
</span><span class="lines">@@ -1635,7 +1635,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function screen_meta($screen) {
</span><del>- global $wp_meta_boxes, $_wp_contextual_help, $title, $wp_list_table;
</del><ins>+ global $wp_meta_boxes, $_wp_contextual_help, $wp_list_table;
</ins><span class="cx">
</span><span class="cx"> if ( is_string($screen) )
</span><span class="cx"> $screen = convert_to_screen($screen);
</span></span></pre>
</div>
</div>
</body>
</html>