<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[15212] trunk/wp-content/themes/twentyten/functions.php: Use a switch.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/15212">15212</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-06-11 03:34:52 +0000 (Fri, 11 Jun 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use a switch. props jdub, see <a href="http://trac.wordpress.org/ticket/13812">#13812</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpcontentthemestwentytenfunctionsphp">trunk/wp-content/themes/twentyten/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpcontentthemestwentytenfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyten/functions.php (15211 => 15212)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyten/functions.php        2010-06-11 03:03:17 UTC (rev 15211)
+++ trunk/wp-content/themes/twentyten/functions.php        2010-06-11 03:34:52 UTC (rev 15212)
</span><span class="lines">@@ -351,8 +351,10 @@
</span><span class="cx"> * @since Twenty Ten 1.0
</span><span class="cx"> */
</span><span class="cx"> function twentyten_comment( $comment, $args, $depth ) {
</span><del>-        $GLOBALS['comment'] = $comment; ?>
-        <?php if ( '' == $comment->comment_type ) : ?>
</del><ins>+        $GLOBALS['comment'] = $comment;
+        switch ( $comment->comment_type ) :
+                case '' :
+        ?>
</ins><span class="cx">         <li <?php comment_class(); ?> id="li-comment-<?php comment_ID(); ?>">
</span><span class="cx">                 <div id="comment-<?php comment_ID(); ?>">
</span><span class="cx">                 <div class="comment-author vcard">
</span><span class="lines">@@ -378,10 +380,16 @@
</span><span class="cx">                 </div><!-- .reply -->
</span><span class="cx">         </div><!-- #comment-## -->
</span><span class="cx">
</span><del>-        <?php elseif ( in_array($comment->comment_type, array('pingback', 'trackback')) ) : ?>
</del><ins>+        <?php
+                        break;
+                case 'pingback' :
+                case 'trackback' :
+        ?>
</ins><span class="cx">         <li class="post pingback">
</span><span class="cx">                 <p><?php _e( 'Pingback:', 'twentyten' ); ?> <?php comment_author_link(); ?><?php edit_comment_link( __('(Edit)', 'twentyten'), ' ' ); ?></p>
</span><del>-        <?php endif;
</del><ins>+        <?php
+                        break;
+        endswitch;
</ins><span class="cx"> }
</span><span class="cx"> endif;
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>