<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[14782] trunk/wp-includes/capabilities.php:
  Some sanity checks -- make sure we have a valid post author user object before checking if the current user is the author
 .</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/14782">14782</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-05-21 15:15:32 +0000 (Fri, 21 May 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>Some sanity checks -- make sure we have a valid post author user object before checking if the current user is the author.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludescapabilitiesphp">trunk/wp-includes/capabilities.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludescapabilitiesphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/capabilities.php (14781 => 14782)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/capabilities.php        2010-05-21 15:08:07 UTC (rev 14781)
+++ trunk/wp-includes/capabilities.php        2010-05-21 15:15:32 UTC (rev 14782)
</span><span class="lines">@@ -835,7 +835,7 @@
</span><span class="cx">                 }
</span><span class="cx"> 
</span><span class="cx">                 // If the user is the author...
</span><del>-                if ( $user_id == $post_author_data-&gt;ID ) {
</del><ins>+                if ( is_object( $post_author_data ) &amp;&amp; $user_id == $post_author_data-&gt;ID ) {
</ins><span class="cx">                         // If the post is published...
</span><span class="cx">                         if ( 'publish' == $post-&gt;post_status ) {
</span><span class="cx">                                 $caps[] = 'delete_published_posts';
</span><span class="lines">@@ -871,7 +871,7 @@
</span><span class="cx">                         $page_author_data = $author_data;
</span><span class="cx">                 }
</span><span class="cx"> 
</span><del>-                if ( $user_id == $page_author_data-&gt;ID ) {
</del><ins>+                if ( is_object( $page_author_data ) &amp;&amp; $user_id == $page_author_data-&gt;ID ) {
</ins><span class="cx">                         // If the page is published...
</span><span class="cx">                         if ( $page-&gt;post_status == 'publish' ) {
</span><span class="cx">                                 $caps[] = 'delete_published_pages';
</span><span class="lines">@@ -906,7 +906,7 @@
</span><span class="cx">                 $post_author_data = get_userdata( $post-&gt;post_author );
</span><span class="cx">                 //echo &quot;current user id : $user_id, post author id: &quot; . $post_author_data-&gt;ID . &quot;&lt;br /&gt;&quot;;
</span><span class="cx">                 // If the user is the author...
</span><del>-                if ( $user_id == $post_author_data-&gt;ID ) {
</del><ins>+                if ( is_object( $post_author_data ) &amp;&amp; $user_id == $post_author_data-&gt;ID ) {
</ins><span class="cx">                         // If the post is published...
</span><span class="cx">                         if ( 'publish' == $post-&gt;post_status ) {
</span><span class="cx">                                 $caps[] = 'edit_published_posts';
</span><span class="lines">@@ -934,7 +934,7 @@
</span><span class="cx">                 $page_author_data = get_userdata( $page-&gt;post_author );
</span><span class="cx">                 //echo &quot;current user id : $user_id, page author id: &quot; . $page_author_data-&gt;ID . &quot;&lt;br /&gt;&quot;;
</span><span class="cx">                 // If the user is the author...
</span><del>-                if ( $user_id == $page_author_data-&gt;ID ) {
</del><ins>+                if ( is_object( $page_author_data ) &amp;&amp; $user_id == $page_author_data-&gt;ID ) {
</ins><span class="cx">                         // If the page is published...
</span><span class="cx">                         if ( 'publish' == $page-&gt;post_status ) {
</span><span class="cx">                                 $caps[] = 'edit_published_pages';
</span><span class="lines">@@ -970,7 +970,7 @@
</span><span class="cx"> 
</span><span class="cx">                 $author_data = get_userdata( $user_id );
</span><span class="cx">                 $post_author_data = get_userdata( $post-&gt;post_author );
</span><del>-                if ( $user_id == $post_author_data-&gt;ID )
</del><ins>+                if ( is_object( $post_author_data ) &amp;&amp; $user_id == $post_author_data-&gt;ID )
</ins><span class="cx">                         $caps[] = 'read';
</span><span class="cx">                 else
</span><span class="cx">                         $caps[] = 'read_private_posts';
</span><span class="lines">@@ -985,7 +985,7 @@
</span><span class="cx"> 
</span><span class="cx">                 $author_data = get_userdata( $user_id );
</span><span class="cx">                 $page_author_data = get_userdata( $page-&gt;post_author );
</span><del>-                if ( $user_id == $page_author_data-&gt;ID )
</del><ins>+                if ( is_object( $page_author_data ) &amp;&amp; $user_id == $page_author_data-&gt;ID )
</ins><span class="cx">                         $caps[] = 'read';
</span><span class="cx">                 else
</span><span class="cx">                         $caps[] = 'read_private_pages';
</span></span></pre>
</div>
</div>

</body>
</html>