<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[14779] trunk/wp-includes/user.php: Fix showing selected for none.</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/14779">14779</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2010-05-21 14:35:39 +0000 (Fri, 21 May 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>Fix showing selected for none. Props johnbillion. fixes <a href="http://trac.wordpress.org/ticket/13468">#13468</a></pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesuserphp">trunk/wp-includes/user.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesuserphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/user.php (14778 => 14779)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/user.php        2010-05-21 14:17:41 UTC (rev 14778)
+++ trunk/wp-includes/user.php        2010-05-21 14:35:39 UTC (rev 14779)
</span><span class="lines">@@ -621,12 +621,14 @@
</span><span class="cx">                 if ( $show_option_all )
</span><span class="cx">                         $output .= &quot;\t&lt;option value='0'&gt;$show_option_all&lt;/option&gt;\n&quot;;
</span><span class="cx"> 
</span><del>-                if ( $show_option_none )
-                        $output .= &quot;\t&lt;option value='-1'&gt;$show_option_none&lt;/option&gt;\n&quot;;
</del><ins>+                if ( $show_option_none ) {
+                        $_selected = selected( -1, $selected, false );
+                        $output .= &quot;\t&lt;option value='-1'$_selected&gt;$show_option_none&lt;/option&gt;\n&quot;;
+                }
</ins><span class="cx"> 
</span><span class="cx">                 foreach ( (array) $users as $user ) {
</span><span class="cx">                         $user-&gt;ID = (int) $user-&gt;ID;
</span><del>-                        $_selected = $user-&gt;ID == $selected ? &quot; selected='selected'&quot; : '';
</del><ins>+                        $_selected = selected( $user-&gt;ID, $selected, false );
</ins><span class="cx">                         $display = !empty($user-&gt;$show) ? $user-&gt;$show : '('. $user-&gt;user_login . ')';
</span><span class="cx">                         $output .= &quot;\t&lt;option value='$user-&gt;ID'$_selected&gt;&quot; . esc_html($display) . &quot;&lt;/option&gt;\n&quot;;
</span><span class="cx">                 }
</span></span></pre>
</div>
</div>

</body>
</html>