<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[14625] trunk: Use valid HTML in the theme editor.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/14625">14625</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-05-14 07:04:17 +0000 (Fri, 14 May 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use valid HTML in the theme editor. span instead of div inside an anchor. props Utkarsh, see <a href="http://trac.wordpress.org/ticket/13383">#13383</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadmincssthemeeditorcss">trunk/wp-admin/css/theme-editor.css</a></li>
<li><a href="#trunkwpadmincssthemeeditordevcss">trunk/wp-admin/css/theme-editor.dev.css</a></li>
<li><a href="#trunkwpadminthemeeditorphp">trunk/wp-admin/theme-editor.php</a></li>
<li><a href="#trunkwpincludesscriptloaderphp">trunk/wp-includes/script-loader.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadmincssthemeeditorcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/theme-editor.css (14624 => 14625)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/theme-editor.css 2010-05-14 06:48:47 UTC (rev 14624)
+++ trunk/wp-admin/css/theme-editor.css 2010-05-14 07:04:17 UTC (rev 14625)
</span><span class="lines">@@ -1 +1 @@
</span><del>-#template textarea{font-family:Consolas,Monaco,Courier,monospace;font-size:12px;width:97%;}#template p{width:97%;}#templateside{float:right;width:190px;word-wrap:break-word;}#templateside h3,#postcustomstuff p.submit{margin:0;}#templateside h4{margin:1em 0 0;}#templateside ol,#templateside ul{margin:.5em;padding:0;}#templateside li{margin:4px 0;}.nonessential{font-size:11px;font-style:italic;padding-left:12px;}.highlight{padding:3px 3px 3px 12px;margin-left:-12px;font-weight:bold;-moz-border-radius:8px;-khtml-border-radius:8px;-webkit-border-radius:8px;border-radius:8px;}div.tablenav{margin-right:210px;}#documentation{margin-top:10px;}#documentation label{line-height:22px;vertical-align:top;font-weight:bold;}.fileedit-sub{padding:10px 0 8px;line-height:180%;}
</del><span class="cx">\ No newline at end of file
</span><ins>+#template textarea{font-family:Consolas,Monaco,Courier,monospace;font-size:12px;width:97%;}#template p{width:97%;}#templateside{float:right;width:190px;word-wrap:break-word;}#templateside h3,#postcustomstuff p.submit{margin:0;}#templateside h4{margin:1em 0 0;}#templateside ol,#templateside ul{margin:.5em;padding:0;}#templateside li{margin:4px 0;}#templateside ul li a span.highlight{display:block;}.nonessential{font-size:11px;font-style:italic;padding-left:12px;}.highlight{padding:3px 3px 3px 12px;margin-left:-12px;font-weight:bold;-moz-border-radius:8px;-khtml-border-radius:8px;-webkit-border-radius:8px;border-radius:8px;}div.tablenav{margin-right:210px;}#documentation{margin-top:10px;}#documentation label{line-height:22px;vertical-align:top;font-weight:bold;}.fileedit-sub{padding:10px 0 8px;line-height:180%;}
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkwpadmincssthemeeditordevcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/theme-editor.dev.css (14624 => 14625)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/theme-editor.dev.css 2010-05-14 06:48:47 UTC (rev 14624)
+++ trunk/wp-admin/css/theme-editor.dev.css 2010-05-14 07:04:17 UTC (rev 14625)
</span><span class="lines">@@ -33,6 +33,10 @@
</span><span class="cx"> margin: 4px 0;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+#templateside ul li a span.highlight {
+ display:block;
+}
+
</ins><span class="cx"> .nonessential {
</span><span class="cx"> font-size: 11px;
</span><span class="cx"> font-style: italic;
</span></span></pre></div>
<a id="trunkwpadminthemeeditorphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/theme-editor.php (14624 => 14625)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/theme-editor.php 2010-05-14 06:48:47 UTC (rev 14624)
+++ trunk/wp-admin/theme-editor.php 2010-05-14 07:04:17 UTC (rev 14625)
</span><span class="lines">@@ -154,7 +154,7 @@
</span><span class="cx"> $description = trim( get_file_description($template_file) );
</span><span class="cx"> $template_show = basename($template_file);
</span><span class="cx"> $filedesc = ( $description != $template_file ) ? "$description<br /><span class='nonessential'>($template_show)</span>" : "$description";
</span><del>- $filedesc = ( $template_file == $file ) ? "<div class='highlight'>$description<br /><span class='nonessential'>($template_show)</span></div>" : $filedesc;
</del><ins>+ $filedesc = ( $template_file == $file ) ? "<span class='highlight'>$description<br /><span class='nonessential'>($template_show)</span></span>" : $filedesc;
</ins><span class="cx">
</span><span class="cx"> // If we have two files of the same name prefer the one in the Template Directory
</span><span class="cx"> // This means that we display the correct files for child themes which overload Templates as well as Styles
</span><span class="lines">@@ -181,7 +181,7 @@
</span><span class="cx"> $description = trim( get_file_description($style_file) );
</span><span class="cx"> $style_show = basename($style_file);
</span><span class="cx"> $filedesc = ( $description != $style_file ) ? "$description<br /><span class='nonessential'>($style_show)</span>" : "$description";
</span><del>- $filedesc = ( $style_file == $file ) ? "<div class='highlight'>$description<br /><span class='nonessential'>($style_show)</span></div>" : $filedesc;
</del><ins>+ $filedesc = ( $style_file == $file ) ? "<span class='highlight'>$description<br /><span class='nonessential'>($style_show)</span></span>" : $filedesc;
</ins><span class="cx"> $template_mapping[ $description ] = array( _get_template_edit_filename($style_file, $stylesheet_dir), $filedesc );
</span><span class="cx"> }
</span><span class="cx"> ksort( $template_mapping );
</span></span></pre></div>
<a id="trunkwpincludesscriptloaderphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/script-loader.php (14624 => 14625)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/script-loader.php 2010-05-14 06:48:47 UTC (rev 14624)
+++ trunk/wp-includes/script-loader.php 2010-05-14 07:04:17 UTC (rev 14625)
</span><span class="lines">@@ -467,7 +467,7 @@
</span><span class="cx"> $styles->add( 'widgets', "/wp-admin/css/widgets$suffix.css", array(), '20091118' );
</span><span class="cx"> $styles->add( 'dashboard', "/wp-admin/css/dashboard$suffix.css", array(), '20100424' );
</span><span class="cx"> $styles->add( 'install', "/wp-admin/css/install$suffix.css", array(), '20100313' ); // Readme as well
</span><del>- $styles->add( 'theme-editor', "/wp-admin/css/theme-editor$suffix.css", array(), '20090625' );
</del><ins>+ $styles->add( 'theme-editor', "/wp-admin/css/theme-editor$suffix.css", array(), '20100514' );
</ins><span class="cx"> $styles->add( 'press-this', "/wp-admin/css/press-this$suffix.css", array(), '20100424' );
</span><span class="cx"> $styles->add( 'thickbox', '/wp-includes/js/thickbox/thickbox.css', array(), '20090514' );
</span><span class="cx"> $styles->add( 'login', "/wp-admin/css/login$suffix.css", array(), '20100403' );
</span></span></pre>
</div>
</div>
</body>
</html>