<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[14561] trunk/wp-includes/post.php: Don't set/
get tags or categories for post types that do not support them.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/14561">14561</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2010-05-11 16:28:00 +0000 (Tue, 11 May 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't set/get tags or categories for post types that do not support them. fixes <a href="http://trac.wordpress.org/ticket/13346">#13346</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludespostphp">trunk/wp-includes/post.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post.php (14560 => 14561)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post.php 2010-05-11 15:55:17 UTC (rev 14560)
+++ trunk/wp-includes/post.php 2010-05-11 16:28:00 UTC (rev 14561)
</span><span class="lines">@@ -1992,14 +1992,21 @@
</span><span class="cx"> $post = get_post($postid, $mode);
</span><span class="cx">
</span><span class="cx"> // Set categories and tags
</span><del>- if($mode == OBJECT) {
- $post->post_category = wp_get_post_categories($postid);
- $post->tags_input = wp_get_post_tags($postid, array('fields' => 'names'));
</del><ins>+ if ( $mode == OBJECT ) {
+ $post->post_category = array();
+ if ( is_object_in_taxonomy($post->post_type, 'category') )
+ $post->post_category = wp_get_post_categories($postid);
+ $post->tags_input = array();
+ if ( is_object_in_taxonomy($post->post_type, 'post_tag') )
+ $post->tags_input = wp_get_post_tags($postid, array('fields' => 'names'));
+ } else {
+ $post['post_category'] = array();
+ if ( is_object_in_taxonomy($post['post_type'], 'category') )
+ $post['post_category'] = wp_get_post_categories($postid);
+ $post['tags_input'] = array();
+ if ( is_object_in_taxonomy($post['post_type'], 'post_tag') )
+ $post['tags_input'] = wp_get_post_tags($postid, array('fields' => 'names'));
</ins><span class="cx"> }
</span><del>- else {
- $post['post_category'] = wp_get_post_categories($postid);
- $post['tags_input'] = wp_get_post_tags($postid, array('fields' => 'names'));
- }
</del><span class="cx">
</span><span class="cx"> return $post;
</span><span class="cx"> }
</span><span class="lines">@@ -2240,9 +2247,10 @@
</span><span class="cx"> $wpdb->update( $wpdb->posts, array( 'post_name' => $data['post_name'] ), $where );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- wp_set_post_categories( $post_ID, $post_category );
- // old-style tags_input
- if ( isset( $tags_input ) )
</del><ins>+ if ( is_object_in_taxonomy($post_type, 'category') )
+ wp_set_post_categories( $post_ID, $post_category );
+
+ if ( isset( $tags_input ) && is_object_in_taxonomy($post_type, 'post_tag') )
</ins><span class="cx"> wp_set_post_tags( $post_ID, $tags_input );
</span><span class="cx">
</span><span class="cx"> // new-style support for all custom taxonomies
</span></span></pre>
</div>
</div>
</body>
</html>