<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[14426] trunk: Handle $_POST containing an empty term array,
Fixes saving of deselecting all hierarchical terms.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/14426">14426</a></dd>
<dt>Author</dt> <dd>dd32</dd>
<dt>Date</dt> <dd>2010-05-03 23:35:22 +0000 (Mon, 03 May 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Handle $_POST containing an empty term array, Fixes saving of deselecting all hierarchical terms. Fixes <a href="http://trac.wordpress.org/ticket/10122">#10122</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesmetaboxesphp">trunk/wp-admin/includes/meta-boxes.php</a></li>
<li><a href="#trunkwpincludespostphp">trunk/wp-includes/post.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesmetaboxesphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/meta-boxes.php (14425 => 14426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/meta-boxes.php 2010-05-03 23:25:14 UTC (rev 14425)
+++ trunk/wp-admin/includes/meta-boxes.php 2010-05-03 23:35:22 UTC (rev 14426)
</span><span class="lines">@@ -307,6 +307,10 @@
</span><span class="cx"> </div>
</span><span class="cx">
</span><span class="cx"> <div id="<?php echo $taxonomy; ?>-all" class="tabs-panel">
</span><ins>+ <?php
+ $name = ( $taxonomy == 'category' ) ? 'post_category' : 'tax_input[' . $taxonomy . ']';
+ echo "<input type='hidden' name='{$name}[]' value='0' />"; // Allows for an empty term set to be sent. 0 is an invalid Term ID and will be ignored by empty() checks.
+ ?>
</ins><span class="cx"> <ul id="<?php echo $taxonomy; ?>checklist" class="list:<?php echo $taxonomy?> categorychecklist form-no-clear">
</span><span class="cx"> <?php wp_terms_checklist($post->ID, array( 'taxonomy' => $taxonomy, 'popular_cats' => $popular_ids ) ) ?>
</span><span class="cx"> </ul>
</span></span></pre></div>
<a id="trunkwpincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post.php (14425 => 14426)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post.php 2010-05-03 23:25:14 UTC (rev 14425)
+++ trunk/wp-includes/post.php 2010-05-03 23:35:22 UTC (rev 14426)
</span><span class="lines">@@ -2071,6 +2071,9 @@
</span><span class="cx"> if ( empty($post_type) )
</span><span class="cx"> $post_type = 'post';
</span><span class="cx">
</span><ins>+ if ( !empty($post_category) )
+ $post_category = array_filter($post_category); // Filter out empty terms
+
</ins><span class="cx"> // Make sure we set a valid category.
</span><span class="cx"> if ( empty($post_category) || 0 == count($post_category) || !is_array($post_category) ) {
</span><span class="cx"> // 'post' requires at least one category.
</span><span class="lines">@@ -2225,12 +2228,16 @@
</span><span class="cx">
</span><span class="cx"> wp_set_post_categories( $post_ID, $post_category );
</span><span class="cx"> // old-style tags_input
</span><del>- if ( isset( $tags_input ) )
</del><ins>+ if ( isset( $tags_input ) ) {
+ $tags_input = array_filter($tags_input);
</ins><span class="cx"> wp_set_post_tags( $post_ID, $tags_input );
</span><del>- // new-style support for all tag-like taxonomies
</del><ins>+ }
+ // new-style support for all custom taxonomies
</ins><span class="cx"> if ( !empty($tax_input) ) {
</span><span class="cx"> foreach ( $tax_input as $taxonomy => $tags ) {
</span><span class="cx"> $taxonomy_obj = get_taxonomy($taxonomy);
</span><ins>+ if ( is_array($tags) ) // array = hierarchical, string = non-hierarchical.
+ $tags = array_filter($tags);
</ins><span class="cx"> if ( current_user_can($taxonomy_obj->assign_cap) )
</span><span class="cx"> wp_set_post_terms( $post_ID, $tags, $taxonomy );
</span><span class="cx"> }
</span><span class="lines">@@ -2784,8 +2791,8 @@
</span><span class="cx"> $leaf_path = sanitize_title(basename($page_paths));
</span><span class="cx"> $page_paths = explode('/', $page_paths);
</span><span class="cx"> $full_path = '';
</span><del>- foreach( (array) $page_paths as $pathdir)
- $full_path .= ($pathdir!=''?'/':'') . sanitize_title($pathdir);
</del><ins>+ foreach ( (array) $page_paths as $pathdir )
+ $full_path .= ( $pathdir != '' ? '/' : '' ) . sanitize_title($pathdir);
</ins><span class="cx">
</span><span class="cx"> $pages = $wpdb->get_results( $wpdb->prepare( "SELECT ID, post_name, post_parent FROM $wpdb->posts WHERE post_name = %s AND (post_type = %s OR post_type = 'attachment')", $leaf_path, $post_type ));
</span><span class="cx">
</span><span class="lines">@@ -3668,7 +3675,7 @@
</span><span class="cx"> * @return int Same as $post_id
</span><span class="cx"> */
</span><span class="cx"> function wp_check_for_changed_slugs($post_id) {
</span><del>- if ( !isset($_POST['wp-old-slug']) || !strlen($_POST['wp-old-slug']) )
</del><ins>+ if ( empty($_POST['wp-old-slug']) )
</ins><span class="cx"> return $post_id;
</span><span class="cx">
</span><span class="cx"> $post = &get_post($post_id);
</span></span></pre>
</div>
</div>
</body>
</html>