<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[14299] trunk/wp-admin: Don't call get_plugins() in menu.php.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/14299">14299</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2010-04-29 16:38:12 +0000 (Thu, 29 Apr 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't call get_plugins() in menu.php. It is too slow to call on every admin page load. fixes <a href="http://trac.wordpress.org/ticket/13117">#13117</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminmenuphp">trunk/wp-admin/menu.php</a></li>
<li><a href="#trunkwpadminplugineditorphp">trunk/wp-admin/plugin-editor.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminmenuphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/menu.php (14298 => 14299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/menu.php 2010-04-29 16:05:33 UTC (rev 14298)
+++ trunk/wp-admin/menu.php 2010-04-29 16:38:12 UTC (rev 14299)
</span><span class="lines">@@ -168,11 +168,9 @@
</span><span class="cx"> $submenu['plugins.php'][5] = array( __('Installed'), 'activate_plugins', 'plugins.php' );
</span><span class="cx"> /* translators: add new plugin */
</span><span class="cx"> $submenu['plugins.php'][10] = array(_x('Add New', 'plugin'), 'install_plugins', 'plugin-install.php');
</span><del>- $plugins = get_plugins();
- if( !empty($plugins) )
- $submenu['plugins.php'][15] = array( _x('Editor', 'plugin editor'), 'edit_plugins', 'plugin-editor.php' );
</del><ins>+ $submenu['plugins.php'][15] = array( _x('Editor', 'plugin editor'), 'edit_plugins', 'plugin-editor.php' );
</ins><span class="cx"> }
</span><del>-unset($menu_perms, $update_plugins, $update_count, $plugins);
</del><ins>+unset($menu_perms, $update_plugins, $update_count);
</ins><span class="cx">
</span><span class="cx"> if ( current_user_can('list_users') )
</span><span class="cx"> $menu[70] = array( __('Users'), 'list_users', 'users.php', '', 'menu-top menu-icon-users', 'menu-users', 'div' );
</span></span></pre></div>
<a id="trunkwpadminplugineditorphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/plugin-editor.php (14298 => 14299)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/plugin-editor.php 2010-04-29 16:05:33 UTC (rev 14298)
+++ trunk/wp-admin/plugin-editor.php 2010-04-29 16:38:12 UTC (rev 14299)
</span><span class="lines">@@ -21,7 +21,7 @@
</span><span class="cx">
</span><span class="cx"> $plugins = get_plugins();
</span><span class="cx">
</span><del>-if( empty($plugins) )
</del><ins>+if ( empty($plugins) )
</ins><span class="cx"> wp_die( __('There are no plugins installed on this site.') );
</span><span class="cx">
</span><span class="cx"> if ( isset($_REQUEST['file']) )
</span></span></pre>
</div>
</div>
</body>
</html>