<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[13980] trunk/wp-admin/options-permalink.php: Don'
t allow # in custom permalink structures and cat/tag bases.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/13980">13980</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-04-04 00:41:39 +0000 (Sun, 04 Apr 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't allow # in custom permalink structures and cat/tag bases. Improve some MS branching. fixes <a href="http://trac.wordpress.org/ticket/12271">#12271</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminoptionspermalinkphp">trunk/wp-admin/options-permalink.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminoptionspermalinkphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/options-permalink.php (13979 => 13980)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/options-permalink.php 2010-04-04 00:24:16 UTC (rev 13979)
+++ trunk/wp-admin/options-permalink.php 2010-04-04 00:41:39 UTC (rev 13980)
</span><span class="lines">@@ -78,34 +78,34 @@
</span><span class="cx"> if ( isset($_POST['permalink_structure']) || isset($_POST['category_base']) ) {
</span><span class="cx"> check_admin_referer('update-permalink');
</span><span class="cx">
</span><del>- if ( isset($_POST['permalink_structure']) ) {
</del><ins>+ if ( isset( $_POST['permalink_structure'] ) ) {
</ins><span class="cx"> $permalink_structure = $_POST['permalink_structure'];
</span><del>- if (! empty($permalink_structure) )
- $permalink_structure = preg_replace('#/+#', '/', '/' . $_POST['permalink_structure']);
- if ( is_multisite() && !is_subdomain_install() && $permalink_structure != '' && is_main_site() ) {
- $permalink_structure = '/blog' . $permalink_structure;
</del><ins>+ if ( ! empty( $permalink_structure ) ) {
+ $permalink_structure = preg_replace( '#/+#', '/', '/' . str_replace( '#', '', $permalink_structure ) );
+ if ( is_multisite() && ! is_subdomain_install() && is_main_site() )
+ $permalink_structure = '/blog' . $permalink_structure;
</ins><span class="cx"> }
</span><del>- $wp_rewrite->set_permalink_structure($permalink_structure);
</del><ins>+ $wp_rewrite->set_permalink_structure( $permalink_structure );
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- if ( isset($_POST['category_base']) ) {
</del><ins>+ if ( isset( $_POST['category_base'] ) ) {
</ins><span class="cx"> $category_base = $_POST['category_base'];
</span><del>- if (! empty($category_base) )
- $category_base = preg_replace('#/+#', '/', '/' . $_POST['category_base']);
- if ( is_multisite() && !is_subdomain_install() && $category_base != '' && is_main_site() ) {
- $category_base = '/blog' . $category_base;
</del><ins>+ if (! empty( $category_base ) ) {
+ $category_base = preg_replace('#/+#', '/', '/' . str_replace( '#', '', $category_base ) );
+ if ( is_multisite() && ! is_subdomain_install() && is_main_site() )
+ $category_base = '/blog' . $category_base;
</ins><span class="cx"> }
</span><del>- $wp_rewrite->set_category_base($category_base);
</del><ins>+ $wp_rewrite->set_category_base( $category_base );
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- if ( isset($_POST['tag_base']) ) {
</del><ins>+ if ( isset( $_POST['tag_base'] ) ) {
</ins><span class="cx"> $tag_base = $_POST['tag_base'];
</span><del>- if (! empty($tag_base) )
- $tag_base = preg_replace('#/+#', '/', '/' . $_POST['tag_base']);
- if ( is_multisite() && !is_subdomain_install() && $tag_base != '' && is_main_site() ) {
- $tag_base = '/blog' . $tag_base;
</del><ins>+ if ( ! empty( $tag_base ) ) {
+ $tag_base = preg_replace('#/+#', '/', '/' . str_replace( '#', '', $tag_base ) );
+ if ( is_multisite() && ! is_subdomain_install() && is_main_site() )
+ $tag_base = '/blog' . $tag_base;
</ins><span class="cx"> }
</span><del>- $wp_rewrite->set_tag_base($tag_base);
</del><ins>+ $wp_rewrite->set_tag_base( $tag_base );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>