<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[13841] trunk/wp-admin: Use $ptype_obj->edit_type_cap instead of '
edit_posts' for custom post_type menu's & edit.php access.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/13841">13841</a></dd>
<dt>Author</dt> <dd>dd32</dd>
<dt>Date</dt> <dd>2010-03-27 06:40:59 +0000 (Sat, 27 Mar 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use $ptype_obj->edit_type_cap instead of 'edit_posts' for custom post_type menu's & edit.php access. Allows for a user to have the capability to edit a post_type irrespective of their Posts access. Props rovo89. Fixes <a href="http://trac.wordpress.org/ticket/12691">#12691</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadmineditphp">trunk/wp-admin/edit.php</a></li>
<li><a href="#trunkwpadminmenuphp">trunk/wp-admin/menu.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadmineditphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/edit.php (13840 => 13841)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/edit.php 2010-03-27 06:21:53 UTC (rev 13840)
+++ trunk/wp-admin/edit.php 2010-03-27 06:40:59 UTC (rev 13841)
</span><span class="lines">@@ -9,7 +9,17 @@
</span><span class="cx"> /** WordPress Administration Bootstrap */
</span><span class="cx"> require_once('admin.php');
</span><span class="cx">
</span><del>-if ( !current_user_can('edit_posts') )
</del><ins>+if ( !isset($_GET['post_type']) )
+ $post_type = 'post';
+elseif ( in_array( $_GET['post_type'], get_post_types( array('public' => true ) ) ) )
+ $post_type = $_GET['post_type'];
+else
+ wp_die( __('Invalid post type') );
+$_GET['post_type'] = $post_type;
+
+$post_type_object = get_post_type_object($post_type);
+
+if ( !current_user_can($post_type_object->edit_type_cap) )
</ins><span class="cx"> wp_die(__('Cheatin&#8217; uh?'));
</span><span class="cx">
</span><span class="cx"> // Back-compat for viewing comments of an entry
</span><span class="lines">@@ -20,16 +30,6 @@
</span><span class="cx"> unset( $_redirect );
</span><span class="cx"> }
</span><span class="cx">
</span><del>-if ( !isset($_GET['post_type']) )
- $post_type = 'post';
-elseif ( in_array( $_GET['post_type'], get_post_types( array('public' => true ) ) ) )
- $post_type = $_GET['post_type'];
-else
- wp_die( __('Invalid post type') );
-$_GET['post_type'] = $post_type;
-
-$post_type_object = get_post_type_object($post_type);
-
</del><span class="cx"> if ( 'post' != $post_type ) {
</span><span class="cx"> $parent_file = "edit.php?post_type=$post_type";
</span><span class="cx"> $submenu_file = "edit.php?post_type=$post_type";
</span></span></pre></div>
<a id="trunkwpadminmenuphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/menu.php (13840 => 13841)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/menu.php 2010-03-27 06:21:53 UTC (rev 13840)
+++ trunk/wp-admin/menu.php 2010-03-27 06:40:59 UTC (rev 13841)
</span><span class="lines">@@ -118,9 +118,9 @@
</span><span class="cx"> $ptype_obj = get_post_type_object($ptype);
</span><span class="cx">
</span><span class="cx"> $menu[$_wp_last_object_menu] = array(esc_attr($ptype_obj->label), $ptype_obj->edit_type_cap, "edit.php?post_type=$ptype", '', 'menu-top menu-icon-posts', 'menu-' . sanitize_html_class($ptype), 'div');
</span><del>- $submenu["edit.php?post_type=$ptype"][5] = array( __('Edit'), 'edit_posts', "edit.php?post_type=$ptype");
</del><ins>+ $submenu["edit.php?post_type=$ptype"][5] = array( __('Edit'), $ptype_obj->edit_type_cap, "edit.php?post_type=$ptype");
</ins><span class="cx"> /* translators: add new custom post type */
</span><del>- $submenu["edit.php?post_type=$ptype"][10] = array( _x('Add New', 'post'), 'edit_posts', "post-new.php?post_type=$ptype" );
</del><ins>+ $submenu["edit.php?post_type=$ptype"][10] = array( _x('Add New', 'post'), $ptype_obj->edit_type_cap, "post-new.php?post_type=$ptype" );
</ins><span class="cx">
</span><span class="cx"> $i = 15;
</span><span class="cx"> foreach ( $wp_taxonomies as $tax ) {
</span></span></pre>
</div>
</div>
</body>
</html>