<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[13647] trunk/wp-includes: Add no_found_rows argument to WP_Query::
get_posts() to allow forcibly defeating SQL_CALC_FOUND_ROWS.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/13647">13647</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2010-03-10 18:37:03 +0000 (Wed, 10 Mar 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add no_found_rows argument to WP_Query::get_posts() to allow forcibly defeating SQL_CALC_FOUND_ROWS. Use no_found_rows for the query in get_boundary_post(). fixes <a href="http://trac.wordpress.org/ticket/12557">#12557</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludeslinktemplatephp">trunk/wp-includes/link-template.php</a></li>
<li><a href="#trunkwpincludesqueryphp">trunk/wp-includes/query.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludeslinktemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/link-template.php (13646 => 13647)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/link-template.php 2010-03-10 17:44:32 UTC (rev 13646)
+++ trunk/wp-includes/link-template.php 2010-03-10 18:37:03 UTC (rev 13647)
</span><span class="lines">@@ -1158,7 +1158,7 @@
</span><span class="cx">
</span><span class="cx"> $order = $start ? 'ASC' : 'DESC';
</span><span class="cx">
</span><del>- return get_posts( array('numberposts' => 1, 'order' => $order, 'orderby' => 'ID', 'category' => $categories) );
</del><ins>+ return get_posts( array('numberposts' => 1, 'no_found_rows' => true, 'order' => $order, 'orderby' => 'ID', 'category' => $categories) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="trunkwpincludesqueryphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/query.php (13646 => 13647)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/query.php 2010-03-10 17:44:32 UTC (rev 13646)
+++ trunk/wp-includes/query.php 2010-03-10 18:37:03 UTC (rev 13647)
</span><span class="lines">@@ -1672,6 +1672,12 @@
</span><span class="cx"> $q['page'] = absint($q['page']);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ // If true, forcibly turns off SQL_CALC_FOUND_ROWS even when limits are present.
+ if ( isset($q['no_found_rows']) )
+ $q['no_found_rows'] = (bool) $q['no_found_rows'];
+ else
+ $q['no_found_rows'] = false;
+
</ins><span class="cx"> // If a month is specified in the querystring, load that month
</span><span class="cx"> if ( $q['m'] ) {
</span><span class="cx"> $q['m'] = '' . preg_replace('|[^0-9]|', '', $q['m']);
</span><span class="lines">@@ -2331,7 +2337,7 @@
</span><span class="cx"> if ( !empty( $orderby ) )
</span><span class="cx"> $orderby = 'ORDER BY ' . $orderby;
</span><span class="cx"> $found_rows = '';
</span><del>- if ( !empty($limits) )
</del><ins>+ if ( !$q['no_found_rows'] && !empty($limits) )
</ins><span class="cx"> $found_rows = 'SQL_CALC_FOUND_ROWS';
</span><span class="cx">
</span><span class="cx"> $this->request = " SELECT $found_rows $distinct $fields FROM $wpdb->posts $join WHERE 1=1 $where $groupby $orderby $limits";
</span><span class="lines">@@ -2356,7 +2362,7 @@
</span><span class="cx"> $this->comment_count = count($this->comments);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( !empty($limits) ) {
</del><ins>+ if ( !$q['no_found_rows'] && !empty($limits) ) {
</ins><span class="cx"> $found_posts_query = apply_filters( 'found_posts_query', 'SELECT FOUND_ROWS()' );
</span><span class="cx"> $this->found_posts = $wpdb->get_var( $found_posts_query );
</span><span class="cx"> $this->found_posts = apply_filters( 'found_posts', $this->found_posts );
</span></span></pre>
</div>
</div>
</body>
</html>