<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[13592] trunk/wp-admin:
Do not display user specified password during install.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/13592">13592</a></dd>
<dt>Author</dt> <dd>dd32</dd>
<dt>Date</dt> <dd>2010-03-05 12:25:30 +0000 (Fri, 05 Mar 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Do not display user specified password during install. Fixes <a href="http://trac.wordpress.org/ticket/12479">#12479</a>. See <a href="http://trac.wordpress.org/ticket/10396">#10396</a> for feedback</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadmincssinstallcss">trunk/wp-admin/css/install.css</a></li>
<li><a href="#trunkwpadmincssinstalldevcss">trunk/wp-admin/css/install.dev.css</a></li>
<li><a href="#trunkwpadminincludesupgradephp">trunk/wp-admin/includes/upgrade.php</a></li>
<li><a href="#trunkwpadmininstallphp">trunk/wp-admin/install.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadmincssinstallcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/install.css (13591 => 13592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/install.css 2010-03-05 06:20:41 UTC (rev 13591)
+++ trunk/wp-admin/css/install.css 2010-03-05 12:25:30 UTC (rev 13592)
</span><span class="lines">@@ -1 +1 @@
</span><del>-html{background:#f9f9f9;}body{background:#fff;color:#333;font-family:"Lucida Grande",Verdana,Arial,"Bitstream Vera Sans",sans-serif;margin:2em auto;width:700px;padding:1em 2em;-moz-border-radius:11px;-khtml-border-radius:11px;-webkit-border-radius:11px;border-radius:11px;border:1px solid #dfdfdf;}a{color:#2583ad;text-decoration:none;}a:hover{color:#d54e21;}h1{border-bottom:1px solid #dadada;clear:both;color:#666;font:24px Georgia,"Times New Roman",Times,serif;margin:5px 0 0 -4px;padding:0;padding-bottom:7px;}h2{font-size:16px;}p,li,dd,dt{padding-bottom:2px;font-size:12px;line-height:18px;}code{font-size:13px;}ul,ol,dl{padding:5px 5px 5px 22px;}a img{border:0;}abbr{border:0;font-variant:normal;}#logo{margin:6px 0 14px 0;border-bottom:none;text-align:center;}.step{margin:20px 0 15px;}.step,th{text-align:left;padding:0;}.submit input,.button,.button-secondary{font-family:"Lucida Grande",Verdana,Arial,"Bitstream Vera Sans",sans-serif;text-decoration:none;font-size:14px!important;line-height:16px;padding:6px 12px;cursor:pointer;border:1px solid #bbb;color:#464646;-moz-border-radius:15px;-khtml-border-radius:15px;-webkit-border-radius:15px;border-radius:15px;-moz-box-sizing:content-box;-webkit-box-sizing:content-box;-khtml-box-sizing:content-box;box-sizing:content-box;}.button:hover,.button-secondary:hover,.submit input:hover{color:#000;border-color:#666;}.button,.submit input,.button-secondary{background:#f2f2f2 url(../images/white-grad.png) repeat-x scroll left top;}.button:active,.submit input:active,.button-secondary:active{background:#eee url(../images/white-grad-active.png) repeat-x scroll left top;}.form-table{border-collapse:collapse;margin-top:1em;width:100%;}.form-table td{margin-bottom:9px;padding:10px;border-bottom:8px solid #fff;font-size:12px;}.form-table th{font-size:13px;text-align:left;padding:16px 10px 10px 10px;border-bottom:8px solid #fff;width:110px;vertical-align:top;}.form-table tr{background:#f3f3f3;}.form-table code{line-height:18px;font-size:18px;}.form-table p{margin:4px 0 0 0;font-size:11px;}.form-table input{line-height:20px;font-size:15px;padding:2px;}#error-page{margin-top:50px;}#error-page p{font-size:12px;line-height:18px;margin:25px 0 20px;}#error-page code{font-family:Consolas,Monaco,Courier,monospace;}#pass-strength-result{background-color:#eee;border-color:#ddd!important;border-style:solid;border-width:1px;float:left;margin:12px 5px 5px 1px;padding:5px;text-align:center;width:200px;}#pass-strength-result.bad{background-color:#ffb78c;border-color:#ff853c!important;}#pass-strength-result.good{background-color:#ffec8b;border-color:#fc0!important;}#pass-strength-result.short{background-color:#ffa0a0;border-color:#f04040!important;}#pass-strength-result.strong{background-color:#c3ff88;border-color:#8dff1c!important;}
</del><span class="cx">\ No newline at end of file
</span><ins>+html{background:#f9f9f9;}body{background:#fff;color:#333;font-family:"Lucida Grande",Verdana,Arial,"Bitstream Vera Sans",sans-serif;margin:2em auto;width:700px;padding:1em 2em;-moz-border-radius:11px;-khtml-border-radius:11px;-webkit-border-radius:11px;border-radius:11px;border:1px solid #dfdfdf;}a{color:#2583ad;text-decoration:none;}a:hover{color:#d54e21;}h1{border-bottom:1px solid #dadada;clear:both;color:#666;font:24px Georgia,"Times New Roman",Times,serif;margin:5px 0 0 -4px;padding:0;padding-bottom:7px;}h2{font-size:16px;}p,li,dd,dt{padding-bottom:2px;font-size:12px;line-height:18px;}code{font-size:13px;}ul,ol,dl{padding:5px 5px 5px 22px;}a img{border:0;}abbr{border:0;font-variant:normal;}#logo{margin:6px 0 14px 0;border-bottom:none;text-align:center;}.step{margin:20px 0 15px;}.step,th{text-align:left;padding:0;}.submit input,.button,.button-secondary{font-family:"Lucida Grande",Verdana,Arial,"Bitstream Vera Sans",sans-serif;text-decoration:none;font-size:14px!important;line-height:16px;padding:6px 12px;cursor:pointer;border:1px solid #bbb;color:#464646;-moz-border-radius:15px;-khtml-border-radius:15px;-webkit-border-radius:15px;border-radius:15px;-moz-box-sizing:content-box;-webkit-box-sizing:content-box;-khtml-box-sizing:content-box;box-sizing:content-box;}.button:hover,.button-secondary:hover,.submit input:hover{color:#000;border-color:#666;}.button,.submit input,.button-secondary{background:#f2f2f2 url(../images/white-grad.png) repeat-x scroll left top;}.button:active,.submit input:active,.button-secondary:active{background:#eee url(../images/white-grad-active.png) repeat-x scroll left top;}.form-table{border-collapse:collapse;margin-top:1em;width:100%;}.form-table td{margin-bottom:9px;padding:10px;border-bottom:8px solid #fff;font-size:12px;}.form-table th{font-size:13px;text-align:left;padding:16px 10px 10px 10px;border-bottom:8px solid #fff;width:130px;vertical-align:top;}.form-table tr{background:#f3f3f3;}.form-table code{line-height:18px;font-size:18px;}.form-table p{margin:4px 0 0 0;font-size:11px;}.form-table input{line-height:20px;font-size:15px;padding:2px;}#error-page{margin-top:50px;}#error-page p{font-size:12px;line-height:18px;margin:25px 0 20px;}#error-page code{font-family:Consolas,Monaco,Courier,monospace;}#pass-strength-result{background-color:#eee;border-color:#ddd!important;border-style:solid;border-width:1px;float:left;margin:12px 5px 5px 1px;padding:5px;text-align:center;width:200px;}#pass-strength-result.bad{background-color:#ffb78c;border-color:#ff853c!important;}#pass-strength-result.good{background-color:#ffec8b;border-color:#fc0!important;}#pass-strength-result.short{background-color:#ffa0a0;border-color:#f04040!important;}#pass-strength-result.strong{background-color:#c3ff88;border-color:#8dff1c!important;}
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkwpadmincssinstalldevcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/install.dev.css (13591 => 13592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/install.dev.css 2010-03-05 06:20:41 UTC (rev 13591)
+++ trunk/wp-admin/css/install.dev.css 2010-03-05 12:25:30 UTC (rev 13592)
</span><span class="lines">@@ -111,7 +111,7 @@
</span><span class="cx"> text-align: left;
</span><span class="cx"> padding: 16px 10px 10px 10px;
</span><span class="cx"> border-bottom: 8px solid #fff;
</span><del>- width: 110px;
</del><ins>+ width: 130px;
</ins><span class="cx"> vertical-align: top;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkwpadminincludesupgradephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/upgrade.php (13591 => 13592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/upgrade.php 2010-03-05 06:20:41 UTC (rev 13591)
+++ trunk/wp-admin/includes/upgrade.php 2010-03-05 12:25:30 UTC (rev 13592)
</span><span class="lines">@@ -62,16 +62,19 @@
</span><span class="cx"> // being shared among blogs. Just set the role in that case.
</span><span class="cx"> $user_id = username_exists($user_name);
</span><span class="cx"> $user_password = trim($user_password);
</span><ins>+ $email_password = false;
</ins><span class="cx"> if ( !$user_id && empty($user_password) ) {
</span><span class="cx"> $user_password = wp_generate_password();
</span><span class="cx"> $message = __('<strong><em>Note that password</em></strong> carefully! It is a <em>random</em> password that was generated just for you.');
</span><span class="cx"> $user_id = wp_create_user($user_name, $user_password, $user_email);
</span><span class="cx"> update_user_option($user_id, 'default_password_nag', true);
</span><ins>+ $email_password = true;
</ins><span class="cx"> } else if ( !$user_id ) {
</span><del>- $message = __('<strong><em>Note that password</em></strong> carefully!');
</del><ins>+ // Password has been provided
+ $message = __('<em>Your chosen password.</em>');
</ins><span class="cx"> $user_id = wp_create_user($user_name, $user_password, $user_email);
</span><span class="cx"> } else {
</span><del>- $message = __('User already exists. Password inherited.');
</del><ins>+ $message = __('User already exists. Password inherited.');
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $user = new WP_User($user_id);
</span><span class="lines">@@ -81,7 +84,7 @@
</span><span class="cx">
</span><span class="cx"> $wp_rewrite->flush_rules();
</span><span class="cx">
</span><del>- wp_new_blog_notification($blog_title, $guessurl, $user_id, $user_password);
</del><ins>+ wp_new_blog_notification($blog_title, $guessurl, $user_id, ($email_password ? $user_password : __('The password you chose during the install.') ) );
</ins><span class="cx">
</span><span class="cx"> wp_cache_flush();
</span><span class="cx">
</span></span></pre></div>
<a id="trunkwpadmininstallphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/install.php (13591 => 13592)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/install.php 2010-03-05 06:20:41 UTC (rev 13591)
+++ trunk/wp-admin/install.php 2010-03-05 12:25:30 UTC (rev 13592)
</span><span class="lines">@@ -100,11 +100,14 @@
</span><span class="cx"> </tr>
</span><span class="cx"> <?php if ( ! $user_table ) : ?>
</span><span class="cx"> <tr>
</span><del>- <th scope="row"><label for="admin_password"><?php _e('Password'); ?></label></th>
</del><ins>+ <th scope="row">
+ <p><label for="admin_password"><?php _e('Password'); ?></label></p>
+ <p><label for="admin_password2"><?php _e('Re-enter Password'); ?></label></p></th>
</ins><span class="cx"> <td>
</span><del>- <input name="admin_password" type="password" id="pass1" size="25" value="<?php echo esc_attr( $admin_password ); ?>" />
- <br /><?php _e('A password will be automatically generated for you if you leave this field blank.'); ?>
- <br /><div id="pass-strength-result"><?php _e('Strength indicator'); ?></div>
</del><ins>+ <p><input name="admin_password" type="password" id="pass1" size="25" value="" /></p>
+ <p><input name="admin_password2" type="password" id="pass2" size="25" value="" /></p>
+ <p><?php _e('A password will be automatically generated for you if you leave this field blank.'); ?></p>
+ <div id="pass-strength-result"><?php _e('Strength indicator'); ?></div>
</ins><span class="cx"> <p class="description indicator-hint"><?php _e('Hint: The password should be at least seven characters long. To make it stronger, use upper and lower case letters, numbers and symbols like ! " ? $ % ^ &amp; ).'); ?></p>
</span><span class="cx"> </td>
</span><span class="cx"> </tr>
</span><span class="lines">@@ -169,6 +172,7 @@
</span><span class="cx"> $weblog_title = isset( $_POST['weblog_title'] ) ? trim( stripslashes( $_POST['weblog_title'] ) ) : '';
</span><span class="cx"> $user_name = isset($_POST['user_name']) ? trim( stripslashes( $_POST['user_name'] ) ) : 'admin';
</span><span class="cx"> $admin_password = isset($_POST['admin_password']) ? trim( stripslashes( $_POST['admin_password'] ) ) : '';
</span><ins>+ $admin_password_check = isset($_POST['admin_password2']) ? trim( stripslashes( $_POST['admin_password2'] ) ) : '';
</ins><span class="cx"> $admin_email = isset( $_POST['admin_email'] ) ?trim( stripslashes( $_POST['admin_email'] ) ) : '';
</span><span class="cx"> $public = isset( $_POST['blog_public'] ) ? (int) $_POST['blog_public'] : 0;
</span><span class="cx"> // check e-mail address
</span><span class="lines">@@ -177,6 +181,10 @@
</span><span class="cx"> // TODO: poka-yoke
</span><span class="cx"> display_setup_form( __('you must provide a valid user name.') );
</span><span class="cx"> $error = true;
</span><ins>+ } elseif ( $admin_password != $admin_password_check ) {
+ // TODO: poka-yoke
+ display_setup_form( __( 'your passwords do not match. Please try again' ) );
+ $error = true;
</ins><span class="cx"> } else if ( empty( $admin_email ) ) {
</span><span class="cx"> // TODO: poka-yoke
</span><span class="cx"> display_setup_form( __( 'you must provide an e-mail address.' ) );
</span><span class="lines">@@ -205,7 +213,7 @@
</span><span class="cx"> <tr>
</span><span class="cx"> <th><?php _e( 'Password' ); ?></th>
</span><span class="cx"> <td><?php
</span><del>- if ( ! empty( $password ) )
</del><ins>+ if ( ! empty( $password ) && empty($admin_password_check) )
</ins><span class="cx"> echo '<code>'. esc_html($password) .'</code><br />';
</span><span class="cx"> echo "<p>$password_message</p>"; ?>
</span><span class="cx"> </td>
</span></span></pre>
</div>
</div>
</body>
</html>