<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[13313] trunk/wp-admin/includes/template.php: Order link categories by name
, not count, on Add/Edit Link page.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/13313">13313</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-02-22 21:59:40 +0000 (Mon, 22 Feb 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Order link categories by name, not count, on Add/Edit Link page. Fixes <a href="http://trac.wordpress.org/ticket/10399">#10399</a> props pnettle, chrisscott.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludestemplatephp">trunk/wp-admin/includes/template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludestemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/template.php (13312 => 13313)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/template.php        2010-02-22 21:26:48 UTC (rev 13312)
+++ trunk/wp-admin/includes/template.php        2010-02-22 21:59:40 UTC (rev 13313)
</span><span class="lines">@@ -415,26 +415,24 @@
</span><span class="cx">         $default = 1;
</span><span class="cx">
</span><span class="cx">         if ( $link_id ) {
</span><del>-                $checked_categories = wp_get_link_cats($link_id);
-
-                if ( count( $checked_categories ) == 0 ) {
-                        // No selected categories, strange
</del><ins>+                $checked_categories = wp_get_link_cats( $link_id );
+                // No selected categories, strange
+                if ( ! count( $checked_categories ) )
</ins><span class="cx">                         $checked_categories[] = $default;
</span><del>-                }
</del><span class="cx">         } else {
</span><span class="cx">                 $checked_categories[] = $default;
</span><span class="cx">         }
</span><span class="cx">
</span><del>-        $categories = get_terms('link_category', array('orderby' => 'count', 'hide_empty' => 0));
</del><ins>+        $categories = get_terms( 'link_category', array( 'orderby' => 'name', 'hide_empty' => 0 ) );
</ins><span class="cx">
</span><del>-        if ( empty($categories) )
</del><ins>+        if ( empty( $categories ) )
</ins><span class="cx">                 return;
</span><span class="cx">
</span><span class="cx">         foreach ( $categories as $category ) {
</span><span class="cx">                 $cat_id = $category->term_id;
</span><del>-                $name = esc_html( apply_filters('the_category', $category->name));
-                $checked = in_array( $cat_id, $checked_categories );
-                echo '<li id="link-category-', $cat_id, '"><label for="in-link-category-', $cat_id, '" class="selectit"><input value="', $cat_id, '" type="checkbox" name="link_category[]" id="in-link-category-', $cat_id, '"', ($checked ? ' checked="checked"' : "" ), '/> ', $name, "</label></li>";
</del><ins>+                $name = esc_html( apply_filters( 'the_category', $category->name ) );
+                $checked = in_array( $cat_id, $checked_categories ) ? ' checked="checked"' : '';
+                echo '<li id="link-category-', $cat_id, '"><label for="in-link-category-', $cat_id, '" class="selectit"><input value="', $cat_id, '" type="checkbox" name="link_category[]" id="in-link-category-', $cat_id, '"', $checked, '/> ', $name, "</label></li>";
</ins><span class="cx">         }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>