<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[13143] trunk/wp-includes/general-template.php: Optimize single_post_title(
), single_tag_title() & single_cat_title()
to use WP_Query globals if available.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/13143">13143</a></dd>
<dt>Author</dt> <dd>dd32</dd>
<dt>Date</dt> <dd>2010-02-14 07:38:00 +0000 (Sun, 14 Feb 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Optimize single_post_title(), single_tag_title() & single_cat_title() to use WP_Query globals if available. Removes an extra DB Query in single_post_title() in most cases.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesgeneraltemplatephp">trunk/wp-includes/general-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesgeneraltemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/general-template.php (13142 => 13143)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/general-template.php 2010-02-14 07:21:15 UTC (rev 13142)
+++ trunk/wp-includes/general-template.php 2010-02-14 07:38:00 UTC (rev 13143)
</span><span class="lines">@@ -608,21 +608,21 @@
</span><span class="cx"> * @return string|null Title when retrieving, null when displaying or failure.
</span><span class="cx"> */
</span><span class="cx"> function single_post_title($prefix = '', $display = true) {
</span><del>- global $wpdb;
- $p = get_query_var('p');
- $name = get_query_var('name');
-
- if ( intval($p) || '' != $name ) {
- if ( !$p )
- $p = $wpdb->get_var($wpdb->prepare("SELECT ID FROM $wpdb->posts WHERE post_name = %s", $name));
- $post = & get_post($p);
- $title = $post->post_title;
- $title = apply_filters('single_post_title', $title);
- if ( $display )
- echo $prefix.strip_tags($title);
- else
- return strip_tags($title);
</del><ins>+ global $wpdb, $post;
+ if ( ! $post ) {
+ $p = get_query_var('p');
+ $name = get_query_var('name');
+ if ( intval($p) || '' != $name ) {
+ if ( !$p )
+ $p = $wpdb->get_var($wpdb->prepare("SELECT ID FROM $wpdb->posts WHERE post_name = %s", $name));
+ $post = & get_post($p);
+ }
</ins><span class="cx"> }
</span><ins>+ $title = apply_filters('single_post_title', $post->post_title, $post);
+ if ( $display )
+ echo $prefix . strip_tags($title);
+ else
+ return strip_tags($title);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -643,18 +643,25 @@
</span><span class="cx"> * @return string|null Title when retrieving, null when displaying or failure.
</span><span class="cx"> */
</span><span class="cx"> function single_cat_title($prefix = '', $display = true ) {
</span><del>- $cat = intval( get_query_var('cat') );
- if ( !empty($cat) && !(strtoupper($cat) == 'ALL') ) {
- $my_cat_name = apply_filters('single_cat_title', get_the_category_by_ID($cat));
- if ( !empty($my_cat_name) ) {
- if ( $display )
- echo $prefix.strip_tags($my_cat_name);
- else
- return strip_tags($my_cat_name);
- }
- } else if ( is_tag() ) {
</del><ins>+ global $wp_query;
+ $cat = $wp_query->queried_object;
+
+ if ( is_tag() ) {
</ins><span class="cx"> return single_tag_title($prefix, $display);
</span><ins>+ } elseif ( !empty($cat->name) ) {
+ $cat = $cat->name;
+ } else {
+ $cat = intval( get_query_var('cat') );
+ if ( !empty($cat) )
+ $cat = get_the_category_by_ID($cat);
</ins><span class="cx"> }
</span><ins>+ $my_cat_name = apply_filters('single_cat_title', $cat);
+ if ( !empty($my_cat_name) ) {
+ if ( $display )
+ echo $prefix . strip_tags($my_cat_name);
+ else
+ return strip_tags($my_cat_name);
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -678,20 +685,27 @@
</span><span class="cx"> if ( !is_tag() )
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- $tag_id = intval( get_query_var('tag_id') );
</del><ins>+ global $wp_query;
+ $tag = $wp_query->queried_object;
</ins><span class="cx">
</span><del>- if ( !empty($tag_id) ) {
- $my_tag = &get_term($tag_id, 'post_tag', OBJECT, 'display');
- if ( is_wp_error( $my_tag ) )
- return false;
- $my_tag_name = apply_filters('single_tag_title', $my_tag->name);
- if ( !empty($my_tag_name) ) {
- if ( $display )
- echo $prefix . $my_tag_name;
- else
- return $my_tag_name;
</del><ins>+ if ( !empty($tag->name) ) {
+ $tag = sanitize_term($tag, 'post_tag', 'display');
+ } else {
+ $tag_id = intval( get_query_var('tag_id') );
+ if ( !empty($tag_id) ) {
+ $tag = &get_term($tag_id, 'post_tag', OBJECT, 'display');
+ if ( is_wp_error( $tag ) )
+ return false;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><ins>+
+ $my_tag_name = apply_filters('single_tag_title', $tag->name);
+ if ( !empty($my_tag_name) ) {
+ if ( $display )
+ echo $prefix . $my_tag_name;
+ else
+ return $my_tag_name;
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre>
</div>
</div>
</body>
</html>