<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[13056] trunk/wp-includes/functions.php: Don'
t query the timeout for core transients that do not have a timeout.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/13056">13056</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2010-02-11 19:43:22 +0000 (Thu, 11 Feb 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't query the timeout for core transients that do not have a timeout. Avoids useless queries on non-existent site options.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesfunctionsphp">trunk/wp-includes/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/functions.php (13055 => 13056)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/functions.php 2010-02-11 19:17:00 UTC (rev 13055)
+++ trunk/wp-includes/functions.php 2010-02-11 19:43:22 UTC (rev 13056)
</span><span class="lines">@@ -3463,13 +3463,17 @@
</span><span class="cx"> if ( $_wp_using_ext_object_cache ) {
</span><span class="cx"> $value = wp_cache_get($transient, 'site-transient');
</span><span class="cx"> } else {
</span><ins>+ // Core transients that do not have a timeout. Listed here so querying timeouts can be avoided.
+ $no_timeout = array('update_core', 'update_plugins', 'update_themes');
</ins><span class="cx"> $transient_option = '_site_transient_' . esc_sql($transient);
</span><del>- $transient_timeout = '_site_transient_timeout_' . esc_sql($transient);
- $timeout = get_site_option($transient_timeout);
- if ( false !== $timeout && $timeout < time() ) {
- delete_site_option($transient_option);
- delete_site_option($transient_timeout);
- return false;
</del><ins>+ if ( !in_array($transient, $no_timeout) ) {
+ $transient_timeout = '_site_transient_timeout_' . esc_sql($transient);
+ $timeout = get_site_option($transient_timeout);
+ if ( false !== $timeout && $timeout < time() ) {
+ delete_site_option($transient_option);
+ delete_site_option($transient_timeout);
+ return false;
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $value = get_site_option($transient_option);
</span></span></pre>
</div>
</div>
</body>
</html>