<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[13043] trunk/wp-admin:
Use switch_themes instead of edit_themes so that non super admins on multisite installs can customize headers and backgrounds
.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/13043">13043</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2010-02-10 16:49:16 +0000 (Wed, 10 Feb 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use switch_themes instead of edit_themes so that non super admins on multisite installs can customize headers and backgrounds. Add CYA cap checks.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadmincustombackgroundphp">trunk/wp-admin/custom-background.php</a></li>
<li><a href="#trunkwpadmincustomheaderphp">trunk/wp-admin/custom-header.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadmincustombackgroundphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/custom-background.php (13042 => 13043)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/custom-background.php 2010-02-10 10:59:45 UTC (rev 13042)
+++ trunk/wp-admin/custom-background.php 2010-02-10 16:49:16 UTC (rev 13043)
</span><span class="lines">@@ -52,6 +52,9 @@
</span><span class="cx"> * @since unknown
</span><span class="cx"> */
</span><span class="cx"> function init() {
</span><ins>+ if ( ! current_user_can('switch_themes') )
+ return;
+
</ins><span class="cx"> $page = add_theme_page(__('Custom Background'), __('Custom Background'), 'switch_themes', 'custom-background', array(&$this, 'admin_page'));
</span><span class="cx">
</span><span class="cx"> add_action("admin_head-$page", array(&$this, 'take_action'), 50);
</span><span class="lines">@@ -83,6 +86,9 @@
</span><span class="cx"> * @since unknown
</span><span class="cx"> */
</span><span class="cx"> function take_action() {
</span><ins>+ if ( ! current_user_can('switch_themes') )
+ return;
+
</ins><span class="cx"> if ( isset($_POST['reset-background']) ) {
</span><span class="cx"> check_admin_referer('custom-background');
</span><span class="cx"> remove_theme_mods();
</span><span class="lines">@@ -234,6 +240,8 @@
</span><span class="cx"> * @since unknown
</span><span class="cx"> */
</span><span class="cx"> function admin_page() {
</span><ins>+ if ( ! current_user_can('switch_themes') )
+ wp_die(__('You do not have permission to customize the background.'));
</ins><span class="cx"> $step = $this->step();
</span><span class="cx"> if ( 1 == $step )
</span><span class="cx"> $this->step_1();
</span></span></pre></div>
<a id="trunkwpadmincustomheaderphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/custom-header.php (13042 => 13043)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/custom-header.php 2010-02-10 10:59:45 UTC (rev 13042)
+++ trunk/wp-admin/custom-header.php 2010-02-10 16:49:16 UTC (rev 13043)
</span><span class="lines">@@ -52,8 +52,11 @@
</span><span class="cx"> * @since unknown
</span><span class="cx"> */
</span><span class="cx"> function init() {
</span><del>- $page = add_theme_page(__('Custom Header'), __('Custom Header'), 'edit_themes', 'custom-header', array(&$this, 'admin_page'));
</del><ins>+ if ( ! current_user_can('switch_themes') )
+ return;
</ins><span class="cx">
</span><ins>+ $page = add_theme_page(__('Custom Header'), __('Custom Header'), 'switch_themes', 'custom-header', array(&$this, 'admin_page'));
+
</ins><span class="cx"> add_action("admin_print_scripts-$page", array(&$this, 'js_includes'));
</span><span class="cx"> add_action("admin_print_styles-$page", array(&$this, 'css_includes'));
</span><span class="cx"> add_action("admin_head-$page", array(&$this, 'take_action'), 50);
</span><span class="lines">@@ -113,6 +116,9 @@
</span><span class="cx"> * @since unknown
</span><span class="cx"> */
</span><span class="cx"> function take_action() {
</span><ins>+ if ( ! current_user_can('switch_themes') )
+ return;
+
</ins><span class="cx"> if ( isset( $_POST['textcolor'] ) ) {
</span><span class="cx"> check_admin_referer('custom-header');
</span><span class="cx"> if ( 'blank' == $_POST['textcolor'] ) {
</span><span class="lines">@@ -483,6 +489,8 @@
</span><span class="cx"> * @since unknown
</span><span class="cx"> */
</span><span class="cx"> function admin_page() {
</span><ins>+ if ( ! current_user_can('switch_themes') )
+ wp_die(__('You do not have permission to customize headers.'));
</ins><span class="cx"> $step = $this->step();
</span><span class="cx"> if ( 1 == $step )
</span><span class="cx"> $this->step_1();
</span></span></pre>
</div>
</div>
</body>
</html>