<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[13006] trunk/wp-admin/includes/file.php:
Better error checking for ZipArchive extraction.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/13006">13006</a></dd>
<dt>Author</dt> <dd>dd32</dd>
<dt>Date</dt> <dd>2010-02-07 05:02:24 +0000 (Sun, 07 Feb 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Better error checking for ZipArchive extraction. See <a href="http://trac.wordpress.org/ticket/10403">#10403</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesfilephp">trunk/wp-admin/includes/file.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesfilephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/file.php (13005 => 13006)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/file.php 2010-02-07 04:52:35 UTC (rev 13005)
+++ trunk/wp-admin/includes/file.php 2010-02-07 05:02:24 UTC (rev 13006)
</span><span class="lines">@@ -538,12 +538,12 @@
</span><span class="cx"> global $wp_filesystem;
</span><span class="cx">
</span><span class="cx"> $z = new ZipArchive();
</span><del>- if ( ! $z->open($file) )
</del><ins>+ if ( true !== $z->open($file, ZIPARCHIVE::CHECKCONS) )
</ins><span class="cx"> return new WP_Error('incompatible_archive', __('Incompatible Archive.'));
</span><span class="cx">
</span><span class="cx"> for ( $i = 0; $i < $z->numFiles; $i++ ) {
</span><span class="cx"> if ( ! $info = $z->statIndex($i) )
</span><del>- return new WP_Error('stat_failure', __('Could not retrieve file from archive.'));
</del><ins>+ return new WP_Error('stat_failed', __('Could not retrieve file from archive.'));
</ins><span class="cx">
</span><span class="cx"> if ( '/' == substr($info['name'], -1) ) // directory
</span><span class="cx"> $needed_dirs[] = $to . untrailingslashit($info['name']);
</span><span class="lines">@@ -563,12 +563,16 @@
</span><span class="cx">
</span><span class="cx"> for ( $i = 0; $i < $z->numFiles; $i++ ) {
</span><span class="cx"> if ( ! $info = $z->statIndex($i) )
</span><del>- return new WP_Error('stat_failure', __('Could not retrieve file from archive.'));
</del><ins>+ return new WP_Error('stat_failed', __('Could not retrieve file from archive.'));
</ins><span class="cx">
</span><span class="cx"> if ( '/' == substr($info['name'], -1) ) // directory
</span><span class="cx"> continue;
</span><span class="cx">
</span><del>- if ( ! $wp_filesystem->put_contents( $to . $info['name'], $z->getFromIndex($i), FS_CHMOD_FILE) )
</del><ins>+ $contents = $z->getFromIndex($i);
+ if ( false === $contents )
+ return new WP_Error('extract_failed', __('Could not extract file from archive.'), $info['name']);
+
+ if ( ! $wp_filesystem->put_contents( $to . $info['name'], $contents, FS_CHMOD_FILE) )
</ins><span class="cx"> return new WP_Error('copy_failed', __('Could not copy file.'), $to . $file['filename']);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>