<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12877] trunk/wp-includes/post-template.php: Avoid call to setup_postdata()
.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12877">12877</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2010-01-27 17:45:49 +0000 (Wed, 27 Jan 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Avoid call to setup_postdata(). Use get_queried_object_id(). Props filosofo. fixes <a href="http://trac.wordpress.org/ticket/11439">#11439</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesposttemplatephp">trunk/wp-includes/post-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesposttemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post-template.php (12876 => 12877)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post-template.php 2010-01-27 14:44:47 UTC (rev 12876)
+++ trunk/wp-includes/post-template.php 2010-01-27 17:45:49 UTC (rev 12877)
</span><span class="lines">@@ -392,14 +392,12 @@
</span><span class="cx"> $classes[] = 'error404';
</span><span class="cx">
</span><span class="cx"> if ( is_single() ) {
</span><del>- $wp_query->post = $wp_query->posts[0];
- setup_postdata($wp_query->post);
-
- $postID = $wp_query->post->ID;
</del><ins>+ $postID = $wp_query->get_queried_object_id();
+
</ins><span class="cx"> $classes[] = 'single postid-' . $postID;
</span><span class="cx">
</span><span class="cx"> if ( is_attachment() ) {
</span><del>- $mime_type = get_post_mime_type();
</del><ins>+ $mime_type = get_post_mime_type($postID);
</ins><span class="cx"> $mime_prefix = array( 'application/', 'image/', 'text/', 'audio/', 'video/', 'music/' );
</span><span class="cx"> $classes[] = 'attachmentid-' . $postID;
</span><span class="cx"> $classes[] = 'attachment-' . str_replace($mime_prefix, '', $mime_type);
</span><span class="lines">@@ -421,19 +419,18 @@
</span><span class="cx"> } elseif ( is_page() ) {
</span><span class="cx"> $classes[] = 'page';
</span><span class="cx">
</span><del>- $wp_query->post = $wp_query->posts[0];
- setup_postdata($wp_query->post);
</del><ins>+ $pageID = $wp_query->get_queried_object_id();
</ins><span class="cx">
</span><del>- $pageID = $wp_query->post->ID;
</del><ins>+ $post = get_page($pageID);
</ins><span class="cx">
</span><span class="cx"> $classes[] = 'page-id-' . $pageID;
</span><span class="cx">
</span><del>- if ( $wpdb->get_var( $wpdb->prepare("SELECT ID FROM $wpdb->posts WHERE post_parent = %d AND post_type = 'page' LIMIT 1", $pageID) ) )
</del><ins>+ if ( $wpdb->get_var( $wpdb->prepare("SELECT ID FROM $wpdb->posts WHERE post_parent = %d AND post_type = 'page' AND post_status = 'publish' LIMIT 1", $pageID) ) )
</ins><span class="cx"> $classes[] = 'page-parent';
</span><span class="cx">
</span><del>- if ( $wp_query->post->post_parent ) {
</del><ins>+ if ( $post->post_parent ) {
</ins><span class="cx"> $classes[] = 'page-child';
</span><del>- $classes[] = 'parent-pageid-' . $wp_query->post->post_parent;
</del><ins>+ $classes[] = 'parent-pageid-' . $post->post_parent;
</ins><span class="cx"> }
</span><span class="cx"> if ( is_page_template() ) {
</span><span class="cx"> $classes[] = 'page-template';
</span></span></pre>
</div>
</div>
</body>
</html>