
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--

#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }

#msg ul, pre { overflow: auto; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<title>[12882] trunk/wp-includes/post-template.php:

  Add id arg to wp_dropdown_pages().</title>

</head>

<body>


<div id="msg">

<dl>

<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12882">12882</a></dd>

<dt>Author</dt> <dd>ryan</dd>

<dt>Date</dt> <dd>2010-01-27 21:29:07 +0000 (Wed, 27 Jan 2010)</dd>

</dl>


<h3>Log Message</h3>

<pre>Add id arg to wp_dropdown_pages(). Props jeremyclarke. fixes <a href="http://trac.wordpress.org/ticket/11433">#11433</a></pre>


<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkwpincludesposttemplatephp">trunk/wp-includes/post-template.php</a></li>

</ul>


</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkwpincludesposttemplatephp"></a>

<div class="modfile"><h4>Modified: trunk/wp-includes/post-template.php (12881 => 12882)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/wp-includes/post-template.php        2010-01-27 19:42:23 UTC (rev 12881)

+++ trunk/wp-includes/post-template.php        2010-01-27 21:29:07 UTC (rev 12882)

</span><span class="lines">@@ -691,7 +691,8 @@

</span><span class="cx">         $defaults = array(

</span><span class="cx">                 'depth' =&gt; 0, 'child_of' =&gt; 0,

</span><span class="cx">                 'selected' =&gt; 0, 'echo' =&gt; 1,

</span><del>-                'name' =&gt; 'page_id', 'show_option_none' =&gt; '', 'show_option_no_change' =&gt; '',

</del><ins>+                'name' =&gt; 'page_id', 'id' =&gt; '',

+                'show_option_none' =&gt; '', 'show_option_no_change' =&gt; '',

</ins><span class="cx">                 'option_none_value' =&gt; ''

</span><span class="cx">         );

</span><span class="cx"> 

</span><span class="lines">@@ -701,9 +702,12 @@

</span><span class="cx">         $pages = get_pages($r);

</span><span class="cx">         $output = '';

</span><span class="cx">         $name = esc_attr($name);

</span><ins>+        // Back-compat with old system where both id and name were based on $name argument

+        if ( empty($id) )

+                $id = $name;

</ins><span class="cx"> 

</span><span class="cx">         if ( ! empty($pages) ) {

</span><del>-                $output = &quot;&lt;select name=\&quot;$name\&quot; id=\&quot;$name\&quot;&gt;\n&quot;;

</del><ins>+                $output = &quot;&lt;select name=\&quot;$name\&quot; id=\&quot;$id\&quot;&gt;\n&quot;;

</ins><span class="cx">                 if ( $show_option_no_change )

</span><span class="cx">                         $output .= &quot;\t&lt;option value=\&quot;-1\&quot;&gt;$show_option_no_change&lt;/option&gt;&quot;;

</span><span class="cx">                 if ( $show_option_none )

</span></span></pre>

</div>

</div>


</body>

</html>