<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12737] branches/2.9/wp-admin/menu.php:
Ensure that inaccessible parent menus are marked as such even if they have accessible children
.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12737">12737</a></dd>
<dt>Author</dt> <dd>westi</dd>
<dt>Date</dt> <dd>2010-01-16 22:53:40 +0000 (Sat, 16 Jan 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Ensure that inaccessible parent menus are marked as such even if they have accessible children. See <a href="http://trac.wordpress.org/ticket/11922">#11922</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches29wpadminmenuphp">branches/2.9/wp-admin/menu.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches29wpadminmenuphp"></a>
<div class="modfile"><h4>Modified: branches/2.9/wp-admin/menu.php (12736 => 12737)</h4>
<pre class="diff"><span>
<span class="info">--- branches/2.9/wp-admin/menu.php 2010-01-15 23:49:09 UTC (rev 12736)
+++ branches/2.9/wp-admin/menu.php 2010-01-16 22:53:40 UTC (rev 12737)
</span><span class="lines">@@ -198,11 +198,13 @@
</span><span class="cx"> // Remove menus that have no accessible submenus and require privs that the user does not have.
</span><span class="cx"> // Run re-parent loop again.
</span><span class="cx"> foreach ( $menu as $id => $data ) {
</span><ins>+ if ( ! current_user_can($data[1]) )
+ $_wp_menu_nopriv[$data[2]] = true;
+
</ins><span class="cx"> // If submenu is empty...
</span><span class="cx"> if ( empty($submenu[$data[2]]) ) {
</span><span class="cx"> // And user doesn't have privs, remove menu.
</span><del>- if ( ! current_user_can($data[1]) ) {
- $_wp_menu_nopriv[$data[2]] = true;
</del><ins>+ if ( isset( $_wp_menu_nopriv[$data[2]] ) ) {
</ins><span class="cx"> unset($menu[$id]);
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>