<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12657] trunk:
Switch to passing arrays instead of query strings to functions.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12657">12657</a></dd>
<dt>Author</dt> <dd>westi</dd>
<dt>Date</dt> <dd>2010-01-08 08:34:39 +0000 (Fri, 08 Jan 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Switch to passing arrays instead of query strings to functions. Fixes <a href="http://trac.wordpress.org/ticket/6647">#6647</a> props filosofo and hakre.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminimportwordpressphp">trunk/wp-admin/import/wordpress.php</a></li>
<li><a href="#trunkwpadminincludesexportphp">trunk/wp-admin/includes/export.php</a></li>
<li><a href="#trunkwpadminoptionsreadingphp">trunk/wp-admin/options-reading.php</a></li>
<li><a href="#trunkwpcontentthemesclassicheaderphp">trunk/wp-content/themes/classic/header.php</a></li>
<li><a href="#trunkwpcontentthemesclassicsidebarphp">trunk/wp-content/themes/classic/sidebar.php</a></li>
<li><a href="#trunkwpcontentthemesdefaultarchivesphp">trunk/wp-content/themes/default/archives.php</a></li>
<li><a href="#trunkwpcontentthemesdefaultsidebarphp">trunk/wp-content/themes/default/sidebar.php</a></li>
<li><a href="#trunkwpincludescommenttemplatephp">trunk/wp-includes/comment-template.php</a></li>
<li><a href="#trunkwpincludesdeprecatedphp">trunk/wp-includes/deprecated.php</a></li>
<li><a href="#trunkwptrackbackphp">trunk/wp-trackback.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminimportwordpressphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/import/wordpress.php (12656 => 12657)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/import/wordpress.php 2010-01-08 08:29:55 UTC (rev 12656)
+++ trunk/wp-admin/import/wordpress.php 2010-01-08 08:34:39 UTC (rev 12657)
</span><span class="lines">@@ -360,7 +360,7 @@
</span><span class="cx"> unset( $custom_taxonomies['link_category'] );
</span><span class="cx">
</span><span class="cx"> $custom_taxonomies = array_keys( $custom_taxonomies );
</span><del>- $current_terms = (array) get_terms( $custom_taxonomies, 'get=all' );
</del><ins>+ $current_terms = (array) get_terms( $custom_taxonomies, array('get' => 'all') );
</ins><span class="cx"> $taxonomies = array();
</span><span class="cx"> foreach ( $current_terms as $term ) {
</span><span class="cx"> if ( isset( $_terms[$term->taxonomy] ) ) {
</span></span></pre></div>
<a id="trunkwpadminincludesexportphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/export.php (12656 => 12657)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/export.php 2010-01-08 08:29:55 UTC (rev 12656)
+++ trunk/wp-admin/includes/export.php 2010-01-08 08:34:39 UTC (rev 12657)
</span><span class="lines">@@ -51,7 +51,7 @@
</span><span class="cx"> unset($custom_taxonomies['post_tag']);
</span><span class="cx"> unset($custom_taxonomies['link_category']);
</span><span class="cx"> $custom_taxonomies = array_keys($custom_taxonomies);
</span><del>-$terms = (array) get_terms($custom_taxonomies, 'get=all');
</del><ins>+$terms = (array) get_terms($custom_taxonomies, array('get' => 'all'));
</ins><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * {@internal Missing Short Description}}
</span></span></pre></div>
<a id="trunkwpadminoptionsreadingphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/options-reading.php (12656 => 12657)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/options-reading.php 2010-01-08 08:29:55 UTC (rev 12656)
+++ trunk/wp-admin/options-reading.php 2010-01-08 08:34:39 UTC (rev 12657)
</span><span class="lines">@@ -41,8 +41,8 @@
</span><span class="cx"> </label>
</span><span class="cx"> </p>
</span><span class="cx"> <ul>
</span><del>- <li><?php printf("<label for='page_on_front'>".__('Front page: %s')."</label>", wp_dropdown_pages("name=page_on_front&echo=0&show_option_none=".__('- Select -')."&selected=" . get_option('page_on_front'))); ?></li>
- <li><?php printf("<label for='page_for_posts'>".__('Posts page: %s')."</label>", wp_dropdown_pages("name=page_for_posts&echo=0&show_option_none=".__('- Select -')."&selected=" . get_option('page_for_posts'))); ?></li>
</del><ins>+ <li><?php printf("<label for='page_on_front'>" . __('Front page: %s') . "</label>", wp_dropdown_pages( array( 'name' => 'page_on_front', 'echo' => 0, 'show_option_none' => __('- Select -'), 'selected' => get_option('page_on_front') ) ) ); ?></li>
+ <li><?php printf("<label for='page_for_posts'>". __('Posts page: %s') . "</label>", wp_dropdown_pages( array( 'name' => 'page_for_posts','echo' => 0, 'show_option_none' => __('- Select -'), 'selected' => get_option('page_for_posts') ) ) ); ?></li>
</ins><span class="cx"> </ul>
</span><span class="cx"> <?php if ( 'page' == get_option('show_on_front') && get_option('page_for_posts') == get_option('page_on_front') ) : ?>
</span><span class="cx"> <div id="front-page-warning" class="updated">
</span></span></pre></div>
<a id="trunkwpcontentthemesclassicheaderphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/classic/header.php (12656 => 12657)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/classic/header.php 2010-01-08 08:29:55 UTC (rev 12656)
+++ trunk/wp-content/themes/classic/header.php 2010-01-08 08:34:39 UTC (rev 12657)
</span><span class="lines">@@ -17,7 +17,7 @@
</span><span class="cx"> </style>
</span><span class="cx">
</span><span class="cx"> <link rel="pingback" href="<?php bloginfo('pingback_url'); ?>" />
</span><del>- <?php wp_get_archives('type=monthly&format=link'); ?>
</del><ins>+ <?php wp_get_archives(array('type' => 'monthly', 'format' => 'link')); ?>
</ins><span class="cx"> <?php //comments_popup_script(); // off by default ?>
</span><span class="cx"> <?php wp_head(); ?>
</span><span class="cx"> </head>
</span></span></pre></div>
<a id="trunkwpcontentthemesclassicsidebarphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/classic/sidebar.php (12656 => 12657)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/classic/sidebar.php 2010-01-08 08:29:55 UTC (rev 12656)
+++ trunk/wp-content/themes/classic/sidebar.php 2010-01-08 08:34:39 UTC (rev 12657)
</span><span class="lines">@@ -24,7 +24,7 @@
</span><span class="cx"> </li>
</span><span class="cx"> <li id="archives"><?php _e('Archives:'); ?>
</span><span class="cx"> <ul>
</span><del>- <?php wp_get_archives('type=monthly'); ?>
</del><ins>+ <?php wp_get_archives(array('type' => 'monthly')); ?>
</ins><span class="cx"> </ul>
</span><span class="cx"> </li>
</span><span class="cx"> <li id="meta"><?php _e('Meta:'); ?>
</span></span></pre></div>
<a id="trunkwpcontentthemesdefaultarchivesphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/default/archives.php (12656 => 12657)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/default/archives.php 2010-01-08 08:29:55 UTC (rev 12656)
+++ trunk/wp-content/themes/default/archives.php 2010-01-08 08:34:39 UTC (rev 12657)
</span><span class="lines">@@ -16,7 +16,7 @@
</span><span class="cx">
</span><span class="cx"> <h2>Archives by Month:</h2>
</span><span class="cx"> <ul>
</span><del>- <?php wp_get_archives('type=monthly'); ?>
</del><ins>+ <?php wp_get_archives(array('type' => 'monthly')); ?>
</ins><span class="cx"> </ul>
</span><span class="cx">
</span><span class="cx"> <h2>Archives by Subject:</h2>
</span></span></pre></div>
<a id="trunkwpcontentthemesdefaultsidebarphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/default/sidebar.php (12656 => 12657)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/default/sidebar.php 2010-01-08 08:29:55 UTC (rev 12656)
+++ trunk/wp-content/themes/default/sidebar.php 2010-01-08 08:34:39 UTC (rev 12657)
</span><span class="lines">@@ -55,11 +55,11 @@
</span><span class="cx">
</span><span class="cx"> <li><h2>Archives</h2>
</span><span class="cx"> <ul>
</span><del>- <?php wp_get_archives('type=monthly'); ?>
</del><ins>+ <?php wp_get_archives(array('type' => 'monthly')); ?>
</ins><span class="cx"> </ul>
</span><span class="cx"> </li>
</span><span class="cx">
</span><del>- <?php wp_list_categories('show_count=1&title_li=<h2>Categories</h2>'); ?>
</del><ins>+ <?php wp_list_categories(array('show_count' => 1, 'title_li' => '<h2>Categories</h2>')); ?>
</ins><span class="cx"> </ul>
</span><span class="cx"> <ul>
</span><span class="cx"> <?php /* If this is the frontpage */ if ( is_home() || is_page() ) { ?>
</span></span></pre></div>
<a id="trunkwpincludescommenttemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/comment-template.php (12656 => 12657)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/comment-template.php 2010-01-08 08:29:55 UTC (rev 12656)
+++ trunk/wp-includes/comment-template.php 2010-01-08 08:34:39 UTC (rev 12657)
</span><span class="lines">@@ -983,7 +983,7 @@
</span><span class="cx"> if ( !empty( $css_class ) ) {
</span><span class="cx"> echo ' class="'.$css_class.'" ';
</span><span class="cx"> }
</span><del>- $title = the_title_attribute( 'echo=0' );
</del><ins>+ $title = the_title_attribute( array('echo' => 0 ) );
</ins><span class="cx">
</span><span class="cx"> echo apply_filters( 'comments_popup_link_attributes', '' );
</span><span class="cx">
</span></span></pre></div>
<a id="trunkwpincludesdeprecatedphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/deprecated.php (12656 => 12657)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/deprecated.php 2010-01-08 08:29:55 UTC (rev 12656)
+++ trunk/wp-includes/deprecated.php 2010-01-08 08:34:39 UTC (rev 12657)
</span><span class="lines">@@ -592,7 +592,7 @@
</span><span class="cx"> function get_linkobjects($category = 0, $orderby = 'name', $limit = 0) {
</span><span class="cx"> _deprecated_function( __FUNCTION__, '2.1', 'get_bookmarks()' );
</span><span class="cx">
</span><del>- $links = get_bookmarks("category=$category&orderby=$orderby&limit=$limit");
</del><ins>+ $links = get_bookmarks( array( 'category' => $category, 'orderby' => $orderby, 'limit' => $limit ) ) ;
</ins><span class="cx">
</span><span class="cx"> $links_array = array();
</span><span class="cx"> foreach ($links as $link)
</span></span></pre></div>
<a id="trunkwptrackbackphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-trackback.php (12656 => 12657)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-trackback.php 2010-01-08 08:29:55 UTC (rev 12656)
+++ trunk/wp-trackback.php 2010-01-08 08:34:39 UTC (rev 12657)
</span><span class="lines">@@ -7,7 +7,7 @@
</span><span class="cx">
</span><span class="cx"> if (empty($wp)) {
</span><span class="cx"> require_once('./wp-load.php');
</span><del>- wp('tb=1');
</del><ins>+ wp( array( 'tb' => '1' ) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre>
</div>
</div>
</body>
</html>