<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12563] branches/2.9/wp-includes/meta.php: Use umeta_id for user meta.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12563">12563</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2009-12-28 16:43:13 +0000 (Mon, 28 Dec 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use umeta_id for user meta. Props wnorris. fixes <a href="http://trac.wordpress.org/ticket/11627">#11627</a> for 2.9</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches29wpincludesmetaphp">branches/2.9/wp-includes/meta.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches29wpincludesmetaphp"></a>
<div class="modfile"><h4>Modified: branches/2.9/wp-includes/meta.php (12562 => 12563)</h4>
<pre class="diff"><span>
<span class="info">--- branches/2.9/wp-includes/meta.php 2009-12-28 16:42:31 UTC (rev 12562)
+++ branches/2.9/wp-includes/meta.php 2009-12-28 16:43:13 UTC (rev 12563)
</span><span class="lines">@@ -53,11 +53,12 @@
</span><span class="cx"> global $wpdb;
</span><span class="cx">
</span><span class="cx"> $column = esc_sql($meta_type . '_id');
</span><ins>+ $id_column = 'user' == $meta_type ? 'umeta_id' : 'meta_id';
</ins><span class="cx">
</span><span class="cx"> // expected_slashed ($meta_key)
</span><span class="cx"> $meta_key = stripslashes($meta_key);
</span><span class="cx">
</span><del>- if ( ! $meta_id = $wpdb->get_var( $wpdb->prepare( "SELECT meta_id FROM $table WHERE meta_key = %s AND $column = %d", $meta_key, $object_id ) ) )
</del><ins>+ if ( ! $meta_id = $wpdb->get_var( $wpdb->prepare( "SELECT $id_column FROM $table WHERE meta_key = %s AND $column = %d", $meta_key, $object_id ) ) )
</ins><span class="cx"> return add_metadata($meta_type, $object_id, $meta_key, $meta_value);
</span><span class="cx">
</span><span class="cx"> $meta_value = maybe_serialize( stripslashes_deep($meta_value) );
</span><span class="lines">@@ -90,11 +91,12 @@
</span><span class="cx"> global $wpdb;
</span><span class="cx">
</span><span class="cx"> $type_column = esc_sql($meta_type . '_id');
</span><ins>+ $id_column = 'user' == $meta_type ? 'umeta_id' : 'meta_id';
</ins><span class="cx"> // expected_slashed ($meta_key)
</span><span class="cx"> $meta_key = stripslashes($meta_key);
</span><span class="cx"> $meta_value = maybe_serialize( stripslashes_deep($meta_value) );
</span><span class="cx">
</span><del>- $query = $wpdb->prepare( "SELECT meta_id FROM $table WHERE meta_key = %s", $meta_key );
</del><ins>+ $query = $wpdb->prepare( "SELECT $id_column FROM $table WHERE meta_key = %s", $meta_key );
</ins><span class="cx">
</span><span class="cx"> if ( !$delete_all )
</span><span class="cx"> $query .= $wpdb->prepare(" AND $type_column = %d", $object_id );
</span><span class="lines">@@ -106,7 +108,7 @@
</span><span class="cx"> if ( !count( $meta_ids ) )
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- $query = "DELETE FROM $table WHERE meta_id IN( " . implode( ',', $meta_ids ) . " )";
</del><ins>+ $query = "DELETE FROM $table WHERE $id_column IN( " . implode( ',', $meta_ids ) . " )";
</ins><span class="cx">
</span><span class="cx"> $count = $wpdb->query($query);
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>