<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12437] branches/2.9/wp-admin/update-core.php:
Give feedback when Upgrade Plugins is clicked but no plugins are selected.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12437">12437</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2009-12-17 20:19:43 +0000 (Thu, 17 Dec 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Give feedback when Upgrade Plugins is clicked but no plugins are selected. see <a href="http://trac.wordpress.org/ticket/10973">#10973</a> for 2.9</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches29wpadminupdatecorephp">branches/2.9/wp-admin/update-core.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches29wpadminupdatecorephp"></a>
<div class="modfile"><h4>Modified: branches/2.9/wp-admin/update-core.php (12436 => 12437)</h4>
<pre class="diff"><span>
<span class="info">--- branches/2.9/wp-admin/update-core.php 2009-12-17 20:18:12 UTC (rev 12436)
+++ branches/2.9/wp-admin/update-core.php 2009-12-17 20:19:43 UTC (rev 12437)
</span><span class="lines">@@ -95,12 +95,20 @@
</span><span class="cx"> * @return null
</span><span class="cx"> */
</span><span class="cx"> function core_upgrade_preamble() {
</span><ins>+ global $upgrade_error;
+
</ins><span class="cx"> $updates = get_core_updates();
</span><span class="cx"> ?>
</span><span class="cx"> <div class="wrap">
</span><span class="cx"> <?php screen_icon(); ?>
</span><span class="cx"> <h2><?php _e('Upgrade WordPress'); ?></h2>
</span><span class="cx"> <?php
</span><ins>+ if ( $upgrade_error ) {
+ echo '<div class="error"><p>';
+ _e('Please select one or more plugins to upgrade.');
+ echo '</p></div>';
+ }
+
</ins><span class="cx"> if ( !isset($updates[0]->response) || 'latest' == $updates[0]->response ) {
</span><span class="cx"> echo '<h3>';
</span><span class="cx"> _e('You have the latest version of WordPress. You do not need to upgrade');
</span><span class="lines">@@ -331,8 +339,11 @@
</span><span class="cx">
</span><span class="cx"> if ( isset($_GET['plugins']) ) {
</span><span class="cx"> $plugins = explode(',', $_GET['plugins']);
</span><ins>+ } elseif ( isset($_POST['checked']) ) {
+ $plugins = (array) $_POST['checked'];
</ins><span class="cx"> } else {
</span><del>- $plugins = (array) $_POST['checked'];
</del><ins>+ // Nothing to do.
+ return;
</ins><span class="cx"> }
</span><span class="cx"> $url = 'update-core.php?action=do-plugin-upgrade&amp;plugins=' . urlencode(join(',', $plugins));
</span><span class="cx"> $title = __('Upgrade Plugins');
</span><span class="lines">@@ -343,6 +354,12 @@
</span><span class="cx">
</span><span class="cx"> $action = isset($_GET['action']) ? $_GET['action'] : 'upgrade-core';
</span><span class="cx">
</span><ins>+$upgrade_error = false;
+if ( 'do-plugin-upgrade' == $action && !isset($_GET['plugins']) && !isset($_POST['checked']) ) {
+ $upgrade_error = true;
+ $action = 'upgrade-core';
+}
+
</ins><span class="cx"> $title = __('Upgrade WordPress');
</span><span class="cx"> $parent_file = 'tools.php';
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>