<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12387] trunk/wp-admin/includes/class-ftp.php:
Fix the IP Address validation code in the FTP class.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12387">12387</a></dd>
<dt>Author</dt> <dd>westi</dd>
<dt>Date</dt> <dd>2009-12-13 00:02:01 +0000 (Sun, 13 Dec 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix the IP Address validation code in the FTP class. Fixes <a href="http://trac.wordpress.org/ticket/11393">#11393</a> props nacin.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesclassftpphp">trunk/wp-admin/includes/class-ftp.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesclassftpphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-ftp.php (12386 => 12387)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-ftp.php 2009-12-12 22:28:48 UTC (rev 12386)
+++ trunk/wp-admin/includes/class-ftp.php 2009-12-13 00:02:01 UTC (rev 12387)
</span><span class="lines">@@ -278,7 +278,10 @@
</span><span class="cx"> $dns=@gethostbyaddr($host);
</span><span class="cx"> if(!$ip) $ip=$host;
</span><span class="cx"> if(!$dns) $dns=$host;
</span><del>- if(ip2long($ip) === -1) {
</del><ins>+ // Validate the IPAddress PHP4 returns -1 for invalid, PHP5 false
+ // -1 === "255.255.255.255" which is the broadcast address which is also going to be invalid
+ $ipaslong = ip2long($ip);
+ if ( ($ipaslong == false) || ($ipaslong === -1) ) {
</ins><span class="cx"> $this->SendMSG("Wrong host name/address \"".$host."\"");
</span><span class="cx"> return FALSE;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>