<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12355] trunk: Provide visual feedback for "Use as thumbnail"
when clicked immediately after uploading the image.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12355">12355</a></dd>
<dt>Author</dt> <dd>markjaquith</dd>
<dt>Date</dt> <dd>2009-12-10 08:03:26 +0000 (Thu, 10 Dec 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Provide visual feedback for "Use as thumbnail" when clicked immediately after uploading the image. fixes <a href="http://trac.wordpress.org/ticket/11140">#11140</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesmediaphp">trunk/wp-admin/includes/media.php</a></li>
<li><a href="#trunkwpadminjssetpostthumbnaildevjs">trunk/wp-admin/js/set-post-thumbnail.dev.js</a></li>
<li><a href="#trunkwpadminjssetpostthumbnailjs">trunk/wp-admin/js/set-post-thumbnail.js</a></li>
<li><a href="#trunkwpincludesscriptloaderphp">trunk/wp-includes/script-loader.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesmediaphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/media.php (12354 => 12355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/media.php 2009-12-10 07:37:41 UTC (rev 12354)
+++ trunk/wp-admin/includes/media.php 2009-12-10 08:03:26 UTC (rev 12355)
</span><span class="lines">@@ -1245,7 +1245,7 @@
</span><span class="cx"> elseif ( isset( $_POST ) && count( $_POST ) ) // Like for async-upload where $_GET['post_id'] isn't set
</span><span class="cx"> $calling_post_id = $post->post_parent;
</span><span class="cx"> if ( 'image' == $type && $calling_post_id && current_theme_supports( 'post-thumbnails', get_post_type( $calling_post_id ) ) && get_post_thumbnail_id( $calling_post_id ) != $attachment_id )
</span><del>- $thumbnail = "<a class='wp-post-thumbnail' href='#' onclick='WPSetAsThumbnail(\"$attachment_id\");return false;'>" . esc_html__( "Use as thumbnail" ) . "</a>";
</del><ins>+ $thumbnail = "<a class='wp-post-thumbnail' id='wp-post-thumbnail-" . $attachment_id . "' href='#' onclick='WPSetAsThumbnail(\"$attachment_id\");return false;'>" . esc_html__( "Use as thumbnail" ) . "</a>";
</ins><span class="cx">
</span><span class="cx"> if ( ( $send || $thumbnail || $delete ) && !isset($form_fields['buttons']) )
</span><span class="cx"> $form_fields['buttons'] = array('tr' => "\t\t<tr class='submit'><td></td><td class='savesend'>$send $thumbnail $delete</td></tr>\n");
</span></span></pre></div>
<a id="trunkwpadminjssetpostthumbnaildevjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/set-post-thumbnail.dev.js (12354 => 12355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/set-post-thumbnail.dev.js 2009-12-10 07:37:41 UTC (rev 12354)
+++ trunk/wp-admin/js/set-post-thumbnail.dev.js 2009-12-10 08:03:26 UTC (rev 12355)
</span><span class="lines">@@ -1,5 +1,5 @@
</span><span class="cx"> function WPSetAsThumbnail(id){
</span><del>- var $link = jQuery('#media-item-' + id + ' a.wp-post-thumbnail');
</del><ins>+ var $link = jQuery('a#wp-post-thumbnail-' + id);
</ins><span class="cx">
</span><span class="cx"> $link.text( setPostThumbnailL10n.saving );
</span><span class="cx"> jQuery.post(ajaxurl, {
</span></span></pre></div>
<a id="trunkwpadminjssetpostthumbnailjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/set-post-thumbnail.js (12354 => 12355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/set-post-thumbnail.js 2009-12-10 07:37:41 UTC (rev 12354)
+++ trunk/wp-admin/js/set-post-thumbnail.js 2009-12-10 08:03:26 UTC (rev 12355)
</span><span class="lines">@@ -1 +1 @@
</span><del>-function WPSetAsThumbnail(id){var $link=jQuery("#media-item-"+id+" a.wp-post-thumbnail");$link.text(setPostThumbnailL10n.saving);jQuery.post(ajaxurl,{action:"set-post-thumbnail",post_id:post_id,thumbnail_id:id,cookie:encodeURIComponent(document.cookie)},function(str){var win=window.dialogArguments||opener||parent||top;$link.text(setPostThumbnailL10n.setThumbnail);if(str=="0"){alert(setPostThumbnailL10n.error)}else{jQuery("a.wp-post-thumbnail").show();$link.text(setPostThumbnailL10n.done);$link.fadeOut(2000);win.WPSetThumbnailID(id);win.WPSetThumbnailHTML(str)}})};
</del><span class="cx">\ No newline at end of file
</span><ins>+function WPSetAsThumbnail(id){var $link=jQuery("a#wp-post-thumbnail-"+id);$link.text(setPostThumbnailL10n.saving);jQuery.post(ajaxurl,{action:"set-post-thumbnail",post_id:post_id,thumbnail_id:id,cookie:encodeURIComponent(document.cookie)},function(str){var win=window.dialogArguments||opener||parent||top;$link.text(setPostThumbnailL10n.setThumbnail);if(str=="0"){alert(setPostThumbnailL10n.error)}else{jQuery("a.wp-post-thumbnail").show();$link.text(setPostThumbnailL10n.done);$link.fadeOut(2000);win.WPSetThumbnailID(id);win.WPSetThumbnailHTML(str)}})};
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkwpincludesscriptloaderphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/script-loader.php (12354 => 12355)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/script-loader.php 2009-12-10 07:37:41 UTC (rev 12354)
+++ trunk/wp-includes/script-loader.php 2009-12-10 08:03:26 UTC (rev 12355)
</span><span class="lines">@@ -382,7 +382,7 @@
</span><span class="cx"> $scripts->add( 'image-edit', "/wp-admin/js/image-edit$suffix.js", array('jquery', 'json2', 'imgareaselect'), '20091111' );
</span><span class="cx"> $scripts->add_data( 'image-edit', 'group', 1 );
</span><span class="cx">
</span><del>- $scripts->add( 'set-post-thumbnail', "/wp-admin/js/set-post-thumbnail$suffix.js", array( 'jquery' ), '20091210' );
</del><ins>+ $scripts->add( 'set-post-thumbnail', "/wp-admin/js/set-post-thumbnail$suffix.js", array( 'jquery' ), '20091210b' );
</ins><span class="cx"> $scripts->add_data( 'set-post-thumbnail', 'group', 1 );
</span><span class="cx"> $scripts->localize( 'set-post-thumbnail', 'setPostThumbnailL10n', array(
</span><span class="cx"> 'setThumbnail' => __( 'Use as thumbnail' ),
</span></span></pre>
</div>
</div>
</body>
</html>