<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12295] trunk/wp-admin/includes/media.php: escape hrefs.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12295">12295</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2009-11-30 16:55:50 +0000 (Mon, 30 Nov 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>escape hrefs. Props Denis-de-Bernardy. fixes <a href="http://trac.wordpress.org/ticket/10056">#10056</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesmediaphp">trunk/wp-admin/includes/media.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesmediaphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/media.php (12294 => 12295)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/media.php 2009-11-30 01:53:25 UTC (rev 12294)
+++ trunk/wp-admin/includes/media.php 2009-11-30 16:55:50 UTC (rev 12295)
</span><span class="lines">@@ -486,7 +486,7 @@
</span><span class="cx"> $src = $_POST['insertonly']['embed-src'];
</span><span class="cx"> if ( !strpos($src, '://') )
</span><span class="cx"> $src = "http://$src";
</span><del>- $html = '[embed]' . $src . '[/embed]';
</del><ins>+ $html = '[embed]' . esc_url($src) . '[/embed]';
</ins><span class="cx"> } else {
</span><span class="cx"> $src = $_POST['insertonly']['src'];
</span><span class="cx"> if ( !empty($src) && !strpos($src, '://') )
</span><span class="lines">@@ -497,10 +497,10 @@
</span><span class="cx"> $class = " class='align$align'";
</span><span class="cx"> }
</span><span class="cx"> if ( !empty($src) )
</span><del>- $html = "<img src='$src' alt='$alt'$class />";
</del><ins>+ $html = "<img src='" . esc_url($src) . "' alt='$alt'$class />";
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- $html = apply_filters('image_send_to_editor_url', $html, $src, $alt, $align);
</del><ins>+ $html = apply_filters('image_send_to_editor_url', $html, esc_url_raw($src), $alt, $align);
</ins><span class="cx"> return media_send_to_editor($html);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -596,8 +596,8 @@
</span><span class="cx"> if ( !empty($href) && !strpos($href, '://') )
</span><span class="cx"> $href = "http://$href";
</span><span class="cx">
</span><del>- $html = '[embed]' . $href . '[/embed]';
- $html = apply_filters('audio_send_to_editor_url', $html, $href);
</del><ins>+ $html = '[embed]' . esc_url($href) . '[/embed]';
+ $html = apply_filters('audio_send_to_editor_url', $html, esc_url_raw($href));
</ins><span class="cx"> return media_send_to_editor($html);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -647,8 +647,8 @@
</span><span class="cx"> if ( !empty($href) && !strpos($href, '://') )
</span><span class="cx"> $href = "http://$href";
</span><span class="cx">
</span><del>- $html = '[embed]' . $href . '[/embed]';
- $html = apply_filters('video_send_to_editor_url', $html, $href);
</del><ins>+ $html = '[embed]' . esc_url($href) . '[/embed]';
+ $html = apply_filters('video_send_to_editor_url', $html, esc_url_raw($href));
</ins><span class="cx"> return media_send_to_editor($html);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -702,8 +702,8 @@
</span><span class="cx"> if ( empty($title) )
</span><span class="cx"> $title = basename($href);
</span><span class="cx"> if ( !empty($title) && !empty($href) )
</span><del>- $html = "<a href='$href' >$title</a>";
- $html = apply_filters('file_send_to_editor_url', $html, $href, $title);
</del><ins>+ $html = "<a href='" . esc_url($href) . "' >$title</a>";
+ $html = apply_filters('file_send_to_editor_url', $html, esc_url_raw($href), $title);
</ins><span class="cx"> return media_send_to_editor($html);
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>