<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12263] trunk/wp-includes/class-IXR.php:
Reduce memory usage for XML-RPC requests.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12263">12263</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2009-11-23 16:53:36 +0000 (Mon, 23 Nov 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Reduce memory usage for XML-RPC requests. Props Demitrious Kelly. fixes <a href="http://trac.wordpress.org/ticket/10698">#10698</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesclassIXRphp">trunk/wp-includes/class-IXR.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesclassIXRphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/class-IXR.php (12262 => 12263)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/class-IXR.php 2009-11-23 16:10:06 UTC (rev 12262)
+++ trunk/wp-includes/class-IXR.php 2009-11-23 16:53:36 UTC (rev 12263)
</span><span class="lines">@@ -153,34 +153,41 @@
</span><span class="cx"> var $_currentTagContents;
</span><span class="cx"> // The XML parser
</span><span class="cx"> var $_parser;
</span><del>- function IXR_Message ($message) {
- $this->message = $message;
</del><ins>+ function IXR_Message (&$message) {
+ $this->message = &$message;
</ins><span class="cx"> }
</span><span class="cx"> function parse() {
</span><del>- // first remove the XML declaration
- $this->message = preg_replace('/<\?xml.*?\?'.'>/', '', $this->message);
</del><ins>+ // first remove the XML declaration
+ // this method avoids the RAM usage of preg_replace on very large messages
+ $header = preg_replace( '/<\?xml.*?\?'.'>/', '', substr( $this->message, 0, 100 ), 1 );
+ $this->message = substr_replace($this->message, $header, 0, 100);
</ins><span class="cx"> if (trim($this->message) == '') {
</span><span class="cx"> return false;
</span><del>- }
</del><ins>+ }
</ins><span class="cx"> $this->_parser = xml_parser_create();
</span><span class="cx"> // Set XML parser to take the case of tags in to account
</span><span class="cx"> xml_parser_set_option($this->_parser, XML_OPTION_CASE_FOLDING, false);
</span><span class="cx"> // Set XML parser callback functions
</span><span class="cx"> xml_set_object($this->_parser, $this);
</span><span class="cx"> xml_set_element_handler($this->_parser, 'tag_open', 'tag_close');
</span><del>- xml_set_character_data_handler($this->_parser, 'cdata');
- if (!xml_parse($this->_parser, $this->message)) {
- /* die(sprintf('XML error: %s at line %d',
- xml_error_string(xml_get_error_code($this->_parser)),
- xml_get_current_line_number($this->_parser))); */
- return false;
- }
- xml_parser_free($this->_parser);
</del><ins>+ xml_set_character_data_handler($this->_parser, 'cdata');
+ $chunk_size = 262144; // 256Kb, parse in chunks to avoid the RAM usage on very large messages
+ do {
+ if ( strlen($this->message) <= $chunk_size )
+ $final=true;
+ $part = substr( $this->message, 0, $chunk_size );
+ $this->message = substr( $this->message, $chunk_size );
+ if ( !xml_parse( $this->_parser, $part, $final ) )
+ return false;
+ if ( $final )
+ break;
+ } while ( true );
+ xml_parser_free($this->_parser);
</ins><span class="cx"> // Grab the error messages, if any
</span><span class="cx"> if ($this->messageType == 'fault') {
</span><span class="cx"> $this->faultCode = $this->params[0]['faultCode'];
</span><span class="cx"> $this->faultString = $this->params[0]['faultString'];
</span><del>- }
</del><ins>+ }
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx"> function tag_open($parser, $tag, $attr) {
</span><span class="lines">@@ -304,7 +311,7 @@
</span><span class="cx"> header( 'Content-Type: text/plain' );
</span><span class="cx"> die('XML-RPC server accepts POST requests only.');
</span><span class="cx"> }
</span><del>- $data = $HTTP_RAW_POST_DATA;
</del><ins>+ $data = &$HTTP_RAW_POST_DATA;
</ins><span class="cx"> }
</span><span class="cx"> $this->message = new IXR_Message($data);
</span><span class="cx"> if (!$this->message->parse()) {
</span></span></pre>
</div>
</div>
</body>
</html>