<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12198] trunk/wp-admin/includes/post.php:
Use preg_replace_callback to eliminate eval.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12198">12198</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2009-11-17 19:25:01 +0000 (Tue, 17 Nov 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use preg_replace_callback to eliminate eval. Props BenBE1987. fixes <a href="http://trac.wordpress.org/ticket/10896">#10896</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludespostphp">trunk/wp-admin/includes/post.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/post.php (12197 => 12198)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/post.php 2009-11-17 16:27:36 UTC (rev 12197)
+++ trunk/wp-admin/includes/post.php 2009-11-17 19:25:01 UTC (rev 12198)
</span><span class="lines">@@ -713,6 +713,7 @@
</span><span class="cx"> * @return unknown
</span><span class="cx"> */
</span><span class="cx"> function _fix_attachment_links( $post_ID ) {
</span><ins>+ global $_fix_attachment_link_id;
</ins><span class="cx">
</span><span class="cx"> $post = & get_post( $post_ID, ARRAY_A );
</span><span class="cx">
</span><span class="lines">@@ -740,7 +741,8 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $post_search[$i] = $anchor;
</span><del>- $post_replace[$i] = preg_replace( "#href=(\"|')[^'\"]*\\1#e", "stripslashes( 'href=\\1' ).get_attachment_link( $id ).stripslashes( '\\1' )", $anchor );
</del><ins>+ $_fix_attachment_link_id = $id;
+ $post_replace[$i] = preg_replace_callback( "#href=(\"|')[^'\"]*\\1#", '_fix_attachment_links_replace_cb', $anchor );
</ins><span class="cx"> ++$i;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -752,6 +754,11 @@
</span><span class="cx"> return wp_update_post( $post);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+function _fix_attachment_links_replace_cb($match) {
+ global $_fix_attachment_link_id;
+ return stripslashes( 'href='.$m[1] ).get_attachment_link( $_fix_attachment_link_id ).stripslashes( $m[1] );
+}
+
</ins><span class="cx"> /**
</span><span class="cx"> * Move child posts to a new parent.
</span><span class="cx"> *
</span></span></pre>
</div>
</div>
</body>
</html>