<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12141] trunk/wp-includes/post.php:
Fix comment and postmeta delete queries when deleting a post.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12141">12141</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2009-11-04 17:39:53 +0000 (Wed, 04 Nov 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix comment and postmeta delete queries when deleting a post. see <a href="http://trac.wordpress.org/ticket/11073">#11073</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludespostphp">trunk/wp-includes/post.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post.php (12140 => 12141)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post.php 2009-11-04 15:52:23 UTC (rev 12140)
+++ trunk/wp-includes/post.php 2009-11-04 17:39:53 UTC (rev 12141)
</span><span class="lines">@@ -1202,15 +1202,21 @@
</span><span class="cx"> // Point all attachments to this post up one level
</span><span class="cx"> $wpdb->update( $wpdb->posts, $parent_data, $parent_where + array( 'post_type' => 'attachment' ) );
</span><span class="cx">
</span><del>- $commentids = $wpdb->get_col( $wpdb->prepare( "SELECT comment_ID FROM $wpdb->comments WHERE comment_post_ID = %d", $postid ));
- do_action( 'delete_comment', $commentids );
- $wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->comments WHERE comment_ID IN(%s)", implode( ',', $commentids ) ));
- do_action( 'deleted_comment', $commentids );
</del><ins>+ $comment_ids = $wpdb->get_col( $wpdb->prepare( "SELECT comment_ID FROM $wpdb->comments WHERE comment_post_ID = %d", $postid ));
+ if ( ! empty($comment_ids) ) {
+ do_action( 'delete_comment', $comment_ids );
+ $in_comment_ids = "'" . implode("', '", $comment_ids) . "'";
+ $wpdb->query( "DELETE FROM $wpdb->comments WHERE comment_ID IN($in_comment_ids)" );
+ do_action( 'deleted_comment', $comment_ids );
+ }
</ins><span class="cx">
</span><del>- $postmetaids = $wpdb->get_col( $wpdb->prepare( "SELECT meta_id FROM $wpdb->postmeta WHERE post_id = %d ", $post_id ));
- do_action( 'delete_postmeta', $postmetaids );
- $wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->postmeta WHERE meta_id IN(%s)", implode( ',', $postmetaids ) ));
- do_action( 'deleted_postmeta', $postmetaids );
</del><ins>+ $post_meta_ids = $wpdb->get_col( $wpdb->prepare( "SELECT meta_id FROM $wpdb->postmeta WHERE post_id = %d ", $postid ));
+ if ( !empty($post_meta_ids) ) {
+ do_action( 'delete_postmeta', $post_meta_ids );
+ $in_post_meta_ids = "'" . implode("', '", $post_meta_ids) . "'";
+ $wpdb->query( "DELETE FROM $wpdb->postmeta WHERE meta_id IN($in_post_meta_ids)" );
+ do_action( 'deleted_postmeta', $post_meta_ids );
+ }
</ins><span class="cx">
</span><span class="cx"> do_action( 'delete_post', $post_id );
</span><span class="cx"> $wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->posts WHERE ID = %d", $postid ));
</span><span class="lines">@@ -2729,15 +2735,21 @@
</span><span class="cx">
</span><span class="cx"> $wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->postmeta WHERE meta_key = '_thumbnail_id' AND meta_value = %d", $post_id ));
</span><span class="cx">
</span><del>- $commentids = $wpdb->get_col( $wpdb->prepare( "SELECT comment_ID FROM $wpdb->comments WHERE comment_post_ID = %d", $post_id ));
- do_action( 'delete_comment', $commentids );
- $wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->comments WHERE comment_ID IN(%s)", implode( ',', $commentids ) ));
- do_action( 'deleted_comment', $commentids );
</del><ins>+ $comment_ids = $wpdb->get_col( $wpdb->prepare( "SELECT comment_ID FROM $wpdb->comments WHERE comment_post_ID = %d", $post_id ));
+ if ( ! empty($comment_ids) ) {
+ do_action( 'delete_comment', $comment_ids );
+ $in_comment_ids = "'" . implode("', '", $comment_ids) . "'";
+ $wpdb->query( "DELETE FROM $wpdb->comments WHERE comment_ID IN($in_comment_ids)" );
+ do_action( 'deleted_comment', $comment_ids );
+ }
</ins><span class="cx">
</span><del>- $postmetaids = $wpdb->get_col( $wpdb->prepare( "SELECT meta_id FROM $wpdb->postmeta WHERE post_id = %d ", $post_id ));
- do_action( 'delete_postmeta', $postmetaids );
- $wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->postmeta WHERE meta_id IN(%s)", implode( ',', $postmetaids ) ));
- do_action( 'deleted_postmeta', $postmetaids );
</del><ins>+ $post_meta_ids = $wpdb->get_col( $wpdb->prepare( "SELECT meta_id FROM $wpdb->postmeta WHERE post_id = %d ", $post_id ));
+ if ( !empty($post_meta_ids) ) {
+ do_action( 'delete_postmeta', $post_meta_ids );
+ $in_post_meta_ids = "'" . implode("', '", $post_meta_ids) . "'";
+ $wpdb->query( "DELETE FROM $wpdb->postmeta WHERE meta_id IN($in_post_meta_ids)" );
+ do_action( 'deleted_postmeta', $post_meta_ids );
+ }
</ins><span class="cx">
</span><span class="cx"> do_action( 'delete_post', $post_id );
</span><span class="cx"> $wpdb->query( $wpdb->prepare( "DELETE FROM $wpdb->posts WHERE ID = %d", $post_id ));
</span></span></pre>
</div>
</div>
</body>
</html>