<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre, #msg p { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[12031] trunk: Do not close media thickbox after thumbnail is selected,
  in case uploads are in progress.</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/12031">12031</a></dd>
<dt>Author</dt> <dd>markjaquith</dd>
<dt>Date</dt> <dd>2009-10-14 08:42:32 +0000 (Wed, 14 Oct 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>Do not close media thickbox after thumbnail is selected, in case uploads are in progress. see <a href="http://trac.wordpress.org/ticket/10928">#10928</a></pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminjssetpostthumbnailhandlerdevjs">trunk/wp-admin/js/set-post-thumbnail-handler.dev.js</a></li>
<li><a href="#trunkwpadminjssetpostthumbnailhandlerjs">trunk/wp-admin/js/set-post-thumbnail-handler.js</a></li>
<li><a href="#trunkwpadminjssetpostthumbnaildevjs">trunk/wp-admin/js/set-post-thumbnail.dev.js</a></li>
<li><a href="#trunkwpadminjssetpostthumbnailjs">trunk/wp-admin/js/set-post-thumbnail.js</a></li>
<li><a href="#trunkwpincludesscriptloaderphp">trunk/wp-includes/script-loader.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminjssetpostthumbnailhandlerdevjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/set-post-thumbnail-handler.dev.js (12030 => 12031)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/set-post-thumbnail-handler.dev.js        2009-10-14 07:30:10 UTC (rev 12030)
+++ trunk/wp-admin/js/set-post-thumbnail-handler.dev.js        2009-10-14 08:42:32 UTC (rev 12031)
</span><span class="lines">@@ -5,7 +5,4 @@
</span><span class="cx">         if ( jQuery('input[value=_thumbnail_id]').size() &gt; 0 ) {
</span><span class="cx">                 jQuery('#meta\\[' + jQuery('input[value=_thumbnail_id]').attr('id').match(/[0-9]+/) + '\\]\\[value\\]' ).text(id);
</span><span class="cx">         }
</span><del>-}
-function WPCloseTB(){
-        tb_remove();
</del><span class="cx"> }
</span><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkwpadminjssetpostthumbnailhandlerjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/set-post-thumbnail-handler.js (12030 => 12031)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/set-post-thumbnail-handler.js        2009-10-14 07:30:10 UTC (rev 12030)
+++ trunk/wp-admin/js/set-post-thumbnail-handler.js        2009-10-14 08:42:32 UTC (rev 12031)
</span><span class="lines">@@ -1 +1 @@
</span><del>-function WPSetThumbnailHTML(html){jQuery(&quot;#postthumbnaildiv .inside&quot;).html(html)}function WPSetThumbnailID(id){if(jQuery(&quot;input[value=_thumbnail_id]&quot;).size()&gt;0){jQuery(&quot;#meta\\[&quot;+jQuery(&quot;input[value=_thumbnail_id]&quot;).attr(&quot;id&quot;).match(/[0-9]+/)+&quot;\\]\\[value\\]&quot;).text(id)}}function WPCloseTB(){tb_remove()};
</del><span class="cx">\ No newline at end of file
</span><ins>+function WPSetThumbnailHTML(html){jQuery(&quot;#postthumbnaildiv .inside&quot;).html(html)}function WPSetThumbnailID(id){if(jQuery(&quot;input[value=_thumbnail_id]&quot;).size()&gt;0){jQuery(&quot;#meta\\[&quot;+jQuery(&quot;input[value=_thumbnail_id]&quot;).attr(&quot;id&quot;).match(/[0-9]+/)+&quot;\\]\\[value\\]&quot;).text(id)}};
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkwpadminjssetpostthumbnaildevjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/set-post-thumbnail.dev.js (12030 => 12031)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/set-post-thumbnail.dev.js        2009-10-14 07:30:10 UTC (rev 12030)
+++ trunk/wp-admin/js/set-post-thumbnail.dev.js        2009-10-14 08:42:32 UTC (rev 12031)
</span><span class="lines">@@ -12,7 +12,6 @@
</span><span class="cx">                         jQuery('#media-item-' + id + ' &gt; a.wp-post-thumbnail').hide();
</span><span class="cx">                         win.WPSetThumbnailID(id);
</span><span class="cx">                         win.WPSetThumbnailHTML(str);
</span><del>-                        win.WPCloseTB();
</del><span class="cx">                 }
</span><span class="cx">         }
</span><span class="cx">         );
</span></span></pre></div>
<a id="trunkwpadminjssetpostthumbnailjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/set-post-thumbnail.js (12030 => 12031)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/set-post-thumbnail.js        2009-10-14 07:30:10 UTC (rev 12030)
+++ trunk/wp-admin/js/set-post-thumbnail.js        2009-10-14 08:42:32 UTC (rev 12031)
</span><span class="lines">@@ -1 +1 @@
</span><del>-function WPSetAsThumbnail(id){jQuery(&quot;#media-item-&quot;+id+&quot; &gt; a.wp-post-thumbnail&quot;).text(setPostThumbnailL10n.saving).attr(&quot;href&quot;,&quot;#&quot;);jQuery.post(ajaxurl,{action:&quot;set-post-thumbnail&quot;,post_id:post_id,thumbnail_id:id,cookie:encodeURIComponent(document.cookie)},function(str){var win=window.dialogArguments||opener||parent||top;if(str==&quot;0&quot;){alert(setPostThumbnailL10n.error);win.cwsCloseTB()}else{jQuery(&quot;a.wp-post-thumbnail&quot;).text(setPostThumbnailL10n.setThumbnail);jQuery(&quot;#media-item-&quot;+id+&quot; &gt; a.wp-post-thumbnail&quot;).hide();win.WPSetThumbnailID(id);win.WPSetThumbnailHTML(str);win.WPCloseTB()}})};
</del><span class="cx">\ No newline at end of file
</span><ins>+function WPSetAsThumbnail(id){jQuery(&quot;#media-item-&quot;+id+&quot; &gt; a.wp-post-thumbnail&quot;).text(setPostThumbnailL10n.saving).attr(&quot;href&quot;,&quot;#&quot;);jQuery.post(ajaxurl,{action:&quot;set-post-thumbnail&quot;,post_id:post_id,thumbnail_id:id,cookie:encodeURIComponent(document.cookie)},function(str){var win=window.dialogArguments||opener||parent||top;if(str==&quot;0&quot;){alert(setPostThumbnailL10n.error);win.cwsCloseTB()}else{jQuery(&quot;a.wp-post-thumbnail&quot;).text(setPostThumbnailL10n.setThumbnail);jQuery(&quot;#media-item-&quot;+id+&quot; &gt; a.wp-post-thumbnail&quot;).hide();win.WPSetThumbnailID(id);win.WPSetThumbnailHTML(str)}})};
</ins><span class="cx">\ No newline at end of file
</span></span></pre></div>
<a id="trunkwpincludesscriptloaderphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/script-loader.php (12030 => 12031)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/script-loader.php        2009-10-14 07:30:10 UTC (rev 12030)
+++ trunk/wp-includes/script-loader.php        2009-10-14 08:42:32 UTC (rev 12031)
</span><span class="lines">@@ -375,7 +375,7 @@
</span><span class="cx">                 $scripts-&gt;add( 'image-edit', &quot;/wp-admin/js/image-edit$suffix.js&quot;, array('jquery', 'json2', 'imgareaselect'), '20090929' );
</span><span class="cx">                 $scripts-&gt;add_data( 'image-edit', 'group', 1 );
</span><span class="cx"> 
</span><del>-                $scripts-&gt;add( 'set-post-thumbnail', &quot;/wp-admin/js/set-post-thumbnail$suffix.js&quot;, array( 'jquery' ), '20091005' );
</del><ins>+                $scripts-&gt;add( 'set-post-thumbnail', &quot;/wp-admin/js/set-post-thumbnail$suffix.js&quot;, array( 'jquery' ), '20091014' );
</ins><span class="cx">                 $scripts-&gt;add_data( 'set-post-thumbnail', 'group', 1 );
</span><span class="cx">                 $scripts-&gt;localize( 'set-post-thumbnail', 'setPostThumbnailL10n', array(
</span><span class="cx">                         'setThumbnail' =&gt; __( 'Use for thumbnail' ),
</span><span class="lines">@@ -383,7 +383,7 @@
</span><span class="cx">                         'error' =&gt; __( 'Could not set that as the thumbnail image. Try a different attachment.' )
</span><span class="cx">                 ) );
</span><span class="cx"> 
</span><del>-                $scripts-&gt;add( 'set-post-thumbnail-handler', &quot;/wp-admin/js/set-post-thumbnail-handler$suffix.js&quot;, array( 'jquery' ), '20091005' );
</del><ins>+                $scripts-&gt;add( 'set-post-thumbnail-handler', &quot;/wp-admin/js/set-post-thumbnail-handler$suffix.js&quot;, array( 'jquery' ), '20091014' );
</ins><span class="cx">                 $scripts-&gt;add_data( 'set-post-thumbnail-handler', 'group', 1 );
</span><span class="cx">         
</span><span class="cx">         }
</span></span></pre>
</div>
</div>

</body>
</html>