<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre, #msg p { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[11976] trunk/wp-includes/post.php: Improve get_page_hierarchy,
props hailin, fixes #10853</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/11976">11976</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2009-09-26 22:45:52 +0000 (Sat, 26 Sep 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Improve get_page_hierarchy, props hailin, fixes <a href="http://trac.wordpress.org/ticket/10853">#10853</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludespostphp">trunk/wp-includes/post.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post.php (11975 => 11976)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post.php 2009-09-26 22:28:22 UTC (rev 11975)
+++ trunk/wp-includes/post.php 2009-09-26 22:45:52 UTC (rev 11976)
</span><span class="lines">@@ -2155,25 +2155,51 @@
</span><span class="cx"> /**
</span><span class="cx"> * Order the pages with children under parents in a flat list.
</span><span class="cx"> *
</span><ins>+ * It uses auxiliary structure to hold parent-children relationships and
+ * runs in O(N) complexity
+ *
</ins><span class="cx"> * @since 2.0.0
</span><span class="cx"> *
</span><span class="cx"> * @param array $posts Posts array.
</span><span class="cx"> * @param int $parent Parent page ID.
</span><span class="cx"> * @return array A list arranged by hierarchy. Children immediately follow their parents.
</span><span class="cx"> */
</span><del>-function get_page_hierarchy($posts, $parent = 0) {
- $result = array ( );
- if ($posts) { foreach ( (array) $posts as $post) {
- if ($post->post_parent == $parent) {
- $result[$post->ID] = $post->post_name;
- $children = get_page_hierarchy($posts, $post->ID);
- $result += $children; //append $children to $result
- }
- } }
</del><ins>+function &get_page_hierarchy( &$pages, $page_id = 0 ) {
+
+ if ( empty( $pages ) )
+ return null;
+
+ $children = array();
+ foreach ( (array) $pages as $p ) {
+
+ $parent_id = intval( $p->post_parent );
+ $children[ $parent_id ][] = $p;
+ }
+
+ $result = array();
+ _page_traverse_name( $page_id, $children, $result );
+
</ins><span class="cx"> return $result;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * function to traverse and return all the nested children post names of a root page.
+ * $children contains parent-chilren relations
+ *
+ */
+function _page_traverse_name( $page_id, &$children, &$result ){
+
+ if ( isset( $children[ $page_id ] ) ){
+
+ foreach( (array)$children[ $page_id ] as $child ) {
+
+ $result[ $child->ID ] = $child->post_name;
+ _page_traverse_name( $child->ID, $children, $result );
+ }
+ }
+}
+
+/**
</ins><span class="cx"> * Builds URI for a page.
</span><span class="cx"> *
</span><span class="cx"> * Sub pages will be in the "directory" under the parent page post name.
</span></span></pre>
</div>
</div>
</body>
</html>