<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre, #msg p { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[11957] trunk/wp-includes/theme.php:
Move theme preview away from using create_function and to predefined functions
.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/11957">11957</a></dd>
<dt>Author</dt> <dd>westi</dd>
<dt>Date</dt> <dd>2009-09-21 21:43:41 +0000 (Mon, 21 Sep 2009)</dd>
</dl>
<h3>Log Message</h3>
<pre>Move theme preview away from using create_function and to predefined functions. See <a href="http://trac.wordpress.org/ticket/10729">#10729</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesthemephp">trunk/wp-includes/theme.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesthemephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/theme.php (11956 => 11957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/theme.php 2009-09-21 21:33:00 UTC (rev 11956)
+++ trunk/wp-includes/theme.php 2009-09-21 21:43:41 UTC (rev 11957)
</span><span class="lines">@@ -886,13 +886,13 @@
</span><span class="cx"> if ( validate_file($_GET['template']) )
</span><span class="cx"> return;
</span><span class="cx">
</span><del>- add_filter( 'template', create_function('', "return '{$_GET['template']}';") );
</del><ins>+ add_filter( 'template', '_preview_theme_template_filter' );
</ins><span class="cx">
</span><span class="cx"> if ( isset($_GET['stylesheet']) ) {
</span><span class="cx"> $_GET['stylesheet'] = preg_replace('|[^a-z0-9_./-]|i', '', $_GET['stylesheet']);
</span><span class="cx"> if ( validate_file($_GET['stylesheet']) )
</span><span class="cx"> return;
</span><del>- add_filter( 'stylesheet', create_function('', "return '{$_GET['stylesheet']}';") );
</del><ins>+ add_filter( 'stylesheet', '_preview_theme_stylesheet_filter' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Prevent theme mods to current theme being used on theme being previewed
</span><span class="lines">@@ -903,6 +903,24 @@
</span><span class="cx"> add_action('setup_theme', 'preview_theme');
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Private function to modify the current template when previewing a theme
+ *
+ * @return string
+ */
+function _preview_theme_template_filter() {
+ return isset($_GET['template']) ? $_GET['template'] : '';
+}
+
+/**
+ * Private function to modify the current stylesheet when previewing a theme
+ *
+ * @return string
+ */
+function _preview_theme_stylesheet_filter() {
+ return isset($_GET['stylesheet']) ? $_GET['stylesheet'] : '';
+}
+
+/**
</ins><span class="cx"> * Callback function for ob_start() to capture all links in the theme.
</span><span class="cx"> *
</span><span class="cx"> * @since unknown
</span></span></pre>
</div>
</div>
</body>
</html>