<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre, #msg p { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[11810] trunk/wp-app.php:
  Enable the APP attachment file download to work correctly rather than just returning a lot of php notices
 .</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/11810">11810</a></dd>
<dt>Author</dt> <dd>westi</dd>
<dt>Date</dt> <dd>2009-08-13 20:31:12 +0000 (Thu, 13 Aug 2009)</dd>
</dl>

<h3>Log Message</h3>
<pre>Enable the APP attachment file download to work correctly rather than just returning a lot of php notices. Fixes <a href="http://trac.wordpress.org/ticket/10372">#10372</a> for trunk props mysz.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpappphp">trunk/wp-app.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpappphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-app.php (11809 => 11810)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-app.php        2009-08-13 20:11:52 UTC (rev 11809)
+++ trunk/wp-app.php        2009-08-13 20:31:12 UTC (rev 11810)
</span><span class="lines">@@ -780,6 +780,7 @@
</span><span class="cx">                 }
</span><span class="cx"> 
</span><span class="cx">                 $location = get_post_meta($entry['ID'], '_wp_attached_file', true);
</span><ins>+                $location = get_option ('upload_path') . '/' . $location; 
</ins><span class="cx">                 $filetype = wp_check_filetype($location);
</span><span class="cx"> 
</span><span class="cx">                 if(!isset($location) || 'attachment' != $entry['post_type'] || empty($filetype['ext']))
</span><span class="lines">@@ -789,11 +790,19 @@
</span><span class="cx">                 header('Content-Type: ' . $entry['post_mime_type']);
</span><span class="cx">                 header('Connection: close');
</span><span class="cx"> 
</span><del>-                $fp = fopen($location, &quot;rb&quot;);
-                while(!feof($fp)) {
-                        echo fread($fp, 4096);
</del><ins>+                if ($fp = fopen($location, &quot;rb&quot;)) { 
+                        status_header('200'); 
+                        header('Content-Type: ' . $entry['post_mime_type']); 
+                        header('Connection: close');
+
+                        while(!feof($fp)) {
+                                echo fread($fp, 4096);
+                        }
+
+                        fclose($fp);
+                } else {
+                        status_header ('404');
</ins><span class="cx">                 }
</span><del>-                fclose($fp);
</del><span class="cx"> 
</span><span class="cx">                 log_app('function',&quot;get_file($postID)&quot;);
</span><span class="cx">                 exit;
</span></span></pre>
</div>
</div>

</body>
</html>