
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--

#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre, #msg p { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }

#msg ul { overflow: auto; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<title>[11709] trunk/wp-admin/includes/template.php: Call wp_dropdown_users()

  with echo=

 0 when outputting the quickedit and bulkedit forms so as to remove the need for output buffering

 .</title>

</head>

<body>


<div id="msg">

<dl>

<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/11709">11709</a></dd>

<dt>Author</dt> <dd>westi</dd>

<dt>Date</dt> <dd>2009-07-11 09:17:09 +0000 (Sat, 11 Jul 2009)</dd>

</dl>


<h3>Log Message</h3>

<pre>Call wp_dropdown_users() with echo=0 when outputting the quickedit and bulkedit forms so as to remove the need for output buffering. Fixes <a href="http://trac.wordpress.org/ticket/10062">#10062</a> props johnbillion.</pre>


<h3>Modified Paths</h3>

<ul>

<li><a href="#trunkwpadminincludestemplatephp">trunk/wp-admin/includes/template.php</a></li>

</ul>


</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunkwpadminincludestemplatephp"></a>

<div class="modfile"><h4>Modified: trunk/wp-admin/includes/template.php (11708 => 11709)</h4>

<pre class="diff"><span>

<span class="info">--- trunk/wp-admin/includes/template.php        2009-07-11 09:11:15 UTC (rev 11708)

+++ trunk/wp-admin/includes/template.php        2009-07-11 09:17:09 UTC (rev 11709)

</span><span class="lines">@@ -1055,21 +1055,18 @@

</span><span class="cx"> 

</span><span class="cx"> &lt;?php endif; // $bulk

</span><span class="cx"> 

</span><del>-                ob_start();

</del><span class="cx">                 $authors = get_editable_user_ids( $current_user-&gt;id, true, $type ); // TODO: ROLE SYSTEM

</span><span class="cx">                 if ( $authors &amp;&amp; count( $authors ) &gt; 1 ) :

</span><del>-                        $users_opt = array('include' =&gt; $authors, 'name' =&gt; 'post_author', 'class'=&gt; 'authors', 'multi' =&gt; 1);

</del><ins>+                        $users_opt = array('include' =&gt; $authors, 'name' =&gt; 'post_author', 'class'=&gt; 'authors', 'multi' =&gt; 1, 'echo' =&gt; 0);

</ins><span class="cx">                         if ( $bulk )

</span><span class="cx">                                 $users_opt['show_option_none'] = __('- No Change -');

</span><del>-?&gt;

-                &lt;label&gt;

-                        &lt;span class=&quot;title&quot;&gt;&lt;?php _e( 'Author' ); ?&gt;&lt;/span&gt;

-                        &lt;?php wp_dropdown_users( $users_opt ); ?&gt;

-                &lt;/label&gt;

</del><span class="cx"> 

</span><del>-&lt;?php

</del><ins>+                $authors_dropdown  = '&lt;label&gt;';

+                $authors_dropdown .= '&lt;span class=&quot;title&quot;&gt;' . __( 'Author' ) . '&lt;/span&gt;';

+                $authors_dropdown .= wp_dropdown_users( $users_opt );

+                $authors_dropdown .= '&lt;/label&gt;';

+

</ins><span class="cx">                 endif; // authors

</span><del>-                $authors_dropdown = ob_get_clean();

</del><span class="cx"> ?&gt;

</span><span class="cx"> 

</span><span class="cx"> &lt;?php if ( !$bulk ) : echo $authors_dropdown; ?&gt;

</span></span></pre>

</div>

</div>


</body>

</html>