[wp-hackers] Plugin Upgrade Failing when using Subversion

[Mike Schinkel]

To follow up, the following HACK allows the plugins to be updated by ignoring .svn but it probably creates negative side effects elsewhere.

http://mikeschinkel.pastebin.com/f5d2cae8b

The fix should probably be in wp_upgrade_plug() from /wp-admin/includes/upgrade.php.  I'll look at that next.

-Mike Schinkel
http://mikeschinkel.com/

----- Original Message -----
From: "Mike Schinkel" <mikeschinkel at newclarity.net>
To: wp-hackers at lists.automattic.com
Sent: Wednesday, January 14, 2009 12:38:04 PM GMT -05:00 US/Canada Eastern
Subject: [wp-hackers] Plugin Upgrade Failing when using Subversion

Hi All:

I've just run into a problem with plugin upgrades failing when using Subversion for version control.  Subversion stores a collection of readme files and when the upgrade process tries to delete them it fails to and then fails the upgrade process.  Am I the first person on this list to experience this?  It fails in a very ungraceful way, i.e. basically it just says "Sorry, sux to be you." ;-)

Potential solutions:

1.) Bypass deleting any .svn directory(s) and in that case don't require the plugin directory to be deleted in order to continue the upgrade process.
2.) Remove the read-only attribute and delete the files.
3.) Something else?

I think #1 is most preferable because it doesn't loose the Subversion info and the next check-in will check-in the new plugin info.  Maybe this could be a configuration option, i.e. to do #1 by default or #2 if configured to do so instead?

I need this fixed ASAP so I can do the work to fix it but I've yet to contribute any patches so I don't know the process.

-Mike Schinkel
http://mikeschinkel.com/
_______________________________________________
wp-hackers mailing list
wp-hackers at lists.automattic.com
http://lists.automattic.com/mailman/listinfo/wp-hackers