[spam-stopper] rest.akismet.com

[Michael Foord]

Benj. Mako Hill wrote:
> <quote who="Mark Jaquith" date="Sat, Dec 09, 2006 at 07:03:10PM -0500">
>   
>> On Dec 9, 2006, at 5:57 PM, Michael Foord wrote:
>>
>>     
>>> Was this a temporary problem - or do I need to change my code ?
>>>       
>> Temporary.
>>
>> See: http://akismet.com/blog/2006/12/dns-outage/
>>     
>
> Actually, I I think it it's probably both.
>
> If urllib can't resolve a domain, it raises and exception which is not
> caught by your code. That's not ideal. I'm not sure what people want to
> happen when DNS isn't working but I'm pretty sure it's something other
> than a 500 and a traceback in the logs.
>
> It seems that the WP plugin just let spam through which, while ugly, may
> be the more graceful method of failure. At the very least, it should
> probably raise an Akismet error similar to what happens when a verify
> fails key call fails. Then it falls on people that use your library to
> decide how they want to treat those errors when they show up.
>
>   
Ok, I've made the change.

See the announcement at :

http://www.voidspace.org.uk/python/weblog/arch_d7_2006_12_09.shtml#e580

Let me know if there are any problems.

Fuzzyman
http://www.voidspace.org.uk/python/index.shtml

> Later,
> Mako
>
>   



-- 
No virus found in this outgoing message.
Checked by AVG Free Edition.
Version: 7.1.409 / Virus Database: 268.15.18/586 - Release Date: 13/12/2006