<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[GlotPress][1137] trunk/gp-includes/backpress: Remove old PHP4 Constructors in BackPress.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://glotpress.trac.wordpress.org/changeset/1137">1137</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://glotpress.trac.wordpress.org/changeset/1137","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>markoheijnen</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-09-24 18:15:42 +0000 (Thu, 24 Sep 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Remove old PHP4 Constructors in BackPress.
See <a href="http://glotpress.trac.wordpress.org/ticket/492">#492</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgpincludesbackpressclassbplogphp">trunk/gp-includes/backpress/class.bp-log.php</a></li>
<li><a href="#trunkgpincludesbackpressclassbpuserphp">trunk/gp-includes/backpress/class.bp-user.php</a></li>
<li><a href="#trunkgpincludesbackpressclasspasswordhashphp">trunk/gp-includes/backpress/class.passwordhash.php</a></li>
<li><a href="#trunkgpincludesbackpressclasswpajaxresponsephp">trunk/gp-includes/backpress/class.wp-ajax-response.php</a></li>
<li><a href="#trunkgpincludesbackpressclasswpauthphp">trunk/gp-includes/backpress/class.wp-auth.php</a></li>
<li><a href="#trunkgpincludesbackpressclasswphttpixrclientphp">trunk/gp-includes/backpress/class.wp-http-ixr-client.php</a></li>
<li><a href="#trunkgpincludesbackpressclasswpobjectcachephp">trunk/gp-includes/backpress/class.wp-object-cache.php</a></li>
<li><a href="#trunkgpincludesbackpressclasswpusersphp">trunk/gp-includes/backpress/class.wp-users.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgpincludesbackpressclassbplogphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/backpress/class.bp-log.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/backpress/class.bp-log.php 2015-09-24 18:12:36 UTC (rev 1136)
+++ trunk/gp-includes/backpress/class.bp-log.php 2015-09-24 18:15:42 UTC (rev 1137)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -72,7 +72,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return void
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function BP_log($level = false, $type = false, $filename = false)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function __construct( $level = false, $type = false, $filename = false )
</ins><span class="cx" style="display: block; padding: 0 10px"> {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->set_level($level);
</span><span class="cx" style="display: block; padding: 0 10px"> $this->set_type($type);
</span></span></pre></div>
<a id="trunkgpincludesbackpressclassbpuserphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/backpress/class.bp-user.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/backpress/class.bp-user.php 2015-09-24 18:12:36 UTC (rev 1136)
+++ trunk/gp-includes/backpress/class.bp-user.php 2015-09-24 18:15:42 UTC (rev 1137)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -99,7 +99,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var $last_name = '';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * PHP4 Constructor - Sets up the object properties.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Sets up the object properties.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * Retrieves the userdata and then assigns all of the data keys to direct
</span><span class="cx" style="display: block; padding: 0 10px"> * properties of the object. Calls {@link BP_User::_init_caps()} after
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -112,7 +112,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $name Optional. User's username
</span><span class="cx" style="display: block; padding: 0 10px"> * @return BP_User
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function BP_User( $id, $name = '' ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function __construct( $id, $name = '' ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> global $wp_users_object;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $id ) && empty( $name ) )
</span></span></pre></div>
<a id="trunkgpincludesbackpressclasspasswordhashphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/backpress/class.passwordhash.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/backpress/class.passwordhash.php 2015-09-24 18:12:36 UTC (rev 1136)
+++ trunk/gp-includes/backpress/class.passwordhash.php 2015-09-24 18:15:42 UTC (rev 1137)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -41,7 +41,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var $portable_hashes;
</span><span class="cx" style="display: block; padding: 0 10px"> var $random_state;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function PasswordHash($iteration_count_log2, $portable_hashes)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function __construct($iteration_count_log2, $portable_hashes)
</ins><span class="cx" style="display: block; padding: 0 10px"> {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->itoa64 = './0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunkgpincludesbackpressclasswpajaxresponsephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/backpress/class.wp-ajax-response.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/backpress/class.wp-ajax-response.php 2015-09-24 18:12:36 UTC (rev 1136)
+++ trunk/gp-includes/backpress/class.wp-ajax-response.php 2015-09-24 18:15:42 UTC (rev 1137)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18,7 +18,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var $responses = array();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * PHP4 Constructor - Passes args to {@link WP_Ajax_Response::add()}.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Passes args to {@link WP_Ajax_Response::add()}.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 2.1.0
</span><span class="cx" style="display: block; padding: 0 10px"> * @see WP_Ajax_Response::add()
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -26,9 +26,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string|array $args Optional. Will be passed to add() method.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return WP_Ajax_Response
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function WP_Ajax_Response( $args = '' ) {
- if ( !empty($args) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function __construct( $args = '' ) {
+ if ( ! empty( $args ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->add($args);
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunkgpincludesbackpressclasswpauthphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/backpress/class.wp-auth.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/backpress/class.wp-auth.php 2015-09-24 18:12:36 UTC (rev 1136)
+++ trunk/gp-includes/backpress/class.wp-auth.php 2015-09-24 18:15:42 UTC (rev 1137)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -8,11 +8,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> var $current = 0;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function WP_Auth( &$db, &$users, $cookies )
- {
- $this->__construct( $db, $users, $cookies );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array $cookies Array indexed by internal name of cookie. Values are arrays of array defining cookie parameters.
</span><span class="cx" style="display: block; padding: 0 10px"> * $cookies = array(
</span></span></pre></div>
<a id="trunkgpincludesbackpressclasswphttpixrclientphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/backpress/class.wp-http-ixr-client.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/backpress/class.wp-http-ixr-client.php 2015-09-24 18:12:36 UTC (rev 1136)
+++ trunk/gp-includes/backpress/class.wp-http-ixr-client.php 2015-09-24 18:15:42 UTC (rev 1137)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -8,7 +8,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class WP_HTTP_IXR_Client extends IXR_Client
</span><span class="cx" style="display: block; padding: 0 10px"> {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function WP_HTTP_IXR_Client($server, $path = false, $port = 80, $timeout = 15)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function __construct($server, $path = false, $port = 80, $timeout = 15)
</ins><span class="cx" style="display: block; padding: 0 10px"> {
</span><span class="cx" style="display: block; padding: 0 10px"> if (!$path) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Assume we have been given a URL instead
</span></span></pre></div>
<a id="trunkgpincludesbackpressclasswpobjectcachephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/backpress/class.wp-object-cache.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/backpress/class.wp-object-cache.php 2015-09-24 18:12:36 UTC (rev 1136)
+++ trunk/gp-includes/backpress/class.wp-object-cache.php 2015-09-24 18:15:42 UTC (rev 1137)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -266,31 +266,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * PHP4 constructor; Calls PHP 5 style constructor
- *
- * @since 2.0.0
- *
- * @return WP_Object_Cache
- */
- function WP_Object_Cache() {
- return $this->__construct();
- }
-
- /**
- * Sets up object properties; PHP 5 style constructor
- *
- * @since 2.0.8
- * @return null|WP_Object_Cache If cache is disabled, returns null.
- */
- function __construct() {
- /**
- * @todo This should be moved to the PHP4 style constructor, PHP5
- * already calls __destruct()
- */
- register_shutdown_function(array(&$this, "__destruct"));
- }
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * Will save the object cache before object is completely destroyed.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * Called upon object destruction, which should be when PHP ends.
</span></span></pre></div>
<a id="trunkgpincludesbackpressclasswpusersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/backpress/class.wp-users.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/backpress/class.wp-users.php 2015-09-24 18:12:36 UTC (rev 1136)
+++ trunk/gp-includes/backpress/class.wp-users.php 2015-09-24 18:15:42 UTC (rev 1137)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3,18 +3,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> class WP_Users {
</span><span class="cx" style="display: block; padding: 0 10px"> var $db;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function WP_Users( &$db ) {
- $this->__construct( $db );
-// register_shutdown_function( array(&$this, '__destruct') );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> function __construct( &$db ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->db =& $db;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-// function __destruct() {
-// }
-
</del><span class="cx" style="display: block; padding: 0 10px"> function _put_user( $args = null ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $defaults = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'ID' => false,
</span></span></pre>
</div>
</div>
</body>
</html>