<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[GlotPress][1077] trunk: Deprecate gp_parity_factory in favor of CSS3 for alternate row colors.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://glotpress.trac.wordpress.org/changeset/1077">1077</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://glotpress.trac.wordpress.org/changeset/1077","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>markoheijnen</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-07-17 13:05:01 +0000 (Fri, 17 Jul 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Deprecate gp_parity_factory in favor of CSS3 for alternate row colors.
Fixes <a href="http://glotpress.trac.wordpress.org/ticket/467">#467</a>
See <a href="http://glotpress.trac.wordpress.org/ticket/305">#305</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkcssstylecss">trunk/css/style.css</a></li>
<li><a href="#trunkgpincludesassetsloaderphp">trunk/gp-includes/assets-loader.php</a></li>
<li><a href="#trunkgpincludesdeprecatedphp">trunk/gp-includes/deprecated.php</a></li>
<li><a href="#trunkgpincludesmiscphp">trunk/gp-includes/misc.php</a></li>
<li><a href="#trunkgpincludesroutestranslationphp">trunk/gp-includes/routes/translation.php</a></li>
<li><a href="#trunkgptemplateslocalesphp">trunk/gp-templates/locales.php</a></li>
<li><a href="#trunkgptemplatesprojectphp">trunk/gp-templates/project.php</a></li>
<li><a href="#trunkgptemplatestranslationrowphp">trunk/gp-templates/translation-row.php</a></li>
<li><a href="#trunkgptemplatestranslationsphp">trunk/gp-templates/translations.php</a></li>
<li><a href="#trunktteststest_miscphp">trunk/t/tests/test_misc.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktteststest_deprecatedphp">trunk/t/tests/test_deprecated.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkcssstylecss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/css/style.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/css/style.css 2015-07-17 11:53:59 UTC (rev 1076)
+++ trunk/css/style.css 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -192,7 +192,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> word-wrap: break-word;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-table.translations tr.even {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+table.translations tr:nth-child(4n+3) {
</ins><span class="cx" style="display: block; padding: 0 10px"> background-color: #fcfcfc;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> table.translations tr.editor {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -607,13 +607,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .translation-sets tr, .locales tr {
</span><span class="cx" style="display: block; padding: 0 10px"> background-color: #eee;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.translation-sets tr.odd, .locales tr.odd {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.translation-sets tr:nth-child(odd), .locales tr:nth-child(odd) {
</ins><span class="cx" style="display: block; padding: 0 10px"> background-color: #fff;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> .translation-sets tr:hover, .locales tr:hover {
</span><span class="cx" style="display: block; padding: 0 10px"> background-color: #dee;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.translation-sets tr.odd:hover, .locales tr.odd:hover {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.translation-sets tr:nth-child(odd):hover, .locales tr:nth-child(odd):hover {
</ins><span class="cx" style="display: block; padding: 0 10px"> background-color: #eff;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> #submit {
</span></span></pre></div>
<a id="trunkgpincludesassetsloaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/assets-loader.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/assets-loader.php 2015-07-17 11:53:59 UTC (rev 1076)
+++ trunk/gp-includes/assets-loader.php 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -10,7 +10,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> //$styles->text_direction = 'rtl' == get_bloginfo( 'text_direction' ) ? 'rtl' : 'ltr';
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->text_direction = 'ltr';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $styles->add( 'base', '/style.css', array(), '20141019' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $styles->add( 'base', '/style.css', array(), '20150717' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $styles->add( 'install', '/install.css', array('base'), '20140902' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunkgpincludesdeprecatedphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/deprecated.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/deprecated.php 2015-07-17 11:53:59 UTC (rev 1076)
+++ trunk/gp-includes/deprecated.php 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -36,3 +36,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $export_call = $locals? 'extract('.var_export( $locals, true ).', EXTR_PREFIX_SAME, "ext");' : '';
</span><span class="cx" style="display: block; padding: 0 10px"> return create_function( $args, $export_call.' return ('.rtrim( $expression, '; ' ).');' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+/**
+ * Returns a function, which returns the string "odd" or the string "even" alternatively.
+ */
+function gp_parity_factory() {
+ return create_function( '', 'static $parity = "even"; if ($parity == "even") $parity = "odd"; else $parity = "even"; return $parity;');
+}
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of file
</span></span></pre></div>
<a id="trunkgpincludesmiscphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/misc.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/misc.php 2015-07-17 11:53:59 UTC (rev 1076)
+++ trunk/gp-includes/misc.php 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -126,13 +126,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Returns a function, which returns the string "odd" or the string "even" alternatively.
- */
-function gp_parity_factory() {
- return create_function( '', 'static $parity = "even"; if ($parity == "even") $parity = "odd"; else $parity = "even"; return $parity;');
-}
-
-/**
</del><span class="cx" style="display: block; padding: 0 10px"> * Builds SQL LIMIT/OFFSET clause for the given page
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param integer $page The page number. The first page is 1.
</span></span></pre></div>
<a id="trunkgpincludesroutestranslationphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/routes/translation.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/routes/translation.php 2015-07-17 11:53:59 UTC (rev 1076)
+++ trunk/gp-includes/routes/translation.php 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -206,7 +206,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $translations ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $t = $translations[0];
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $parity = returner( 'even' );
</del><span class="cx" style="display: block; padding: 0 10px"> $can_edit = $this->can( 'edit', 'translation-set', $translation_set->id );
</span><span class="cx" style="display: block; padding: 0 10px"> $can_write = $this->can( 'write', 'project', $project->id );
</span><span class="cx" style="display: block; padding: 0 10px"> $can_approve = $this->can( 'approve', 'translation-set', $translation_set->id );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -383,7 +382,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $translations = GP::$translation->for_translation( $project, $translation_set, 'no-limit', array('translation_id' => $translation->id, 'status' => 'either'), array() );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $translations ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $t = $translations[0];
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $parity = returner( 'even' );
</del><span class="cx" style="display: block; padding: 0 10px"> $can_edit = $this->can( 'edit', 'translation-set', $translation_set->id );
</span><span class="cx" style="display: block; padding: 0 10px"> $can_write = $this->can( 'write', 'project', $project->id );
</span><span class="cx" style="display: block; padding: 0 10px"> $can_approve = $this->can( 'approve', 'translation-set', $translation_set->id );
</span></span></pre></div>
<a id="trunkgptemplateslocalesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-templates/locales.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-templates/locales.php 2015-07-17 11:53:59 UTC (rev 1076)
+++ trunk/gp-templates/locales.php 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2,7 +2,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> gp_title( __('Locales < GlotPress') );
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script('common');
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script('tablesorter');
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-$parity = gp_parity_factory();
</del><span class="cx" style="display: block; padding: 0 10px"> gp_tmpl_header();
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -22,7 +21,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </thead>
</span><span class="cx" style="display: block; padding: 0 10px"> <tbody>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php foreach ( $locales as $locale ) : ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <tr class="<?php echo $parity(); ?>">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <tr>
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php echo "<td>" . gp_link_get( gp_url_join( gp_url_current(), $locale->slug ), $locale->english_name ) . "</td>" ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php echo "<td>" . gp_link_get( gp_url_join( gp_url_current(), $locale->slug ), $locale->native_name ) . "</td>" ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php echo "<td>" . gp_link_get( gp_url_join( gp_url_current(), $locale->slug ), $locale->slug ) . "</td>" ?>
</span></span></pre></div>
<a id="trunkgptemplatesprojectphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-templates/project.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-templates/project.php 2015-07-17 11:53:59 UTC (rev 1076)
+++ trunk/gp-templates/project.php 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4,7 +4,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script( 'common' );
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script('tablesorter');
</span><span class="cx" style="display: block; padding: 0 10px"> $edit_link = gp_link_project_edit_get( $project, __('(edit)') );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-$parity = gp_parity_factory();
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $project->active ) {
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'gp_breadcrumb', function( $s ) { return $s . '<span class="active bubble">' . __('Active') . '</span>'; } );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -48,7 +47,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </thead>
</span><span class="cx" style="display: block; padding: 0 10px"> <tbody>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php foreach( $translation_sets as $set ): ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <tr class="<?php echo $parity(); ?>">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <tr>
</ins><span class="cx" style="display: block; padding: 0 10px"> <td>
</span><span class="cx" style="display: block; padding: 0 10px"> <strong><?php gp_link( gp_url_project( $project, gp_url_join( $set->locale, $set->slug ) ), $set->name_with_locale() ); ?></strong>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php if ( $set->current_count && $set->current_count >= $set->all_count * 0.9 ):
</span></span></pre></div>
<a id="trunkgptemplatestranslationrowphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-templates/translation-row.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-templates/translation-row.php 2015-07-17 11:53:59 UTC (rev 1076)
+++ trunk/gp-templates/translation-row.php 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -11,7 +11,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $can_reject_self = (GP::$user->current()->user_login == $t->user_login && $t->translation_status == "waiting");
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<tr class="preview <?php echo $parity().' '.$status_class.' '.$warning_class.' '.$priority_class ?>" id="preview-<?php echo $t->row_id ?>" row="<?php echo $t->row_id; ?>">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<tr class="preview <?php echo $status_class.' '.$warning_class.' '.$priority_class ?>" id="preview-<?php echo $t->row_id ?>" row="<?php echo $t->row_id; ?>">
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php if ( $can_approve ) : ?><th scope="row" class="checkbox"><input type="checkbox" name="selected-row[]" /></th><?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php /*
</span><span class="cx" style="display: block; padding: 0 10px"> <td class="priority" style="background-color: <?php echo $priority_char[$t->priority][1] ?>; color: <?php echo $priority_char[$t->priority][2] ?>; text-align: center; font-size: 1.2em;" title="<?php echo esc_attr('Priority: '.gp_array_get( GP::$original->get_static( 'priorities' ), $t->priority )); ?>">
</span></span></pre></div>
<a id="trunkgptemplatestranslationsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-templates/translations.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-templates/translations.php 2015-07-17 11:53:59 UTC (rev 1076)
+++ trunk/gp-templates/translations.php 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -12,7 +12,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // localizer adds var in front of the variable name, so we can't use $gp.editor.options
</span><span class="cx" style="display: block; padding: 0 10px"> $editor_options = compact('can_approve', 'can_write', 'url', 'discard_warning_url', 'set_priority_url', 'set_status_url');
</span><span class="cx" style="display: block; padding: 0 10px"> wp_localize_script( 'editor', '$gp_editor_options', $editor_options );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-$parity = gp_parity_factory();
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> gp_tmpl_header();
</span><span class="cx" style="display: block; padding: 0 10px"> $i = 0;
</span></span></pre></div>
<a id="trunktteststest_deprecatedphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/t/tests/test_deprecated.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/t/tests/test_deprecated.php (rev 0)
+++ trunk/t/tests/test_deprecated.php 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,19 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+class GP_Test_Deprecated extends GP_UnitTestCase {
+
+ function test_gp_parity_factory() {
+ $gen = gp_parity_factory();
+ $concurrent = gp_parity_factory();
+
+ $this->assertEquals( "odd", $gen() );
+ $this->assertEquals( "odd", $concurrent() );
+ $this->assertEquals( "even", $gen() );
+ $this->assertEquals( "odd", $gen() );
+ $this->assertEquals( "even", $concurrent() );
+ $this->assertEquals( "odd", $concurrent() );
+ $this->assertEquals( "even", $gen() );
+ $this->assertEquals( "even", $concurrent() );
+ }
+
+}
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of file
</span></span></pre></div>
<a id="trunktteststest_miscphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/t/tests/test_misc.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/t/tests/test_misc.php 2015-07-17 11:53:59 UTC (rev 1076)
+++ trunk/t/tests/test_misc.php 2015-07-17 13:05:01 UTC (rev 1077)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,24 +1,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> class GP_Test_Misc extends GP_UnitTestCase {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function test_gp_parity_factory() {
- $gen = gp_parity_factory();
- $concurrent = gp_parity_factory();
</del><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( "odd", $gen() );
- $this->assertEquals( "odd", $concurrent() );
- $this->assertEquals( "even", $gen() );
- $this->assertEquals( "odd", $gen() );
- $this->assertEquals( "even", $concurrent() );
- $this->assertEquals( "odd", $concurrent() );
- $this->assertEquals( "even", $gen() );
- $this->assertEquals( "even", $concurrent() );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> function test_gp_array_flatten() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( array(), gp_array_flatten( array() ) );
- $this->assertEquals( array( 1, 2, 3 ), gp_array_flatten( array( 1, array( 2, 3 ) ) ) );
- $this->assertEquals( array( 1, 2, 3, 4, 5, 6, 7 ), gp_array_flatten( array( 1, array( 2, array( 3, 4 ), 5, ), 6, array( 7 ) ) ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertEquals( array(), gp_array_flatten( array() ) );
+ $this->assertEquals( array( 1, 2, 3 ), gp_array_flatten( array( 1, array( 2, 3 ) ) ) );
+ $this->assertEquals( array( 1, 2, 3, 4, 5, 6, 7 ), gp_array_flatten( array( 1, array( 2, array( 3, 4 ), 5, ), 6, array( 7 ) ) ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function test_gp_array_zip() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -43,4 +30,5 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function test_gp_object_has_var_returs_true_if_var_is_null() {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( gp_object_has_var( (object)array( 'baba' => null), 'baba' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of file
</span></span></pre>
</div>
</div>
</body>
</html>