<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[GlotPress][1053] trunk: Switching move lambda calls to anonymous functions.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://glotpress.trac.wordpress.org/changeset/1053">1053</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://glotpress.trac.wordpress.org/changeset/1053","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>markoheijnen</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-06-10 18:46:45 +0000 (Wed, 10 Jun 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Switching move lambda calls to anonymous functions. See <a href="http://glotpress.trac.wordpress.org/ticket/305">#305</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgpincludesroutesprojectphp">trunk/gp-includes/routes/project.php</a></li>
<li><a href="#trunkgpincludestemplatephp">trunk/gp-includes/template.php</a></li>
<li><a href="#trunkgpincludesthingstranslationphp">trunk/gp-includes/things/translation.php</a></li>
<li><a href="#trunkgptemplateshelperfunctionsphp">trunk/gp-templates/helper-functions.php</a></li>
<li><a href="#trunkgptemplatesprojectphp">trunk/gp-templates/project.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgpincludesroutesprojectphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/routes/project.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/routes/project.php 2015-06-10 16:47:25 UTC (rev 1052)
+++ trunk/gp-includes/routes/project.php 2015-06-10 18:46:45 UTC (rev 1053)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -33,7 +33,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- usort( $translation_sets, lambda('$a, $b', '$a->current_count < $b->current_count' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ usort( $translation_sets, function( $a, $b ) {
+ return( $a->current_count < $b->current_count );
+ });
</ins><span class="cx" style="display: block; padding: 0 10px"> $translation_sets = apply_filters( 'translation_sets_sort', $translation_sets );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $title = sprintf( __('%s project '), esc_html( $project->name ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -243,7 +245,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $path_to_root = array_slice( $project->path_to_root(), 1 );
</span><span class="cx" style="display: block; padding: 0 10px"> $permissions = GP::$validator_permission->by_project_id( $project->id );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $cmp_fn = lambda( '$x, $y', 'strcmp($x->locale_slug, $y->locale_slug);' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $cmp_fn = function( $x, $y ){
+ return strcmp( $x->locale_slug, $y->locale_slug );
+ };
</ins><span class="cx" style="display: block; padding: 0 10px"> usort( $permissions, $cmp_fn );
</span><span class="cx" style="display: block; padding: 0 10px"> $parent_permissions = array();
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunkgpincludestemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/template.php 2015-06-10 16:47:25 UTC (rev 1052)
+++ trunk/gp-includes/template.php 2015-06-10 18:46:45 UTC (rev 1053)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -65,7 +65,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function gp_title( $title = null ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! is_null( $title ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_filter( 'gp_title', function( $x ) use ( $title ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_filter( 'gp_title', function() use ( $title ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> return $title;
</span><span class="cx" style="display: block; padding: 0 10px"> }, 5 );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -95,7 +95,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $whole_breadcrumb = str_replace( '{separator}', $args['separator'], $args['breadcrumb-template'] );
</span><span class="cx" style="display: block; padding: 0 10px"> $whole_breadcrumb = str_replace( '{breadcrumb}', $breadcrumb_string, $whole_breadcrumb );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_filter( 'gp_breadcrumb', function( $x ) use ( $whole_breadcrumb ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_filter( 'gp_breadcrumb', function() use ( $whole_breadcrumb ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> return $whole_breadcrumb;
</span><span class="cx" style="display: block; padding: 0 10px"> }, 5 );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -266,11 +266,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function gp_array_of_things_to_json( $array ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return json_encode( array_map( lambda( '$thing', '$thing->fields();' ), $array ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return json_encode( array_map( function( $thing ) { return $thing->fields(); }, $array ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function gp_array_of_array_of_things_to_json( $array ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $map_to_fields = create_function( '$array', 'return array_map( lambda( \'$thing\', \'$thing->fields();\' ), $array );' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $map_to_fields = function( $array ) {
+ return array_map( function( $thing ) {
+ return $thing->fields();
+ }, $array );
+ };
+
</ins><span class="cx" style="display: block; padding: 0 10px"> return json_encode( array_map( $map_to_fields, $array ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunkgpincludesthingstranslationphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/things/translation.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/things/translation.php 2015-06-10 16:47:25 UTC (rev 1052)
+++ trunk/gp-includes/things/translation.php 2015-06-10 18:46:45 UTC (rev 1053)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -144,10 +144,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $join_type = 'LEFT';
</span><span class="cx" style="display: block; padding: 0 10px"> $join_where[] = 't.status != "rejected"';
</span><span class="cx" style="display: block; padding: 0 10px"> $join_where[] = 't.status != "old"';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $statuses = array_filter( $statuses, lambda( '$x', '$x != "untranslated"' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $statuses = array_filter( $statuses, function( $x ) { return $x != 'untranslated'; } );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $statuses = array_filter( $statuses, lambda( '$s', 'in_array($s, $statuses)', array( 'statuses' => $this->get_static( 'statuses' ) ) ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $statuses = array_filter( $statuses, function( $s ) {
+ return in_array( $s, $this->get_static( 'statuses' ) );
+ } );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $statuses ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $statuses_where = array();
</span><span class="cx" style="display: block; padding: 0 10px"> foreach( $statuses as $single_status ) {
</span></span></pre></div>
<a id="trunkgptemplateshelperfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-templates/helper-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-templates/helper-functions.php 2015-06-10 16:47:25 UTC (rev 1052)
+++ trunk/gp-templates/helper-functions.php 2015-06-10 18:46:45 UTC (rev 1053)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -20,7 +20,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $glossary_entries_terms[ $key ] = $value->term;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- uasort( $glossary_entries_terms, lambda('$a, $b', 'gp_strlen($a) < gp_strlen($b)' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ uasort( $glossary_entries_terms, function( $a, $b ) { return gp_strlen($a) < gp_strlen($b); } );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $translations as $key => $t ) {
</span><span class="cx" style="display: block; padding: 0 10px"> //Save our current singular/plural strings before attempting any markup change. Also escape now, since we're going to add some html.
</span></span></pre></div>
<a id="trunkgptemplatesprojectphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-templates/project.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-templates/project.php 2015-06-10 16:47:25 UTC (rev 1052)
+++ trunk/gp-templates/project.php 2015-06-10 18:46:45 UTC (rev 1053)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5,7 +5,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script('tablesorter');
</span><span class="cx" style="display: block; padding: 0 10px"> $edit_link = gp_link_project_edit_get( $project, __('(edit)') );
</span><span class="cx" style="display: block; padding: 0 10px"> $parity = gp_parity_factory();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-if ( $project->active ) add_filter( 'gp_breadcrumb', lambda( '$s', '$s . "<span class=\\"active bubble\\">' . __('Active') . '</span>"' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+if ( $project->active ) {
+ add_filter( 'gp_breadcrumb', function( $s ) { return $s . '<span class="active bubble">' . __('Active') . '</span>'; } );
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> gp_tmpl_header();
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <h2><?php echo esc_html( $project->name ); ?> <?php echo $edit_link; ?></h2>
</span></span></pre>
</div>
</div>
</body>
</html>