<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[GlotPress][979] trunk: Disable public profiles for scalability reasons</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://glotpress.trac.wordpress.org/changeset/979">979</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://glotpress.trac.wordpress.org/changeset/979","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>nbachiyski</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-11-16 15:59:32 +0000 (Sun, 16 Nov 2014)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Disable public profiles for scalability reasons
Few of the queries run a full-table scan on the huuge translations table,
so we can't deploy this in production in its current form.
Since we want to deploy some later changes, here we just disable the route
and remove the links until performance is better.
See <a href="http://glotpress.trac.wordpress.org/ticket/340">#340</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgpincludesrouterphp">trunk/gp-includes/router.php</a></li>
<li><a href="#trunkgptemplatesprojectpermissionsphp">trunk/gp-templates/project-permissions.php</a></li>
<li><a href="#trunkgptemplatestranslationrowphp">trunk/gp-templates/translation-row.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgpincludesrouterphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-includes/router.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-includes/router.php 2014-11-16 14:01:35 UTC (rev 978)
+++ trunk/gp-includes/router.php 2014-11-16 15:59:32 UTC (rev 979)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -47,7 +47,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'get:/logout' => array('GP_Route_Login', 'logout'),
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> 'get:/profile' => array('GP_Route_Profile', 'profile_get'),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "get:/profile/$path" => array('GP_Route_Profile', 'profile_view'),
</del><span class="cx" style="display: block; padding: 0 10px"> 'post:/profile' => array('GP_Route_Profile', 'profile_post'),
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> 'get:/languages' => array('GP_Route_Locale', 'locales_get'),
</span></span></pre></div>
<a id="trunkgptemplatesprojectpermissionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-templates/project-permissions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-templates/project-permissions.php 2014-11-16 14:01:35 UTC (rev 978)
+++ trunk/gp-templates/project-permissions.php 2014-11-16 15:59:32 UTC (rev 979)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18,8 +18,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php foreach( $permissions as $permission ): ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <li>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="permission-action"><?php _e('user'); ?></span>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <span class="user"><?php printf( '<a href="%s">%s</a>',
- gp_url_profile( $permission->user->user_nicename ), esc_html( $permission->user->user_login ) ); ?></span>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <span class="user"><?php echo esc_html( $permission->user->user_login ); ?></span>
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="permission-action"><?php printf( __('can %s strings with locale'), esc_html( $permission->action ) ); ?></span>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="user"><?php echo esc_html( $permission->locale_slug ); ?></span>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="permission-action"><?php _e('and slug'); ?></span>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -35,8 +34,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php foreach( $parent_permissions as $permission ): ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <li>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="permission-action"><?php _e('user'); ?></span>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <span class="user"><?php printf( '<a href="%s">%s</a>',
- gp_url_profile( $permission->user->user_nicename ), esc_html( $permission->user->user_login ) ); ?></span>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <span class="user"><?php echo esc_html( $permission->user->user_login ); ?></span>
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="permission-action"><?php printf(__('can %s strings with locale'), esc_html( $permission->action )); ?></span>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="user"><?php echo esc_html( $permission->locale_slug ); ?></span>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="permission-action"><?php _e('and slug'); ?></span>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -66,4 +64,4 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </dt>
</span><span class="cx" style="display: block; padding: 0 10px"> </form>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-gp_tmpl_footer();
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of file
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+gp_tmpl_footer();
</ins></span></pre></div>
<a id="trunkgptemplatestranslationrowphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/gp-templates/translation-row.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/gp-templates/translation-row.php 2014-11-16 14:01:35 UTC (rev 978)
+++ trunk/gp-templates/translation-row.php 2014-11-16 15:59:32 UTC (rev 979)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -140,16 +140,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <dt><?php _e('Translated by:'); ?></dt>
</span><span class="cx" style="display: block; padding: 0 10px"> <dd><?php
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $t->user_display_name && $t->user_display_name != $t->user_login ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- printf( '<a href="%s">%s(%s)</a>',
- gp_url_profile( $t->user_nicename ),
- $t->user_display_name,
- $t->user_login
- );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ printf( '%s (%s)', $t->user_display_name, $t->user_login );
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- printf( '<a href="%s">%s</a>',
- gp_url_profile( $t->user_nicename ),
- $t->user_login
- );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo $t->user_login;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> ?></dd>
</span><span class="cx" style="display: block; padding: 0 10px"> </dl>
</span></span></pre>
</div>
</div>
</body>
</html>