<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[GlotPress][919] trunk/gp-includes/things/translation-set.php: Branching: performance improvements.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="https://glotpress.trac.wordpress.org/changeset/919">919</a></dd>
<dt>Author</dt> <dd>yoavf</dd>
<dt>Date</dt> <dd>2014-05-15 16:05:15 +0000 (Thu, 15 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Branching: performance improvements. About 20% faster on a project with 15k originals.
- Speed up the originals lookup by doing a non binary comparison (much faster since we now have indices - see <a href="http://glotpress.trac.wordpress.org/ticket/319">#319</a>).
- Lower memory usage by only getting the original ID rather than the full object.
- Lower memory usage by using _no_map when looking for transations sets.
See <a href="http://glotpress.trac.wordpress.org/ticket/65">#65</a>, See <a href="http://glotpress.trac.wordpress.org/ticket/300">#300</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgpincludesthingstranslationsetphp">trunk/gp-includes/things/translation-set.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgpincludesthingstranslationsetphp"></a>
<div class="modfile"><h4>Modified: trunk/gp-includes/things/translation-set.php (918 => 919)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/gp-includes/things/translation-set.php 2014-05-14 18:35:23 UTC (rev 918)
+++ trunk/gp-includes/things/translation-set.php 2014-05-15 16:05:15 UTC (rev 919)
</span><span class="lines">@@ -163,14 +163,23 @@
</span><span class="cx">
</span><span class="cx"> $source_set = GP::$translation_set->get( $source_translation_set_id );
</span><span class="cx"> if ( $source_set->project_id != $this->project_id ) {
</span><del>- $translations = GP::$translation->find_many( "translation_set_id = '{$source_set->id}'" );
</del><ins>+ $translations = GP::$translation->find_many_no_map( "translation_set_id = '{$source_set->id}'" );
</ins><span class="cx"> foreach ( $translations as $entry ) {
</span><span class="cx"> $source_original = GP::$original->get( $entry->original_id );
</span><del>- $original = GP::$original->by_project_id_and_entry( $this->project_id, $source_original );
- if ( $original ) {
- $entry->original_id = $original->id;
</del><ins>+
+ //Not using GP_Original::by_project_id_and_entry because the binary comparison doesn't use the index.
+ $where = array();
+ $where[] = is_null( $source_original->context )? '(context IS NULL OR %s IS NULL)' : 'context = %s';
+ $where[] = 'singular = %s';
+ $where[] = is_null( $source_original->plural )? '(plural IS NULL OR %s IS NULL)' : 'plural = %s';
+ $where[] = 'project_id = %d';
+ $where = implode( ' AND ', $where );
+
+ $original_id = $this->query( "SELECT id FROM $gpdb->originals WHERE $where", $source_original->context, $source_original->singular, $source_original->plural, $this->project_id );
+ if ( $original_id ) {
+ $entry->original_id = $original_id;
</ins><span class="cx"> $entry->translation_set_id = $this->id;
</span><del>- $translation = GP::$translation->create( $entry );
</del><ins>+ GP::$translation->create( $entry );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> } else {
</span></span></pre>
</div>
</div>
</body>
</html>