[glotpress-updates] [GlotPress] #480: gp_get_meta() doesn't use object cache

GlotPress noreply at wordpress.org
Sat Aug 8 06:42:22 UTC 2015


#480: gp_get_meta() doesn't use object cache
-----------------------+------------------------------------------
  Reporter:  ocean90   |      Owner:
      Type:  defect    |     Status:  new
  Priority:  critical  |  Milestone:  1.0
 Component:  Cache     |    Version:
Resolution:            |   Keywords:  needs-patch needs-unit-tests
-----------------------+------------------------------------------

Comment (by dd32):

 `gp_append_meta()` doesn't even work for non user objects..
 `$object_id_column` and `$slug` are not defined, It uses the wrong
 variable in the SQL string, etc, etc.

 I'm not too fond of these functions using `$object_type` as the Cache
 group, it seems like it's just asking for a cache conflict, but since
 GlotPress doesn't really utilise caching... it's not really an issue.

 [attachment:480.diff] is a first-run attempt at adding caching,
 `gp_append_meta()` still doesn't utilise the cache, although sets it.

--
Ticket URL: <https://glotpress.trac.wordpress.org/ticket/480#comment:1>
GlotPress <https://glotpress.trac.wordpress.org>
Easy comin', easy goin'


More information about the glotpress-updates mailing list