<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][14107] branches/12.0: Restrict bulk notification management to owner (14.0 branch).</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/14107">14107</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/14107","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dcavins</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2025-03-20 19:10:28 +0000 (Thu, 20 Mar 2025)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Restrict bulk notification management to owner (14.0 branch).
When attempting to manage notifications in bulk, ensure that the current user is either a site admin or owns all of the notifications specified.
Many thanks to Brian Mungah for responsibly reporting the problem.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches120srcbpnotificationsactionsbulkmanagephp">branches/12.0/src/bp-notifications/actions/bulk-manage.php</a></li>
<li><a href="#branches120srcbpnotificationsbpnotificationsfunctionsphp">branches/12.0/src/bp-notifications/bp-notifications-functions.php</a></li>
<li><a href="#branches120testsphpunittestcasesnotificationsfunctionsphp">branches/12.0/tests/phpunit/testcases/notifications/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches120srcbpnotificationsactionsbulkmanagephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/12.0/src/bp-notifications/actions/bulk-manage.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/12.0/src/bp-notifications/actions/bulk-manage.php 2025-03-20 18:41:03 UTC (rev 14106)
+++ branches/12.0/src/bp-notifications/actions/bulk-manage.php 2025-03-20 19:10:28 UTC (rev 14107)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -40,19 +40,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $notifications = wp_parse_id_list( $notifications );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Delete, mark as read or unread depending on the user 'action'.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $result = bp_notifications_bulk_manage_notifications( $action, $notifications );
+
+ // Set message depending on the user 'action'.
</ins><span class="cx" style="display: block; padding: 0 10px"> switch ( $action ) {
</span><span class="cx" style="display: block; padding: 0 10px"> case 'delete':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- bp_notifications_delete_notifications_by_ids( $notifications );
</del><span class="cx" style="display: block; padding: 0 10px"> bp_core_add_message( __( 'Notifications deleted.', 'buddypress' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> case 'read':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- bp_notifications_mark_notifications_by_ids( $notifications, false );
</del><span class="cx" style="display: block; padding: 0 10px"> bp_core_add_message( __( 'Notifications marked as read', 'buddypress' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> case 'unread':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- bp_notifications_mark_notifications_by_ids( $notifications, true );
</del><span class="cx" style="display: block; padding: 0 10px"> bp_core_add_message( __( 'Notifications marked as unread.', 'buddypress' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="branches120srcbpnotificationsbpnotificationsfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/12.0/src/bp-notifications/bp-notifications-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/12.0/src/bp-notifications/bp-notifications-functions.php 2025-03-20 18:41:03 UTC (rev 14106)
+++ branches/12.0/src/bp-notifications/bp-notifications-functions.php 2025-03-20 19:10:28 UTC (rev 14107)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -668,6 +668,56 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /** Helpers *******************************************************************/
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Mark a batch of notifications as read or unread or delete them.
+ *
+ * @since 12.5.3 (Backported from 14.3.4)
+ *
+ * @param string $user_id Action to run on notifications.
+ * @param array $notification_ids IDs of the notifications to change.
+ * @return bool True if the action run returned true.
+ */
+function bp_notifications_bulk_manage_notifications( $action, $notification_ids = array() ) {
+ $notification_ids = wp_parse_id_list( $notification_ids );
+ if ( empty( $notification_ids ) ) {
+ return false;
+ }
+
+ if ( ! current_user_can( 'bp_manage' ) ) {
+ // Regular users can only manage their own notifications.
+ $all_user_notifications = BP_Notifications_Notification::get(
+ array(
+ 'user_id' => bp_loggedin_user_id(),
+ 'is_new' => 'both', // Allow unread and read notices to be found.
+ 'update_meta_cache' => false,
+ )
+ );
+ $all_user_notifications_ids = wp_list_pluck( $all_user_notifications, 'id' );
+ $notification_ids = array_intersect( $notification_ids, $all_user_notifications_ids );
+ if ( empty( $notification_ids ) ) {
+ return false;
+ }
+ }
+
+ // Delete, mark as read or unread depending on the 'action'.
+ $result = false;
+ switch ( $action ) {
+ case 'delete':
+ $result = bp_notifications_delete_notifications_by_ids( $notification_ids );
+ break;
+
+ case 'read':
+ $result = bp_notifications_mark_notifications_by_ids( $notification_ids, false );
+ break;
+
+ case 'unread':
+ $result = bp_notifications_mark_notifications_by_ids( $notification_ids, true );
+ break;
+ }
+
+ return ( bool ) $result;
+}
+
+/**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Check if a user has access to a specific notification.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * Used before deleting a notification for a user.
</span></span></pre></div>
<a id="branches120testsphpunittestcasesnotificationsfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/12.0/tests/phpunit/testcases/notifications/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/12.0/tests/phpunit/testcases/notifications/functions.php 2025-03-20 18:41:03 UTC (rev 14106)
+++ branches/12.0/tests/phpunit/testcases/notifications/functions.php 2025-03-20 19:10:28 UTC (rev 14107)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -501,4 +501,61 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEquals( $n, $n_obj->id );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( 1 === (int) $n_obj->is_new );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * @group bulk_manage_notifications
+ */
+ public function test_bp_notifications_bulk_manage_notifications_user_must_own_items() {
+ $u1 = self::factory()->user->create();
+ $u2 = self::factory()->user->create();
+
+ // Create notifications
+ $n1 = self::factory()->notification->create( array(
+ 'component_name' => 'messages',
+ 'component_action' => 'new_message',
+ 'item_id' => 99,
+ 'user_id' => $u1,
+ ) );
+ $n2 = self::factory()->notification->create( array(
+ 'component_name' => 'messages',
+ 'component_action' => 'new_message',
+ 'item_id' => 100,
+ 'user_id' => $u1,
+ ) );
+ $n3 = self::factory()->notification->create( array(
+ 'component_name' => 'messages',
+ 'component_action' => 'new_message',
+ 'item_id' => 101,
+ 'user_id' => $u2,
+ ) );
+
+ wp_set_current_user( $u2 );
+ // Attempt to mark all as read.
+ bp_notifications_bulk_manage_notifications( 'read', array( $n1, $n2, $n3 ) );
+
+ // Check status of $n2 (which shouldn't be affected).
+ $n_get = BP_Notifications_Notification::get(
+ array(
+ 'id' => $n2,
+ 'component_name' => 'messages',
+ 'component_action' => 'new_message',
+ 'is_new' => 'both',
+ )
+ );
+ $n_obj = reset( $n_get );
+ $this->assertTrue( 1 === (int) $n_obj->is_new );
+
+ // Check status of $n3 (which should be affected).
+ $n_get = BP_Notifications_Notification::get(
+ array(
+ 'id' => $n3,
+ 'component_name' => 'messages',
+ 'component_action' => 'new_message',
+ 'is_new' => 'both',
+ )
+ );
+ $n_obj = reset( $n_get );
+ $this->assertTrue( 0 === (int) $n_obj->is_new );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>