<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13851] trunk/.github/workflows: Build/Test Tools: Enable running the tests on PHP 8.3.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13851">13851</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13851","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>espellcaste</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-05-04 13:12:23 +0000 (Sat, 04 May 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Build/Test Tools: Enable running the tests on PHP 8.3.
Enabling the tests to run in CI on PHP 8.3 allows BuddyPress core to start supporting this PHP version.
This also adds composer package validation and checks for Gitignored files.
Props imath
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/9144">#9144</a>
Closes https://github.com/buddypress/buddypress/pull/281</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkgithubworkflowscodingstandardsyml">trunk/.github/workflows/coding-standards.yml</a></li>
<li><a href="#trunkgithubworkflowsunittestsyml">trunk/.github/workflows/unit-tests.yml</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkgithubworkflowscodingstandardsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/coding-standards.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/coding-standards.yml 2024-05-04 12:56:31 UTC (rev 13850)
+++ trunk/.github/workflows/coding-standards.yml 2024-05-04 13:12:23 UTC (rev 13851)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6,10 +6,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> phpcs:
</span><span class="cx" style="display: block; padding: 0 10px"> name: PHPCS
</span><span class="cx" style="display: block; padding: 0 10px"> runs-on: ubuntu-latest
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- strategy:
- fail-fast: true
- matrix:
- php: ['8.2']
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> steps:
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Cancel previous runs of this workflow (pull requests only)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -24,14 +20,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Setup PHP
</span><span class="cx" style="display: block; padding: 0 10px"> uses: shivammathur/setup-php@v2
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- php-version: ${{ matrix.php }}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ php-version: 8.3
+ coverage: none
</ins><span class="cx" style="display: block; padding: 0 10px"> tools: composer:v2
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- coverage: none
</del><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Validate Composer
+ run: composer validate --strict
+
</ins><span class="cx" style="display: block; padding: 0 10px"> - name: Install dependencies
</span><span class="cx" style="display: block; padding: 0 10px"> uses: ramsey/composer-install@v2
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- with:
- composer-options: "--ignore-platform-reqs"
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Run PHPCS Escape
</span><span class="cx" style="display: block; padding: 0 10px"> run: composer phpcs-escape
</span></span></pre></div>
<a id="trunkgithubworkflowsunittestsyml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/.github/workflows/unit-tests.yml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/.github/workflows/unit-tests.yml 2024-05-04 12:56:31 UTC (rev 13850)
+++ trunk/.github/workflows/unit-tests.yml 2024-05-04 13:12:23 UTC (rev 13851)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -16,7 +16,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> strategy:
</span><span class="cx" style="display: block; padding: 0 10px"> fail-fast: false
</span><span class="cx" style="display: block; padding: 0 10px"> matrix:
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- php: ['7.4', '8.0', '8.1', '8.2']
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ php: ['7.4', '8.0', '8.1', '8.2', '8.3']
</ins><span class="cx" style="display: block; padding: 0 10px"> wp_version: ['master']
</span><span class="cx" style="display: block; padding: 0 10px"> include:
</span><span class="cx" style="display: block; padding: 0 10px"> - php: '8.0'
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -38,12 +38,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Checkout repository
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/checkout@v3
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ - name: Check Gitignored files
+ run: if [[ ! -z $(git ls-files -i --exclude-standard) ]]; then exit 1; fi
+
</ins><span class="cx" style="display: block; padding: 0 10px"> - name: Setup PHP
</span><span class="cx" style="display: block; padding: 0 10px"> uses: shivammathur/setup-php@v2
</span><span class="cx" style="display: block; padding: 0 10px"> with:
</span><span class="cx" style="display: block; padding: 0 10px"> php-version: ${{ matrix.php }}
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ extensions: gd, imagick, mysql, zip
+ coverage: none
</ins><span class="cx" style="display: block; padding: 0 10px"> tools: composer:v2
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- coverage: none
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> - name: Set up Node.js
</span><span class="cx" style="display: block; padding: 0 10px"> uses: actions/setup-node@v4
</span></span></pre>
</div>
</div>
</body>
</html>