<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13775] trunk/src/bp-core: Remove the tool to repair the members last activity tracker</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13775">13775</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13775","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-03-22 08:40:31 +0000 (Fri, 22 Mar 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Remove the tool to repair the members last activity tracker
In version 2.0 we decided to stop using the `last_activity` user meta in favor of tracing this information as an activity type having the same name. Meaning we stopped inserting this user meta for new members or any member of a community if the first BuddyPress installed version is upper than 1.9.
When upgrading from a version < 2.0 to the 2.0 version, the `bp_last_activity_migrate()` function is there to use the user meta to populate the activity table with corresponding `last_activity` activities.
We also created a repair tool in case the above upgrade task failed. This tool became obsolete but we forgot to remove it. It's now very problematic if an Admin user uses this tool as it will delete all `last_activity` activities but will fail at finding users having the `last_activity` meta.
To stop the spread, we decided to remove this tool during a minor release (12.4.0) as we felt it was an emergency.
Props vapvarun
See <a href="http://buddypress.trac.wordpress.org/ticket/9096">#9096</a> (trunk)</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcoreadminbpcoreadmintoolsphp">trunk/src/bp-core/admin/bp-core-admin-tools.php</a></li>
<li><a href="#trunksrcbpcoredeprecated120php">trunk/src/bp-core/deprecated/12.0.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcoreadminbpcoreadmintoolsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/admin/bp-core-admin-tools.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/admin/bp-core-admin-tools.php 2024-03-18 07:17:24 UTC (rev 13774)
+++ trunk/src/bp-core/admin/bp-core-admin-tools.php 2024-03-22 08:40:31 UTC (rev 13775)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -112,12 +112,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'bp_admin_repair_count_members',
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $repair_list[25] = array(
- 'bp-last-activity',
- __( 'Repair member "last activity" data.', 'buddypress' ),
- 'bp_admin_repair_last_activity',
- );
-
</del><span class="cx" style="display: block; padding: 0 10px"> // Friends:
</span><span class="cx" style="display: block; padding: 0 10px"> // - user friend count.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( bp_is_active( 'friends' ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -474,20 +468,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Repair user last_activity data.
- *
- * Re-runs the migration from usermeta introduced in BP 2.0.
- *
- * @since 2.0.0
- */
-function bp_admin_repair_last_activity() {
- /* translators: %s: the result of the action performed by the repair tool */
- $statement = __( 'Determining last activity dates for each user… %s', 'buddypress' );
- bp_last_activity_migrate();
- return array( 0, sprintf( $statement, __( 'Complete!', 'buddypress' ) ) );
-}
-
-/**
</del><span class="cx" style="display: block; padding: 0 10px"> * Create the invitations database table if it does not exist.
</span><span class="cx" style="display: block; padding: 0 10px"> * Migrate outstanding group invitations if needed.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span></span></pre></div>
<a id="trunksrcbpcoredeprecated120php"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/deprecated/12.0.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/deprecated/12.0.php 2024-03-18 07:17:24 UTC (rev 13774)
+++ trunk/src/bp-core/deprecated/12.0.php 2024-03-22 08:40:31 UTC (rev 13775)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1620,3 +1620,16 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return apply_filters( 'bp_core_get_all_posts_for_user', array( $all_posts ), '12.0.0' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+/**
+ * Repair user last_activity data.
+ *
+ * Re-runs the migration from usermeta introduced in BP 2.0.
+ *
+ * @since 2.0.0
+ * @deprecated 12.4.0
+ */
+function bp_admin_repair_last_activity() {
+ _deprecated_function( __FUNCTION__, '12.4.0' );
+ return array();
+}
</ins></span></pre>
</div>
</div>
</body>
</html>